1656086 - [Fission] scrolling doesn't work in add-on

Status: RESOLVED DUPLICATE of bug 1688096

(Core :: Layout, defect, P3)

Description

[kernp25]

Attachment: QS3PtaZIYh.mp4

STR:

1. Start Nightly in fission mode
2. Install https://addons.mozilla.org/firefox/addon/to-google-translate/
3. Click on the browser action icon from the installed extension

AR:
Scrolling does not work (the scrollbar is not moving). Clicking on links does nothing etc.

Comment 1

[kernp25]

Attachment: tF6lkxpZVv.mp4

Web page is working correctly in a Non-Fission window.

Comment 2

[Alex Cornestean]

Hello,

I’ve managed to reproduce the issue on the latest Nightly (81.0a1/20200730215452) only, under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS. As mentioned in the provided STR, the browser must be started with fission enabled, so for this I’ve set the fission.autostart pref to true and restarted the browser. I’ve only managed to test this on Nightly as on Beta and Release this pref is locked and cannot be changed. Dev Edition and Unbranded versions of Beta and Release also have this pref locked.

I’ve also searched for a regression window and narrowed it down to the 2019-04-17 build, however further bisecting was not possible as mozregression could not find any more builds to test (mozregression has been acting up lately for some reason). This is the corresponding pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b8f49a14c458f56a6a08e4c177671108e386be3a&tochange=02b89c29412b6c1444fe32a4847e5261e2bb3d00 .

Comment 3

[Tomislav Jovanovic :zombie]

I'll investigate

Please don't needinfo Rob on every issue.

Comment 4

[kernp25]

Attachment: f8Gd6val15.png

Comment 5

[kernp25]

My other add-on also does not work and is not correctly displayed in the popup. There is a space on the right side.

Comment 6

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly M6c

Comment 7

[Jens Stutte [:jstutte]]

Fission is disabled in 81.

Comment 8

[Tomislav Jovanovic :zombie]

This is the same as bug 1646817 for which I'm testing a patch, so marking as dupe.

Comment 9

[Tomislav Jovanovic :zombie]

I likely messed up the fission flag while testing, this is not the same as bug 1646817, still need to figure out what it is.

There's a also a bug here about content scripts in iframes inside extension popups/sidebars, but I'm filing that as a separate bug.

Comment 10

[Neha Kochar [:neha]]

Jim, this also looks related to bug 1672470. Please get this reviewed/triaged by the Graphics team too.

Comment 11

[Jim Mathies [:jimm]]

I don't see a browser action button for this add-on.

Comment 12

[Neha Kochar [:neha]]

My experience with the google translate add-on does not show the popup as shown in the reporter's video so I'm not able to verify the issue (Jim couldn't either).
Tom, can you confirm that you can see the issue and help the graphics team (jmathies) repro this and figure out the issue here?
Also, was the other issue (comment 4 and 5) addressed in a separate bug?

Comment 13

[Jim Mathies [:jimm]]

Should be fixed by bug 1688096.

Comment 14

[Neha Kochar [:neha]]

Assigning to aosmond (same as bug 1688096 assignee) so we don't have unassigned M6c bugs.

Comment 15

[kernp25]

Attachment: dRK70mhRca.mp4

Comment 16

[kernp25]

I tested it again and it seems to work now!

Only this issue still exists.

Comment 17

[Neha Kochar [:neha]]

(In reply to kernp25 from comment #16)

I tested it again and it seems to work now!

Only this issue still exists.

Thank you very much :kernp25.

Jim, the remaining issue (comment 4 and comment 5) is for incorrect spacing. I'll unassign aosmond and move this to M7 (Fx88), Please find the correct assignee for it.

Comment 18

[Neha Kochar [:neha]]

Changing the bug title as this is the only remaining issue.

Comment 19

[Neha Kochar [:neha]]

Jim, this is tracking Fission M7 (Fx88 - March 18). Can you please find an assignee for this so it can be fixed in time?

Comment 20

[Timothy Nikkel (:tnikkel)]

What is the add-on that has the problem?

Comment 21

[kernp25]

https://addons.mozilla.org/firefox/addon/yahoo-mail-notifier-we/

Comment 22

[Timothy Nikkel (:tnikkel)]

Thanks.

I don't think this is a webrender or graphics issue. The layout of the contents of popup is different, this is probably either an issue for layout or the extension api?

Comment 23

[kernp25]

Attachment: addon.zip

Test add-on for bug 1656086.

Comment 24

[kernp25]

I uploaded a test add-on. So you can reproduce the bug.

Comment 25

[Timothy Nikkel (:tnikkel)]

Thank you for the simple addon.

Regression range
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=88db9bea4580df16dc444668f8c2cddbb3414318&tochange=bbbe694dbff25ce304833a9c2f6520ba9f61fb32

Comment 26

[Timothy Nikkel (:tnikkel)]

(In reply to Timothy Nikkel (:tnikkel) from comment #25)

Thank you for the simple addon.

Regression range
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=88db9bea4580df16dc444668f8c2cddbb3414318&tochange=bbbe694dbff25ce304833a9c2f6520ba9f61fb32

Not sure what might have caused that in there. Read through that list one by one and I don't have a candidate to look at.

Comment 27

[Neha Kochar [:neha]]

Thank you :kernp25 for the test add-on.
Moving to Layout component as the only remaining issue is the incorrect spacing.

Comment 28

[Daniel Holbert [:dholbert]]

This bug has evolved quite a lot about what it's tracking.

For clarity, I'm going to file a new dedicated bug to cover the specific remaining layout issue here (which, by the way, I can reproduce by just directly loading the html testcase from the attached addon -- no addon-specific stuff is required on my machine)

Then we can close out this bug as a dupe of bug 1688096 (since that seems to have fixed the original/primary issue here, per comment 13 and comment 16.)

Comment 29

[Daniel Holbert [:dholbert]]

Adjusting bug summary to reflect the issue that was reported in comment 0 (which was fixed by bug 1688096), and duping to bug 1688096.

I've filed bug 1697890 to investigate the remaining issue with the blank space on the right.

Comment 30

[Hiroyuki Ikezoe (:hiro)]

(In reply to Daniel Holbert [:dholbert] from comment #28)

Then we can close out this bug as a dupe of bug 1688096 (since that seems to have fixed the original/primary issue here, per comment 13 and comment 16.)

This makes me think there's still gfxVars::UseWebRender callsites which should be replaced by the information whether we really use WebRender or not in the window (bug 1684128). That said, I don't think it's worth spending time on that bug.