1803705 - Restore functioning message thread in new about3Pane

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

After bug 1770852, the new message thread used in the new about3Pane is completely broken. Let's fix it!
This only affects the ash repo since comm-central still uses the old XUL tree.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Restore functioning message thread in new about3Pane. r=darktrojan

Comment 2

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/085d5414643ebe98589ad59b04ccc5d70450c2b2

Comment 3

[Geoff Lankow (:darktrojan)]

Not fixed, the subject column adds another copy of all the elements when invalidated, and TreeViewTable.columns having no initial value is breaking the test.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Fix subject cell during invalidation and fix the tests. r=darktrojan

Comment 5

[Martin Giger [:freaktechnik]]

https://hg.mozilla.org/projects/ash/rev/c770e5e47b50cf22e463d870c67318425da99966

Comment 6

[Alessandro Castellani [:aleca]]

Since we don't close ash bugs, and we don't really care about uplifts and tracking, I'm gonna keep using this to add following patches to reimplement all the thread pane features.

Comment 7

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Re-implement selectable column in message thread table header. r=darktrojan,freaktechnik

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Re-implement selectable column in message thread rows. r=darktrojan,freaktechnik

Depends on D164313

Comment 9

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Implement the delete column in the new tree view listbox. r=freaktechnik

Comment 10

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Fix broken list layout in the new TreeView. r=darktrojan

Comment 11

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Restore sortable columns and threaded column in the new about3Pane. r=darktrojan

Comment 12

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Restore all string columns and the flagged/star column in the new about3Pane. r=darktrojan

Comment 13

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Add all properties to the nsMsgDBView::GetRowProperties method. r=darktrojan

Comment 14

[Alessandro Castellani [:aleca]]

https://hg.mozilla.org/projects/ash/rev/1ba4e3b440710c06344803ad88bb364526048f26

Comment 15

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Implement the remaining icon columns in the thread pane. r=darktrojan

Comment 16

[Martin Giger [:freaktechnik]]

https://hg.mozilla.org/projects/ash/rev/ac8f283873d150e05c075a5e43d3a539bf3c5b04

Comment 17

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Restore the sort key indicator on load and on folder change. r=darktrojan

Comment 18

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/8db08cae78f843bc2708810eb9c9638ad689ec3b

Comment 19

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Do not restore sort indicator if dbView is not set. r=darktrojan

Comment 20

[Alessandro Castellani [:aleca]]

https://hg.mozilla.org/projects/ash/rev/eeb90f3106fe9955a33d7b34e5c57a895f0251c3

Comment 21

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Restore the columns visibility and order from the folder database. r=darktrojan

• Updates the stored columns visibility
• Sets things up for the ordinal update, which will happen once the drag&drop to reorder columns is implemented

WARNING: Use another profile as this might nuke your folders column state!

Comment 22

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Migrate thread tree strings to fluent. r=rjl

Comment 23

[Martin Giger [:freaktechnik]]

Pushed to ash:
https://hg.mozilla.org/projects/ash/rev/fa71a5ff7ecad631bd8dd0da0e530e2506ef5081

Comment 24

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Move strings to a dedicated about3Pane fluent file. r=freaktechnik

Comment 25

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Migrate thread tree strings to fluent. r=rjl

Depends on D167173

Comment 26

[Martin Giger [:freaktechnik]]

Pushed to ash:
https://hg.mozilla.org/projects/ash/rev/89d0a51e9f79cf847f5fc5241c64d7271ba60401

Comment 27

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Fix browser_invalidDbFolderLoad and handle missing folder database. r=freaktechnik

Comment 28

[Alessandro Castellani [:aleca]]

Attachment: Bug 1803705 - Reimplement message status indicators. r=#thunderbird-front-end-reviewers

Remplement the redirected, replied, forwarded, new, image status indicators and all their various combinations.

Comment 29

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/d06c47282b2be631e38eabca1d16166a834cab94
https://hg.mozilla.org/projects/ash/rev/8c09fe0f7d4c262edc204352216e06636148a169

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1729c1653594
Re-implement selectable column in message thread table header. r=darktrojan,freaktechnik
https://hg.mozilla.org/comm-central/rev/3b93f92e6728
Re-implement selectable column in message thread rows. r=darktrojan,freaktechnik
https://hg.mozilla.org/comm-central/rev/70e2ba614a05
Implement the delete column in the new tree view listbox. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/237a80f70886
Fix broken list layout in the new TreeView. r=darktrojan
https://hg.mozilla.org/comm-central/rev/5086e0ccf049
Restore sortable columns and threaded column in the new about3Pane. r=darktrojan
https://hg.mozilla.org/comm-central/rev/63e4f75293c1
Restore all string columns and the flagged/star column in the new about3Pane. r=darktrojan
https://hg.mozilla.org/comm-central/rev/ec685c2a6663
Fix duplicated fluent string. rs=me

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc0674b7aac1
Reimplement message status indicators. r=darktrojan