180568 - Remove "Enabled" column from about:plugins

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[u32858]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021029
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021029

about plugins enabled is incorrect

Reproducible: Always

Steps to Reproduce:
1.install java,
disable java in Prefs->advanced

Actual Results:  
see see about:plugins still shows enabled. exit, reload see that about:plugins
still shows enabled

Expected Results:  
should show disabled

Comment 1

[R.K.Aa.]

I believe about:plugins doesn't say whether a plugin is *enabled* or not - it
says someting about whether mozilla sees it as *installed* or not.

Comment 2

[u32858]

Well, there is a column and it is labeled "enabled" :

rpnp.so
    File name: rpnp.so
MIME Type Description Suffixes Enabled
audio/x-pn-realaudio-plugin RealPlayer Plugin Metafile rpm Yes


Shockwave Flash

    File name: libflashplayer.so
    Shockwave Flash 6.0 r60

MIME Type Description Suffixes Enabled
application/x-shockwave-flash Shockwave Flash swf Yes
application/futuresplash FutureSplash Player spl Yes

Comment 3

[R.K.Aa.]

You are absolutely right! Sorry.
Disabling java in prefs still leaves it appear as "Enabled" in about:plugins. Odd.

Comment 4

[Daniel Wang]

I believe "enabled" actually means that "this mime type will be handled
by this plug-in"

Comment 5

[u32858]

Hi,
Thanks for your comments.

I can not see the reason for a "handled" column, as it will always be "Yes"
(unless there is some way i do not know of)

If it is renamed Handled, i think there should be another column added to really
show the enabled status.

Regards

JG

Comment 6

[u32858]

Any progress on this anyone?
Regards

JG

Comment 7

[Brant Gurganus]

This is not a Help bug.

Comment 8

[Ian Oeschger (gone)]

moving stuff over to an outside-the-firewall email for the time being, looking
for people to pick these Help and doc bugs up for me.

Comment 9

[Andrew Schultz]

*** Bug 339757 has been marked as a duplicate of this bug. ***

Comment 10

[Frank Wein [:mcsmurf]]

*** Bug 339537 has been marked as a duplicate of this bug. ***

Comment 11

[Saint Wesonga]

Attachment: Patch

Comment 12

[Josh Aas]

Comment on attachment 421781 [details] [diff] [review]
Patch

I don't know what this column is for, but if it is really useless we should just remove it. Changing the name from "Enabled" to "Handled" doesn't make this much more clear.

Comment 13

[Josh Aas]

The file for about:plugins is here:

/toolkit/content/plugins.html

Seems like we can just kill that column. Disabled plugins don't show up in about:plugins so we wouldn't be listing MIME types for disabled plugins.

Comment 14

[Justin Dolske [:Dolske]]

Does it have anything to do with determining which plugin wins when multiple ones handle the same mimetype?

Comment 15

[Saint Wesonga]

(In reply to comment #14)
> Does it have anything to do with determining which plugin wins when multiple
> ones handle the same mimetype?

Yes, I think so - at least based on my understanding of the comment at http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/applications.js#1089 and the source at http://mxr.mozilla.org/mozilla-central/source/toolkit/content/plugins.html#148

Comment 16

[Saint Wesonga]

Attachment: Patch

Comment 17

[Josh Aas]

Attachment: Matching MIME types screenshot

No need to guess about whether or not that column helps with matching MIME types - it doesn't. I made two plugins with the same handled MIME types and both show up as enabled in a FF 3.6 nightly. This column is useless as far as I can tell.

Comment 18

[Josh Aas]

Comment on attachment 422130 [details] [diff] [review]
Patch

This patch looks good to me, lets get jst to look at it too in case he knows what this column was supposed to be for.

Comment 19

[Johnny Stenback (:jst)]

Comment on attachment 422130 [details] [diff] [review]
Patch

Yeah, I see no reason to keep this column. The one plugin that I see where we say "No" in the enabled column is for the default plugin, which we're getting rid of completely anyways.

Comment 21

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/89bc4e50e4b5

Comment 22

[[not reading bugmail]]

Well since your removing the column, it begs the question of a new bug which why is this a list of installed plugins and not enabled plugins?

You know its funny that the enabled column would actually make sense if we didn't actually hide disabled plugins on an installed plugins page.

Seeing how the top of the page says installed plugins, but in reality its showing users the list of enabled plugins with the exception of the default.

I guess there must have been a bug to change to list from installed to show only enabled. Why? It seems to me that that is the question, because we also just landed a change to the text when disabling all plugins to say no enabled plugins found [to display on this page].

And then this about:plugins page should really say "Enabled Plugins" because its no longer the "Installed Plugins"..

Comment 23

[Rimas Kudelis [use needinfo to ping]]

are yes_label and no_label from plugins.properties still being used anywhere?

Comment 24

[Marcia Knous [:marcia]]

Verified fixed using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100204 Minefield/3.7a1pre, Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20100204 Minefield/3.7a1pre and latest Win 7 nightly.

Comment 25

[Saint Wesonga]

Attachment: Remove Unused Labels

(In reply to comment #23)
> are yes_label and no_label from plugins.properties still being used anywhere?

No they aren't. Good catch.

Comment 26

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/32a13ebe9ba0

Comment 27

[[not reading bugmail]]

(In reply to comment #22)
> And then this about:plugins page should really say "Enabled Plugins" because
> its no longer the "Installed Plugins"..

FYI, This was changed in bug 548481 to match since bug 496198 also landed.

Comment 28

[Saint Wesonga]

We need to update https://developer.mozilla.org/en/Gecko_Plugin_API_Reference%3aPlug-in_Basics as well.