1807161 - Product details has wrong l10n changeset info for Thunderbird Betas 108.0b2 - 109.0b2

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P1)

Description

[Rob Lemley [:rjl]]

https://product-details.mozilla.org/1.0/l10n/Thunderbird-108.0b2-build1.json

Shows the fake "all" locale. Should enumerate the locales.

https://product-details.mozilla.org/1.0/thunderbird_primary_builds.json

Has an "all" locale with current beta and nightly versions.

Boils down to Ship-it using l10n-changesets.json data to build product-details.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1807161 - Restore l10n-changesets.json to its former glory. r=dandarnell

Using an "all" locale causes product-details issues.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1807161 - Fix desktop_comm_l10n.py to not use the fake "all" locale for revision info. r=dandarnell

Depends on D165880

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c86943c9082b
Restore l10n-changesets.json to its former glory. r=dandarnell
https://hg.mozilla.org/comm-central/rev/5ee43e7dc3b6
Fix desktop_comm_l10n.py to not use the fake "all" locale for revision info. r=dandarnell

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9310520 [details]
Bug 1807161 - Restore l10n-changesets.json to its former glory. r=dandarnell

[Approval Request Comment]
Regression caused by (bug #): 1765629
User impact if declined: N/A
Testing completed (on c-c, etc.): Daily - need to check product-details
Risk to taking this patch (and alternatives if risky):
Possibly another unforseen problem like this where product-details data is funny leading to odd website issues or worse. This doesn't affect esr though, just trying to generate correct data for beta.

NOTE: REQUEST IS FOR BOTH PATCHES ON THIS BUG

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9310521 [details]
Bug 1807161 - Fix desktop_comm_l10n.py to not use the fake "all" locale for revision info. r=dandarnell

[Triage Comment]
Approved for beta

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9310520 [details]
Bug 1807161 - Restore l10n-changesets.json to its former glory. r=dandarnell

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 109.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/b89d303b9dca
https://hg.mozilla.org/releases/comm-beta/rev/ab1f3529ae05

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9310520 [details]
Bug 1807161 - Restore l10n-changesets.json to its former glory. r=dandarnell

[Approval Request Comment]
More regression fix from bug 1765629

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9310520 [details]
Bug 1807161 - Restore l10n-changesets.json to its former glory. r=dandarnell

[Triage Comment]
approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.7.0:
https://hg.mozilla.org/releases/comm-esr102/rev/92f631b29f9e
https://hg.mozilla.org/releases/comm-esr102/rev/c36ddddd5536