1807838 - [Windows] Profile manager window size glitch on startup

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Alin Ilea, Desktop QA]

Attachment: 2022-12-28_15h35_39.mp4

Found in

• 110.0a1 (2022-12-28)

Affected versions

• 110.0a1 (2022-12-28)

Tested platforms

• Affected platforms: Windows 10
• Unaffected platforms: macOS, Ubuntu

Steps to reproduce

1. Launch the Fx profile manager.

Expected result

• The profile manager is opened accordingly without any glitches.

Actual result

• There is a glitch with the size of the profile manager window on startup.

Regression range
This is a regression from 2022-12-27. It worked ok on 110.0a1 (2022-12-27, build id: 20221227093156) and start broken on 110.0a1 (2022-12-27, build id: 20221227211321). Will try to find a more detailed regression range asap.

Comment 1

[Alice0775 White]

Regression window:
ttps://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4b2e3689cea010e9473792bd8f5a8606c862e09d&tochange=7966f6606190515258c3f19ad4d05ed4d317f164

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:smaug, since you are the author of the regressor, bug 1804295, could you take a look?

For more information, please visit auto_nag documentation.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: WIP: Bug 1807838, favor Gecko tasks for a short while after page load in the parent process

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I think this is a combination of bug 1795224 and bug 1804295. The first one added sizeToContent call, which triggers second SetSize call, where the height is a tiny bit larger.
Still investigating

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Oh, actually this is even older than bug 1795224.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: WIP: Bug 1807838, trigger element translation before load event

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1807838, try to translate elements before load event fires, r=emilio

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1807838 - Simplify AppWindow::SizeShellTo when sizing to the window shell. r=smaug

In this case we can do easier things than going through the shell and
assuming all sizes go through the window.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

(didn't mean to steal, can move comment 8 to another bug if / as needed)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f9088d3354d
Simplify AppWindow::SizeShellTo when sizing to the window shell. r=smaug

Comment 11

[Marian-Vasile Laza]

Backed out changeset 7f9088d3354d (Bug 1807838) for causing bc failures on browser_modal_resize.js.
Backout link
Push with failures <--> bc4
Failure Log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01f0f5a5c206
try to translate elements before load event fires, r=emilio

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/01f0f5a5c206

Comment 14

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 110.0a1 (build id: 20230111043919) using Windows 10. The profile manager window is now opened accordingly.

Comment 15

[Phabricator Automation]

Comment on attachment 9311408 [details]
Bug 1807838 - Simplify AppWindow::SizeShellTo when sizing to the window shell. r=smaug

Revision D166367 was moved to bug 1810614. Setting attachment 9311408 [details] to obsolete.