1808715 - Port bug 1805414: Remove nsMenuFrame

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Martin Giger [:freaktechnik]]

It looks like we have two things to do:

• Make dropmarkers on our menu buttons not have any pointer events, so the popup is shown again
• Update tests to use menu.activateItem(item) instead of directly clicking the menu item

Comment 1

[Martin Giger [:freaktechnik]]

The editable menulist widget is also affected. That one seems extra fun.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

(In reply to Martin Giger [:freaktechnik] from comment #0)

• Update tests to use menu.activateItem(item) instead of directly clicking the menu item

This might not be needed (though it'd be better), given I fixed the weird double command events from XULElement.click()

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1808715 - Port bug 1805414: Click through menu button dropmarkers and fix clicking on menu items in tests. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/50bca3c53bf1
Port bug 1805414: Click through menu button dropmarkers and fix clicking on menu items in tests. r=mkmelin

Comment 5

[Martin Giger [:freaktechnik]]

Looking through the try run and comparing to c-c I think https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=3b868dbf42a035af38866148f52476fcedd0d62f&selectedTaskRun=d69dAuF6RnuAbd3pdcSiGg.0 might also be related to this (I had the same failure in earlier try runs as well), and I can at least get that to fail locally with --verify. However I have no idea what exactly is actually the issue. There is likely some timing issue within the test.

Ah and there's also a failure in comm/mail/test/browser/folder-pane/browser_folderPaneConsumers.js that is likely from this, since it complains about a popup listener not being removed. Only seen it in debug builds in try and is shadowed by that formatting failure.

Comment 6

[Magnus Melin [:mkmelin] (away until Aug 10)]

browser_composeEncrypted.js has been failing a bunch lately yes. Since it's not fresh, I'd think it's not at least directly related. But I don't know what's causing it either.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: image.png

The editable menulists are now unusable on Linux. See the screenshot.

Comment 8

[Martin Giger [:freaktechnik]]

(In reply to Richard Marti (:Paenglab) from comment #7)

Created attachment 9311067 [details]
image.png

The editable menulists are now unusable on Linux. See the screenshot.

Ah that's where they're actually used. My patch just fixed them so the dropmarker was actually clickable in the test. I'll check it out.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Bug 1808715 - Set the width of the datetimepicker menulists on the text-input. r=#thunderbird-front-end-reviewers

Comment 10

[Richard Marti (:Paenglab)]

Attachment: Bug 1808715 - Set the width of the datetimepicker menulists on the text-input. r=#thunderbird-front-end-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e2d927a47f0
Set the width of the datetimepicker menulists on the text-input. r=freaktechnik