1808962 - Date picker doesn't show in Firefox Ubuntu when field low on page

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Will]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

In Ubuntu 22.02 (Wayland) and Firefox 108 (though I believe this issue was introduced in Firefox 106) if the date picker is low on the screen (where there is not enough space below the date field for the picker to display) then it doesn't show at all.

If you go to this page there is a date field with the date (6/1/17) in the box:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date

If you click in the date field input when the date field is higher up the screen then the date picker is launched and you can select a date from it.

If you scroll so that the date picker is near the bottom of the screen and click inside the date field input then the date picker does not display.

Actual results:

The date picker does not display.

Expected results:

The date picker should open above the date field input.

Comment 1

[Monica Chiorean]

I was able to reproduce the issue on Ubuntu 20.04 using Firefox build 108.0.1(20221215175817) and Wayland settings. The date picker is not displayed for given example on description. Mark issue as new.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:emilio, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This seems specific to Wayland. Martin, not sure if you or someone at RedHat have cycles to work on this? It seems WaylandPopupMoveImpl is getting called repeatedly for the popup with the same arguments, probably in a way that should be optimized out.

Comment 4

[Daniel Holbert [:dholbert]]

Maybe also a dupe of bug 1808962? [EDIT: I meant bug 1805208.]

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Wrong bug? Anyways I took a look and have a patch, will post it when back.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

So I don't forget.

Comment 7

[Daniel Holbert [:dholbert]]

Yup sorry -- copypasted this bug. I meant bug 1805208. Updating comment in-place to clarify. :)

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1808962 - Always honor move-to-rect positioning requests. r=stransky

Otherwise we end up in a positioning loop which involves hiding and
showing the popup all the time, which is pretty bad.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de341533273c
Always honor move-to-rect positioning requests. r=stransky

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/de341533273c

Comment 12

[Bogdan Maris, Desktop Test Engineering]

Attachment: Side issue with date picker

I reproduced the issue described in comment 0 using an old Nightly build before the fix, verified that using latest Nightly and Firefox 111.0 RC this is not reproducible anymore, the date picker shows up if the date field is down or up in the page.

I did found a side issue in latest Nightly though and also Nightly 111.0a1 with this fix (Firefox 111.0 RC is unaffected):

1. the date field is positioned down in the page
2. Click the date field

• picker shows

3. Click the date field again

• picker closes and reopens (it should stay closed)

Should I log a new issue or can this be addressed here?

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Let's file a new one, thanks.

Comment 14

[Bogdan Maris, Desktop Test Engineering]

Closing as verified fixed since the date picker is now displayed using latest Nightly 112.0a1 on Ubuntu 22.04.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #13)

Let's file a new one, thanks.

Filed bug 1821618 for the issue described in comment 12.