1809355 - toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml fails on 32 bit windows 11

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

currently we run windows 10x64 OS and test 32 bit and 64 bit builds of Firefox.

I am working on upgrading windows10 -> windows11, so we will be running windows11x64. The goal is to run the same tests, in this case windows 32 bit build of firefox on win11x64.

When I do that, toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml is a perma fail in both opt and debug.

https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=d1433bf8663418bb320b6f2ca60494cfc70e6ad6&searchStr=test-windows10-32%2Cc1&selectedTaskRun=ORMgWQcwQ9mSUUy4CNKwNw.0

[task 2023-01-09T22:48:05.639Z] 22:48:05     INFO - test_copy_existing: Comparison complete
[task 2023-01-09T22:48:05.640Z] 22:48:05     INFO - TEST-PASS | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | MAIN: onmessage {"kind":"info","description":"test_copy_existing 2: Comparing chrome\\toolkit\\components\\osfile\\tests\\mochi\\worker_test_osfile_front.js and test_osfile_front.tmp"} 
[task 2023-01-09T22:48:05.641Z] 22:48:05     INFO - test_copy_existing 2: Comparing chrome\toolkit\components\osfile\tests\mochi\worker_test_osfile_front.js and test_osfile_front.tmp
[task 2023-01-09T22:48:05.641Z] 22:48:05     INFO - TEST-PASS | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | MAIN: onmessage {"kind":"info","description":"Files are open"} 
[task 2023-01-09T22:48:05.642Z] 22:48:05     INFO - Files are open
[task 2023-01-09T22:48:05.642Z] 22:48:05     INFO - TEST-PASS | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | MAIN: onmessage {"kind":"is","outcome":true,"description":"test_copy_existing 2: Both files have the same size","a":"19283","b":"19283"} 
[task 2023-01-09T22:48:05.643Z] 22:48:05     INFO - TEST-PASS | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | test_copy_existing 2: Both files have the same size( 19283 ==? 19283) 
[task 2023-01-09T22:48:05.644Z] 22:48:05     INFO - TEST-PASS | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | MAIN: onmessage {"kind":"info","description":"test_copy_existing 2: Comparison complete"} 
[task 2023-01-09T22:48:05.644Z] 22:48:05     INFO - test_copy_existing 2: Comparison complete
[task 2023-01-09T22:48:05.645Z] 22:48:05     INFO - TEST-PASS | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | MAIN: onmessage {"kind":"ok","condition":false,"description":"test_copy_existing: noOverwrite prevents overwriting existing files"} 
[task 2023-01-09T22:48:05.645Z] 22:48:05     INFO - Buffered messages finished
[task 2023-01-09T22:48:05.646Z] 22:48:05     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | test_copy_existing: noOverwrite prevents overwriting existing files 
[task 2023-01-09T22:48:05.646Z] 22:48:05     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:404:16
[task 2023-01-09T22:48:05.646Z] 22:48:05     INFO - listenForTests/worker.onmessage@chrome://mochikit/content/tests/SimpleTest/WorkerHandler.js:31:20
[task 2023-01-09T22:48:05.647Z] 22:48:05     INFO - TEST-PASS | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | MAIN: onmessage {"kind":"info","description":"test_copy_existing: Cleaning up"} 
[task 2023-01-09T22:48:05.647Z] 22:48:05     INFO - test_copy_existing: Cleaning up
[task 2023-01-09T22:48:05.648Z] 22:48:05     INFO - TEST-PASS | toolkit/components/osfile/tests/mochi/test_osfile_front.xhtml | MAIN: onmessage {"kind":"info","description":"test_position: Starting"} 

this works on 64 bit builds.

I am not sure if this is important to fix the test, OS installation, or product- or if we should just skip this test on 32 bit builds of windows firefox?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:barret, let me know if you have thoughts on this, or help redirect to someone that would.

Comment 2

[Beth Rennie [:beth] (she/her)]

I'm not sure why OS.File.Copy with noOverwrite: true would be misbehaving on 32-bit windows builds, but I have good news: This function is only used in tests, the majority of them being OS.File tests.

All of the non-OS.File tests are slated to be removed soon (see bug 1725615, bug 1773906, bug 1801445). The OS.File tests themselves will be removed when OS.File is removed (also happening soon).

In this case, I think it is OK to skip this test on 32bit Firefox builds.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for the good news. I will disable this test on 32 bit for now. Looking forward to the ^ set of bugs getting resolved soon.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1809355 - Skip test_osfile_front.xhtml on win11/32bit. r=barret!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c48779f222f
Skip test_osfile_front.xhtml on win11/32bit. r=barret

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1c48779f222f