Closed Bug 180995 Opened 22 years ago Closed 22 years ago

nsStatusBarBiffManager::~nsStatusBarBiffManager() unconditionally releases a null member

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows 2000
defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

(Keywords: crash)

Attachments

(1 file)

+ kBiffStateAtom 0x00000000 NS_RELEASE(kBiffStateAtom); nsStatusBarBiffManager::~nsStatusBarBiffManager() line 76 + 6 bytes nsStatusBarBiffManager::`scalar deleting destructor'(unsigned int 1) + 15 bytes nsStatusBarBiffManager::Release(nsStatusBarBiffManager * const 0x03d0aca0) line 64 + 179 bytes nsCOMPtr_base::assign_assuming_AddRef(nsISupports * 0x00000000) line 436 nsCOMPtr_base::assign_with_AddRef(nsISupports * 0x00000000) line 74 nsCOMPtr<nsISupports>::operator=(nsISupports * 0x00000000) line 796 FreeServiceContractIDEntryEnumerate(PLDHashTable * 0x004a676c, PLDHashEntryHdr * 0x010514b4, unsigned int 319, void * 0x00000000) line 1926 PL_DHashTableEnumerate(PLDHashTable * 0x004a676c, int (PLDHashTable *, PLDHashEntryHdr *, unsigned int, void *)* 0x0029b1f0 FreeServiceContractIDEntryEnumerate(PLDHashTable *, PLDHashEntryHdr *, unsigned int, void *), void * 0x00000000) line 603 + 34 bytes nsComponentManagerImpl::FreeServices() line 1938 + 19 bytes NS_ShutdownXPCOM(nsIServiceManager * 0x00000000) line 723 main(int 2, char * * 0x004a4424) line 949 + 8 bytes mainCRTStartup() line 338 + 17 bytes KERNEL32! 77e87903()
*** Bug 180998 has been marked as a duplicate of this bug. ***
Attached patch patchSplinter Review
Attachment #106860 - Flags: superreview?(bzbarsky)
Attachment #106860 - Flags: review?(suresh)
Attachment #106860 - Flags: superreview?(bzbarsky) → superreview+
Blocks: 181491
Blocks: 181494
Blocks: 181496
Blocks: 181498
Blocks: 181500
Blocks: 181503
Blocks: 181505
Blocks: 181507
Blocks: 181509
Blocks: 181512
No longer blocks: 181512
No longer blocks: 181509
No longer blocks: 181507
No longer blocks: 181505
No longer blocks: 181500
No longer blocks: 181498
No longer blocks: 181496
No longer blocks: 181494
No longer blocks: 181503
Attachment #106860 - Flags: review?(suresh) → review?(sspitzer)
Comment on attachment 106860 [details] [diff] [review] patch r=sspitzer, this looks fine. but how are you hitting this? this the factory creates this service and calls Init() from nsMsgFactory.cpp: NS_GENERIC_FACTORY_CONSTRUCTOR_INIT(nsStatusBarBiffManager, Init) is the call to NS_NewAtom() failing, and then we crash at shutdown?
Attachment #106860 - Flags: review?(sspitzer) → review+
version 1.25 was checked in, why is this not marked Resolved Fixed?
because i'm not very organized.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
I don't see any crashes in http://climate (internal Talkback server), but then again, that doesn't mean much, as this was probably a very difficult bug to reproduce. I'm verifying based on running biff for the past week on all platforms, and checking Talkback at: http://climate/reports/VeryFastSearchStackSigNEW.cfm?stacksig=nsStatusBarBiffManager%3A%3A%7EnsStatusBarBiffManager (also, lxr verification)
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Component: MailNews: Notification → MailNews: Message Display
QA Contact: stephend → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: