1810797 - Download panels stay displayed after browser window is minimized

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Gian-Carlo Pascutto [:gcp]]

Kubuntu 22.04, current Nightly, X11 (not Wayland), NVIDIA drivers (This is AFAIK the current default on Kubuntu LTS)

1. Open a Firefox Window.
2. Expand the downloads panel.
3. Minimize

The downloads panel stays visible, obscuring whatever else is on screen now.

This is a recent regression.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

I tested 109.0.0 release, and that does not suffer from this bug: I cannot click the minimize button while the downloads panel is expanded.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Since the status is marked as affected for nightly and as unaffected for release, is it affected or unaffected for beta?
For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #0)

3. Minimize

You're minimizing from the system titlebar? Via keyboard? Something else?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

You're minimizing from the system titlebar? Via keyboard? Something else?

System titlebar.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1798131

Comment 6

[Emilio Cobos Álvarez (:emilio)]

I can repro on KDE/X11, only with system titlebar enabled tho.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1810797 - Disable panel animations on KDE/x11 for now. r=stransky

The main issue here is that we roll up the popup on focus out, and wait
for the transition to finish, but we stop compositing / running the
refresh driver when minimized, and thus the transition never ends up
finishing / the popup doesn't end up being hidden until after you
re-open the window...

This is the easy-to-uplift fix, will work on a proper solution for
central.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b73afeaeb34a
Disable panel animations on KDE/x11 for now. r=stransky

Comment 9

[Pascal Chevrel:pascalc]

Tracking for a potential uplift in beta.

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b73afeaeb34a

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1810797 - Disable panel animations on KDE/x11 for now. r=stransky

The main issue here is that we roll up the popup on focus out, and wait
for the transition to finish, but we stop compositing / running the
refresh driver when minimized, and thus the transition never ends up
finishing / the popup doesn't end up being hidden until after you
re-open the window...

This is the easy-to-uplift fix, will work on a proper solution for
central.

Original Revision: https://phabricator.services.mozilla.com/D167379

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9314001 [details]
Bug 1810797 - Disable panel animations on KDE/x11 for now. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: If they have kde testing comment 0 would be great.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Really low risk fix to disable panel animations on KDE, which can cause issues due to the order of the X server events.
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9314001 [details]
Bug 1810797 - Disable panel animations on KDE/x11 for now. r=stransky

Will try to do it the phab way.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9314001 [details]
Bug 1810797 - Disable panel animations on KDE/x11 for now. r=stransky

Ok that didn't quite work out.

Comment 15

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/d18aae3dcdfadee75298b0add9f178152b4386c2

Comment 16

[Bogdan Maris, Desktop Test Engineering]

Attachment: Shadow download panel Nightly 20230126212606

I reproduced the initial issue using an affected Nightly build from 2023-01-23 on a Kubuntu 22.04 VM,
It seems that using latest Nightly this is not totally fixed, there is a small shadow of the panel left for 1-2 seconds and then it disappears. I downloaded a few builds and ended up with a regression for this: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2ac913a38e4cd0c49ceabd0bbd21dd862908f3fb&tochange=45cd9ed42ad7f9e8f3b477c99142ec710aa43a09

From a quick look it looks that Bug 1811486 could have caused this.

The good thing is that the latest Beta 110.0b6 is not affected yet and the panel correctly closes when Firefox is minimized.

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Can you file a separate bug for that? Thanks!

Comment 18

[Bogdan Maris, Desktop Test Engineering]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #17)

Can you file a separate bug for that? Thanks!

I logged bug 1813070 and added a needinfo request for you there so you can track it. In the meantime I'm going to close this one as verified fixed since the panel is now minimized.