181235 - Illegal "nickname" for review feature

Status: VERIFIED DUPLICATE of bug 179622

(Bugzilla :: Attachments & Requests, defect)

Description

[Ben Bucksch (:BenB)]

If I request or grant a review of an attachment, Bugzilla uses a "nick" to
ídentify the involved persons. Unfortunately, it generates the nick by just
using the local part ofo the email address.

This is totally broken. The local part of an email address alone is not
significant. My other bugzilla ID is [e-mail], so it would show just
"mozilla". Lots of people now have bugzilla@theirdomain or mozillla@theirdomain
accounts in bugzilla, you should have seen them.

In the case of the person asked to review. I can at least Edit the attachment to
see the full address. I can't for the person requesting or granting the review.

Compare bug 34122 and bug 34119.

Comment 1

[Ben Bucksch (:BenB)]

I created bug 181244 (alias dummy) for testing. I know, the bugzilla people have
their testing instance of bugzilla, but not everybody has an account there.

Comment 2

[Bradley Baetz (:bbaetz)]

You can look at the activity log for who asked you.

This is mainly a space thing - theres only so wide the columns can look before
they get to be a pain.

Would a tooltip for the 'real' email work for you?

Comment 3

[Ben Bucksch (:BenB)]

(Thinking about it, this is probably a minor bug. I just went "ARG, not AGAIN!
*headbang*" when I saw it. ;-) )

> You can look at the activity log for who asked you.

Not really, it doesn't tell what has been changed, just that that the flags
changed. (Nor can I see in the Attachment edit page when the review has been
requested.)

> This is mainly a space thing - theres only so wide the columns can look
> before they get to be a pain.

Just move the attachment content *below* the fields, and you have plenty of
space and also more space for commenting/viewing the patch.

> Would a tooltip for the 'real' email work for you?

I guess, but that's a hack.

(Tt's not a matter of working for me, BTW. My main account is
<[e-mail]> nowadays, I rarely use <[e-mail]>. I merely
reported a bug.)


Why not just use a field in the account prefs?

I think that the full name would be acceptable in length, but you may disagree.
(The real name field is currently abused for status messages like vacation, but
that could be solved with yet another field.)

If the real name is considered too long, then maybe add a field for the nickname
(maybe default it to the local part of the user's email address, maybe not). You
should enforce uniqueness, though.

Comment 4

[Ben Bucksch (:BenB)]

> (The real name field is currently abused for status messages like vacation, but
> that could be solved with yet another field.)

Filed bug 181255.

Comment 5

[Frédéric Buclin]

*** This bug has been marked as a duplicate of 179622 ***