Closed Bug 1812982 Opened 3 years ago Closed 2 years ago

SW WR: Crash on youtube while scrolling with picture-in-picture

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Version:
Firefox 100
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- wontfix
firefox111 --- wontfix
firefox112 --- wontfix
firefox114 --- wontfix
firefox115 --- verified
firefox116 --- verified

People

(Reporter: mr.felixoid, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(10 files, 4 obsolete files)

crush-report.txt
15.28 KB, text/plain
Details
screencast of the crash
5.97 MB, video/x-matroska
Details
about:support
63.95 KB, text/plain
Details
Firefox PIP + YT PIP
1.41 MB, image/png
Details
crash log
580.57 KB, text/x-log
Details
fix.diff
3.78 KB, patch
Details | Diff | Splinter Review
gdb.log
1.04 MB, text/x-log
Details
lldb.log
753.30 KB, text/x-log
Details
Crash report file
9.88 KB, text/plain
Details
Bug 1812982 - Track composite surfaces independently of frame_surfaces. r?aosmond
48 bytes, text/x-phabricator-request
dmeehan
: approval-mozilla-beta+
Details | Review
Attached file crush-report.txt —

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0

Steps to reproduce:

Open any page, e.g. https://www.youtube.com/watch?v=5S2J6ZAhefM, toggle the picture-in-picture, then scroll down-up a little bit. After a couple of moves, the browser crashes.

Actual results:

The browser crashed, and a crash report was produced.

Expected results:

The browser should work.

I've tried to disable all add-ons and restarted the browser after that. Crush still occurs.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Video/Audio Controls' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Video/Audio Controls
Product: Firefox → Toolkit
Component: Video/Audio Controls → Crash Reporting
OS: Unspecified → Linux
Hardware: Unspecified → x86_64

109.0.1 is affected

The severity field is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(gsvelto)

Moving this to the right component. It would be useful if you could provide a link to the crash report (if you submitted it). You can find it by browsing to the about:crashes page, the list of crashes that happened on your machine will appear there. Please post the link to the last crash on this bug.

Component: Crash Reporting → Picture-in-Picture
Flags: needinfo?(gsvelto) → needinfo?(mr.felixoid)

Sure, here's the freshest one https://crash-stats.mozilla.org/report/index/8ad69cc9-ccbb-4a83-a920-b68720230217

Flags: needinfo?(mr.felixoid)

Confirming the crash, this is an issue in the graphics stack. Here's the stack:

MOZ_CRASH Reason: Redirecting call to abort() to mozalloc_abort

Top 10 frames of crashing thread:

0  firefox  MOZ_Crash  /build/firefox/src/firefox-110.0/mfbt/Assertions.h:261
0  firefox  mozalloc_abort  /build/firefox/src/firefox-110.0/memory/mozalloc/mozalloc_abort.cpp:35
1  firefox  abort  /build/firefox/src/firefox-110.0/memory/mozalloc/mozalloc_abort.cpp:88
2  libstdc++.so.6  std::__glibcxx_assert_fail  /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/debug.cc:60
3  libxul.so  mozilla::wr::RenderTextureHostSWGL::LockSWGLCompositeSurface  /build/firefox/src/firefox-110.0/gfx/webrender_bindings/RenderTextureHostSWGL.cpp
4  libxul.so  wr_swgl_lock_composite_surface  /build/firefox/src/firefox-110.0/gfx/webrender_bindings/RenderTextureHostSWGL.cpp:215
5  libxul.so  webrender::compositor::sw_compositor::SwCompositor::try_lock_composite_surface  /build/firefox/src/firefox-110.0/gfx/wr/webrender/src/compositor/sw_compositor.rs:1034
5  libxul.so  <webrender::compositor::sw_compositor::SwCompositor as webrender::composite::Compositor>::add_surface  /build/firefox/src/firefox-110.0/gfx/wr/webrender/src/compositor/sw_compositor.rs:1389
6  libxul.so  webrender::renderer::<impl webrender::composite::CompositeState>::composite_native  /build/firefox/src/firefox-110.0/gfx/wr/webrender/src/renderer/mod.rs:5710
6  libxul.so  webrender::renderer::Renderer::draw_frame  /build/firefox/src/firefox-110.0/gfx/wr/webrender/src/renderer/mod.rs:4309

Version 110 is definitely affected but we don't have crashes on file for version 111 and 112. There are several comments pointing out that this happens either when scrolling on YouTube with PiP or when dragging a tab between windows. Some potentially useful comments:

If you start a video (specifically YouTube), and put pictutre in picture (popout video), and scroll down to the comments on a YouTube video, it crashes, everytime. This is on Arch Linux, stock drivers (amdgpu), amd ryzen + radeon 6900xt, Linux Kernel 6.1.11-arch1-1. I have had this happen on all distros of Linux, so should be easily reproducable. Thanks for Firefox!!

Seems to keep crashing after Youtube PiP is open on a seperate monitor for an unfocused tab.

Dragged a tab from one window to another using i3wm.

lol so I popped my youtube window out to the right of the screen, moved a 2nd window to the bottom & then put the song list from the popped out youtube window to the left. as soon as the playing video sees its own songlist it crashes. (repeated the same process 4 times & crashes every time) Think its to do with the popped out video playing & youtubes track list.

One interesting thing to note is that several comments mention dual monitors and several others the use of the i3wm window manager. They might not be directly related to the crash but might increase the chances of it happening.

Status: UNCONFIRMED → NEW
Crash Signature: [@ mozalloc_abort | abort | mozilla::wr::RenderTextureHostSWGL::LockSWGLCompositeSurface] [@ mozalloc_abort | abort | libstdc++.so.6.0.30 (deleted)@0xd30a1]
status-firefox110: --- → affected
status-firefox111: --- → ?
status-firefox112: --- → ?
Component: Picture-in-Picture → Graphics: WebRender
Ever confirmed: true
Product: Toolkit → Core
Version: Firefox 109 → Firefox 100

Even with a disconnected second monitor, it still happens to me just by popping out a video and scrolling the comments

Hello, I am also having the same issue. When PiP is enabled, and I scroll on youtube, the whole browser crashes.
Here is the crash report: https://crash-stats.mozilla.org/report/index/a3418934-64d0-4530-9130-022710230226

The severity field is not set for this bug.
:gw, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(gwatson)

Lee, any ideas what is happening here?

Severity: -- → S2
Flags: needinfo?(gwatson) → needinfo?(lsalzman)
Flags: needinfo?(lsalzman) → needinfo?(sotaro.ikeda.g)

(In reply to Gabriele Svelto [:gsvelto] from comment #7)

Version 110 is definitely affected but we don't have crashes on file for version 111 and 112. There are several comments pointing out that this happens either when scrolling on YouTube with PiP or when dragging a tab between windows. Some potentially useful comments:

Tab move related crash is addressed by Bug 1769404.

See Also: → 1769404

Felixoid, when firefox is started from terminal and the crash of comment 1 happens, is there a log out like "Unhandled external image format:" in the terminal?

https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/gfx/webrender_bindings/RenderTextureHostSWGL.cpp#196

Flags: needinfo?(mr.felixoid)
$ firefox
ATTENTION: default value of option mesa_glthread overridden by environment.
[GFX1-]: Unrecognized feature ACCELERATED_CANVAS2D
ATTENTION: default value of option mesa_glthread overridden by environment.
ATTENTION: default value of option mesa_glthread overridden by environment.
[2023-03-06T14:15:20Z ERROR mp4parse] Found 2 nul bytes in "\0\0"
[2023-03-06T14:15:20Z ERROR mp4parse] Found 2 nul bytes in "\0\0"
[2023-03-06T14:15:20Z ERROR mp4parse] Found 2 nul bytes in "\0\0"
[2023-03-06T14:15:20Z ERROR mp4parse] Found 2 nul bytes in "\0\0"
[2023-03-06T14:15:31Z ERROR mp4parse] Found 2 nul bytes in "\0\0"
[2023-03-06T14:15:31Z ERROR mp4parse] Found 2 nul bytes in "\0\0"
[2023-03-06T14:15:31Z ERROR mp4parse] Found 2 nul bytes in "\0\0"
[2023-03-06T14:15:31Z ERROR mp4parse] Found 2 nul bytes in "\0\0"
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/stl_vector.h:1123: std::vector::reference std::vector<mozilla::wr::RenderTextureHostSWGL::PlaneInfo>::operator[](std::vector::size_type) [_Tp = mozilla::wr::RenderTextureHostSWGL::PlaneInfo, _Alloc = std::allocator<mozilla::wr::RenderTextureHostSWGL::PlaneInfo>]: Assertion '__n < this->size()' failed.
Redirecting call to abort() to mozalloc_abort

ExceptionHandler::GenerateDump cloned child 1292517
ExceptionHandler::WaitForContinueSignal waiting for continue signal...
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.

Here's the full output

Flags: needinfo?(mr.felixoid)

Assertion '__n < this->size()' failed.
Redirecting call to abort() to mozalloc_abort

The above error seemed to cause abort. I wonder if GetPlaneCount() was 0. The following code might cause the problem.

https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/gfx/webrender_bindings/RenderTextureHostSWGL.cpp#200

Maybe, unless I scroll the page below the video frame, everything works.

The process crashes at the same moment when video is gone.

When video decoding happens in RDD process, RenderTextureHostWrapper wraps actual RenderTextureHost. And if the RenderTextureHost does not support RenderTextureHostSWGL, RenderTextureHostWrapper::GetPlaneCount() returns 0.

And RenderDMABUFTextureHost, RenderEGLImageTextureHost seemed not support RenderTextureHostSWGL.

Then RenderDMABUFTextureHost might be related.

But I do not know well about RenderTextureHostSWGL.

:lsalzman, is there a such possibility?

Flags: needinfo?(sotaro.ikeda.g) → needinfo?(lsalzman)

Martin, as Sotaro suggests, this might be an issue with DMABufSurfaces being used for video frames, sent to SW-WR, and then because RenderDMABUFTextureHost does not implement the RenderTextureHostSWGL API, things go boom...

Would it make sense to support mapping things into memory when SW-WR needs to read them, or would we be better off not using DMABuf stuff for video in that circumstance in the first place?

Flags: needinfo?(lsalzman) → needinfo?(stransky)

Lee, I'll look at it. We already support mapping dmabuf to memory by GetAsSourceSurface() and that was used for WebGL textures before Bug 1809026. But I think the best solution may be to enable WebRender for popups so we can render video directly to popups.

Felixoid, can you please create a screencast of the issuse? I can't reproduce it on my side.
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Collect_information_for_a_bug_report

Also please attach content of about:support page.
Thanks.

Blocks: egl-linux-vaapi
Flags: needinfo?(stransky) → needinfo?(mr.felixoid)
Summary: Crash on youtube while scrolling with picture-in-picture → [VA-API] Crash on youtube while scrolling with picture-in-picture

(In reply to Martin Stránský [:stransky] (ni? me) from comment #19)

Lee, I'll look at it. We already support mapping dmabuf to memory by GetAsSourceSurface() and that was used for WebGL textures before Bug 1809026. But I think the best solution may be to enable WebRender for popups so we can render video directly to popups.

Felixoid, can you please create a screencast of the issuse? I can't reproduce it on my side.
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Collect_information_for_a_bug_report

Also please attach content of about:support page.
Thanks.

If you look at the crash reports, it seems to require at least SW-WR. They also mostly seem to have the message "[0][GFX1-]: glxtest: VA-API test failed: failed to initialise VAAPI connection." which seems suspicious?

If you look at the crash reports, it seems to require at least SW-WR. They also mostly seem to have the message "[0][GFX1-]: glxtest: VA-API test failed: failed to initialise VAAPI connection." which seems suspicious?

Yes, so I need the about:support page to check that.

Attached video screencast of the crash —
Flags: needinfo?(mr.felixoid)
Attached file about:support —
```

Hm, I see browser is run with WebRender (Software) and HARDWARE_VIDEO_DECODING is disabled.

"[0][GFX1-]: glxtest: VA-API test failed: failed to initialise VAAPI connection" message is a red herring here and comes from glxtest process. Unfortunately we test va-api even on unsupported configs, that's addressed by Bug 1787182.

Felixoid, can you provide log from the video playback? Run on terminal with

MOZ_LOG="PlatformDecoderModule:5"

env variable, crash it and attach the log here.
Thanks.

Flags: needinfo?(mr.felixoid)
Attached image Firefox PIP + YT PIP —

I think we see the crash when YT opens another PIP window. But it's works for me with WR SW.

Felixoid, please run with MOZ_LOG="PlatformDecoderModule:5 Widget:5 WidgetPopup:5" to get better picture how the windows are opened.
Thanks.

btw. May that be a scenario when RenderTextureHostSWGL::LockSWGLCompositeSurface() is called after RenderTextureHostSWGL::CleanupPlanes()?
May we add some assertions there?

(In reply to Martin Stránský [:stransky] (ni? me) from comment #28)

btw. May that be a scenario when RenderTextureHostSWGL::LockSWGLCompositeSurface() is called after RenderTextureHostSWGL::CleanupPlanes()?
May we add some assertions there?

The only way I could see that situation happening is if mLocked==true already with some other context, SetContext is called from there with a different context, then UpdatePlanes is skipped. So the same RenderTextureHostSWGL would be having to get used multiple times by different windows, simultaneously, for this to occur? But that seems unlikely because the separate windows should be processed one at a time by the same Renderer thread, so the simultaneous part shouldn't be possible?

@Felixoid, @keystroke33, please check if you can reproduce the crash with Mozilla-built binaries as well:
$ pip3 install mozregression
$ ~/.local/bin/mozregression --launch 109.0.1 -a https://www.youtube.com
or
$ ~/.local/bin/mozregression --launch 110 -a https://www.youtube.com

If you have been able to reproduce the crash, please try to find a regression range (you will get a pushlog url at the end):
$ MOZ_DISABLE_CONTENT_SANDBOX=1 ~/.local/bin/mozregression --good 2022-01-01 --bad 110 -a https://www.youtube.com

(Felixoid from comment #6)

Sure, here's the freshest one https://crash-stats.mozilla.org/report/index/8ad69cc9-ccbb-4a83-a920-b68720230217

  • 109

(keystroke33 from comment #9)

Here is the crash report: https://crash-stats.mozilla.org/report/index/a3418934-64d0-4530-9130-022710230226

Both

Summary: [VA-API] Crash on youtube while scrolling with picture-in-picture → SW WR: Crash on youtube while scrolling with picture-in-picture
Attached file crash log —

Here's a log with MOZ_LOG="PlatformDecoderModule:5 Widget:5 WidgetPopup:5" for :stransky

Flags: needinfo?(mr.felixoid)

(In reply to Darkspirit from comment #30)

@Felixoid, @keystroke33, please check if you can reproduce the crash with Mozilla-built binaries as well:
$ pip3 install mozregression
$ ~/.local/bin/mozregression --launch 109.0.1 -a https://www.youtube.com
or
$ ~/.local/bin/mozregression --launch 110 -a https://www.youtube.com

I've tried it, and both version work just fine

Flags: needinfo?(stransky)

(In reply to Felixoid from comment #32)

(In reply to Darkspirit from comment #30)

@Felixoid, @keystroke33, please check if you can reproduce the crash with Mozilla-built binaries as well:
$ pip3 install mozregression
$ ~/.local/bin/mozregression --launch 109.0.1 -a https://www.youtube.com
or
$ ~/.local/bin/mozregression --launch 110 -a https://www.youtube.com

I've tried it, and both version work just fine

Hm, that may means the bug occurs in package shipped by ArcLinux.

Felixoid, can you try plain Mozilla binaries with clean profile?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_binaries
Thanks.

Flags: needinfo?(stransky) → needinfo?(mr.felixoid)

Yes, the given binary from https://download-installer.cdn.mozilla.net/pub/firefox/releases/111.0.1/linux-x86_64/en-US/firefox-111.0.1.tar.bz2 works without crashing

Flags: needinfo?(mr.felixoid)

(In reply to Felixoid from comment #34)

Yes, the given binary from https://download-installer.cdn.mozilla.net/pub/firefox/releases/111.0.1/linux-x86_64/en-US/firefox-111.0.1.tar.bz2 works without crashing

So looks like it's a problem with archlinux downstream package so please report it there.

Thanks, have done it a second ago https://bugs.archlinux.org/task/78017

The reason this crashes for the Arch Linux build is that stdlib assertions are enabled (CXXFLAGS includes -Wp,-D_GLIBCXX_ASSERTIONS). I'd rather not paper over this by disabling them again downstream.

Jan, so you say the crash is here?
https://searchfox.org/mozilla-central/rev/42747dfd314e4c939dc7c33a13e1a2fddf4926fc/gfx/webrender_bindings/RenderTextureHostSWGL.cpp#176

i.e. MOZ_ASSERT(mPlanes.size() <= 3); ?

Flags: needinfo?(jan.steffens)
Flags: needinfo?(stransky)

Not a MOZ_ASSERT. From the log above:

/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/stl_vector.h:1123:
  std::vector::reference
  std::vector<mozilla::wr::RenderTextureHostSWGL::PlaneInfo>::operator[](std::vector::size_type) [
    _Tp = mozilla::wr::RenderTextureHostSWGL::PlaneInfo,
    _Alloc = std::allocator<mozilla::wr::RenderTextureHostSWGL::PlaneInfo>
  ]: Assertion '__n < this->size()' failed.

This is an out-of-bounds access on a std::vector with item type mozilla::wr::RenderTextureHostSWGL::PlaneInfo.

PS: My guess is either the mPlanes vector is being mutated concurrently and it asserts on line 178, or the vector has size 0 and it asserts on line 200.

Flags: needinfo?(jan.steffens)
Assignee: nobody → stransky
Status: NEW → ASSIGNED
Flags: needinfo?(stransky)

Jan, do you mind to ship D173946 as a downstream patch to test that?
Thanks.

Flags: needinfo?(jan.steffens)
Attached patch fix.diff — — Splinter Review

I've applied the given diff to https://github.com/archlinux/svntogit-packages/tree/packages/firefox/trunk and built it. The result is the same, FF has crushed. The crush report is coming next

Maybe LockSWGL or LockSWGLCompositeSurface is getting called with a different context while it's already locked? Then mPlanes would get cleared (through SetContext > CleanupPlanes) and be left empty since UpdatePlanes gets skipped.

PS: Try adding a MOZ_ASSERT(!mLocked) to CleanupPlanes, if that makes sense.

(In reply to Felixoid from comment #43)

Created attachment 9325723 [details] [diff] [review]
fix.diff

I've applied the given diff to https://github.com/archlinux/svntogit-packages/tree/packages/firefox/trunk and built it. The result is the same, FF has crushed. The crush report is coming next

Felixoid,

Can you try to run it under gdb?
https://fedoraproject.org/wiki/Debugging_guidelines_for_Mozilla_products#Running_application_in_debugger
and investigate where it crashes?

We can't get backtrace from crashstats as the build symbols are not uploaded at https://crash-stats.mozilla.org

Thanks.

Flags: needinfo?(mr.felixoid)

(In reply to Jan Alexander Steffens [:heftig] from comment #45)

Maybe LockSWGL or LockSWGLCompositeSurface is getting called with a different context while it's already locked? Then mPlanes would get cleared (through SetContext > CleanupPlanes) and be left empty since UpdatePlanes gets skipped.

PS: Try adding a MOZ_ASSERT(!mLocked) to CleanupPlanes, if that makes sense.

MOZ_ASSERT() doesn't trigger in non-debug builds so it's a bit useless here. We'd need MOZ_RELEASE_ASSERT() or MOZ_DIAGNOSTIC_ASSERT().

Flags: needinfo?(stransky)
Flags: needinfo?(stransky)
Attached file gdb.txt (obsolete) —

Sorry for the short absence, here are the backtraces for the crash.

Flags: needinfo?(mr.felixoid)

(In reply to Felixoid from comment #49)

Created attachment 9326846 [details]
gdb.txt

Sorry for the short absence, here are the backtraces for the crash.

Unfortunately that's missing debug symbols so we can't investigate it. Lets check the assertion when the patches here lands.

Flags: needinfo?(stransky)
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/cbabe2085460 [SW WR] Make RenderTextureHostSWGL::UpdatePlanes() fail if plane count is zero r=lsalzman https://hg.mozilla.org/integration/autoland/rev/3cfbad09a56a [SW WR] Assert if we clear locked planes r=lsalzman

Backed out for causing bc failures on RenderTextureHostSWGL.cpp

Backout link

Push with failures

Failure log

Lee, so looks like we hit the case CleanupPlanes() call on locked host in our testsuite.

Flags: needinfo?(stransky) → needinfo?(lsalzman)
Attached file gdb.log —

I've built the binary again from https://bugzilla.mozilla.org/show_bug.cgi?id=1812982#c43 and launched it without striped symbols.

The gdb exited with an error, here's the last thread before the crush:

Thread 166 (Thread 0x7fffcabfd6c0 (LWP 2158736) "threaded-ml"):
#0  0x00007ffff7b139df in poll () at /usr/lib/libc.so.6
#1  0x00007fffd419a8c7 in  () at /usr/lib/libpulse.so.0
#2  0x00007fffd418446c in pa_mainloop_poll () at /usr/lib/libpulse.so.0
#3  0x00007fffd418e42c in pa_mainloop_iterate () at /usr/lib/libpulse.so.0
#4  0x00007fffd418e4e1 in pa_mainloop_run () at /usr/lib/libpulse.so.0
#5  0x00007fffd419ec02 in  () at /usr/lib/libpulse.so.0
#6  0x00007fffd3dd3c67 in  () at /usr/lib/pulseaudio/libpulsecommon-16.1.so
#7  0x00005555555b16c0 in set_alt_signal_stack_and_start(PthreadCreateParams*) (params=<optimized out>) at /usr/src/debug/firefox/firefox-111.0.1/toolkit/crashreporter/pthread_create_interposer/pthread_create_interposer.cpp:80
        __cancel_buf = {__cancel_jmp_buf = {{__cancel_jmp_buf = {140736747024384, -1794169217015264918, -184, 140736747879440, 140736669211088, 16384, 1794193957576329578, 5598957490496948586}, __mask_was_saved = 0}}, __pad = {0x7fffcabfceb0, 0x0, 0x0, 0x0}}
        __cancel_arg = 0x7fffcabfcdd0
        __not_first_call = <optimized out>
        kSigStackSize = 16384
        alt_stack = {mem = 0x7fffd3d03000, size = 16384}
        start_routine = 0x7fffd3dd3c10
        arg = 0x7fffcf2cd9d0
        thread_rv = 0x0
        alt_stack_mem = 0x7fffd3d03000
#8  0x00007ffff7a9ebb5 in  () at /usr/lib/libc.so.6
#9  0x00007ffff7b20d90 in  () at /usr/lib/libc.so.6
Recursive internal problem.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.

I hope it's helpful

Attachment #9326846 - Attachment is obsolete: true
Attached file lldb.log —

Just in case, another session in lldb debugger

Flags: needinfo?(stransky)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:stransky, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(stransky)
Flags: needinfo?(lsalzman)
Flags: needinfo?(stransky)
Attached file Crash report file —
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/9c11387675b1 [SW WR] Make RenderTextureHostSWGL::UpdatePlanes() fail if plane count is zero r=lsalzman https://hg.mozilla.org/integration/autoland/rev/c53591077218 [SW WR] Assert if we clear locked planes r=lsalzman

Backed out for causing bc crash in RenderTextureHostSWGL.cpp.

[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_backgroundTab.js | Got Picture-in-Picture window. - 
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - Buffered messages finished
[task 2023-05-18T18:43:22.495Z] 18:43:22    ERROR - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_backgroundTab.js | application terminated with exit code 1
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - runtests.py | Application ran for: 0:00:15.033203
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - zombiecheck | Reading PID log: C:\Users\task_168443351155830\AppData\Local\Temp\tmpnjwp3yzspidlog
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 5168 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.0.1694873619\2135202843" -childID 1 -isForBrowser -prefsHandle 1924 -prefMapHandle 1916 -prefsLen 21181 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {e105352b-aa89-4ec5-8034-fc77af2e781c} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 1988 12f02e00 tab)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 4444 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.1.667296054\10456898" -childID 2 -isForBrowser -prefsHandle 2468 -prefMapHandle 2464 -prefsLen 22772 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {3c53ff0f-d108-45e1-992b-26fa766edad5} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 2480 12f02f70 tab)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 3276 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.2.1188474783\1525082496" -childID 3 -isForBrowser -prefsHandle 2388 -prefMapHandle 2364 -prefsLen 22457 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {50a7fc60-dbae-454d-b84b-5e1f3fe00581} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 2652 20f819b0 tab)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 4348 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.3.468240808\939398889" -parentBuildID 20230518144430 -prefsHandle 2920 -prefMapHandle 2916 -prefsLen 25041 -prefMapSize 252871 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {8b58ec42-21fb-4630-b9db-3257001816fa} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 2932 230ec9e0 rdd)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 4680 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.4.1665988818\1029091618" -parentBuildID 20230518144430 -sandboxingKind 0 -prefsHandle 3300 -prefMapHandle 3296 -prefsLen 31079 -prefMapSize 252871 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {65263507-1204-4a56-be1d-4f668247ea8c} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 3316 14120c30 utility)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 2500 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.5.759259628\1422393989" -childID 4 -isForBrowser -prefsHandle 3420 -prefMapHandle 3416 -prefsLen 28351 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {8783b80c-3efb-4e1c-867b-e30b092ed162} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 3412 22f09e00 tab)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 4548 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.6.2086795890\1558900053" -childID 5 -isForBrowser -prefsHandle 3512 -prefMapHandle 3516 -prefsLen 28351 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {f245a88f-e7bc-43f0-abf1-4102b13155cc} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 3504 2bdb9840 tab)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 4584 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.7.616118895\917017955" -childID 6 -isForBrowser -prefsHandle 3696 -prefMapHandle 3632 -prefsLen 28351 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {42a6f4ed-2760-42c6-a2be-9c2871b553c6} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 3600 2bdb9110 tab)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 4708 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.8.801528616\933499486" -childID 7 -isForBrowser -prefsHandle 3760 -prefMapHandle 3756 -prefsLen 31079 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {7794e18d-31eb-4685-a3af-8e968502b457} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 3752 2bdb96d0 tab)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 2976 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.9.545001794\2085851039" -childID 8 -isForBrowser -prefsHandle 4336 -prefMapHandle 4332 -prefsLen 28509 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {77e35f33-943f-41cc-8185-d9df37506050} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 4368 34d683f0 tab)
[task 2023-05-18T18:43:22.495Z] 18:43:22     INFO - ==> process 4752 launched child process 5592 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.10.681028687\762216465" -childID 9 -isForBrowser -prefsHandle 4352 -prefMapHandle 4348 -prefsLen 28509 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {c626f820-a149-4390-941f-a8bc41c42c3b} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 4384 34d68560 tab)
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - ==> process 4752 launched child process 2376 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.11.590992760\1410958453" -childID 10 -isForBrowser -prefsHandle 3944 -prefMapHandle 4104 -prefsLen 28666 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {cefe5bd1-ffe6-4194-9616-3bedca4d8c46} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 3736 12f023f0 tab)
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - ==> process 4752 launched child process 656 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.12.1880988276\2016921107" -childID 11 -isForBrowser -prefsHandle 4560 -prefMapHandle 4564 -prefsLen 28831 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {18bd7447-3d14-4ebf-bfb5-816f4e1f020a} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 3628 12f02560 tab)
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - ==> process 4752 launched child process 4200 ("C:\Users\task_168443351155830\build\application\firefox\firefox.exe" -contentproc --channel="4752.13.951112164\1196626822" -childID 12 -isForBrowser -prefsHandle 3316 -prefMapHandle 3964 -prefsLen 28831 -prefMapSize 252871 -jsInitHandle 856 -jsInitLen 243676 -parentBuildID 20230518144430 -appDir "C:\Users\task_168443351155830\build\application\firefox\browser" - {94c6789e-16fe-417a-ba44-9022ff7b286a} 4752 "\\.\pipe\gecko-crash-server-pipe.4752" 3884 12f02b20 tab)
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 2976
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 2500
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 4548
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 4708
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 4680
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 4584
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 2376
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 4200
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 3276
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 5168
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 656
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 4444
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 5592
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - zombiecheck | Checking for orphan process with PID: 4348
[task 2023-05-18T18:43:22.511Z] 18:43:22     INFO - mozcrash Downloading symbols from: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IfSeea80QlO6wYpQtmLXwg/artifacts/public/build/target.crashreporter-symbols.zip
[task 2023-05-18T18:43:55.542Z] 18:43:55     INFO - mozcrash Copy/paste: C:/Users/task_168443351155830/fetches\minidump-stackwalk\minidump-stackwalk.exe --symbols-url=https://symbols.mozilla.org/ --cyborg=C:\Users\task_168443351155830\AppData\Local\Temp\tmpc08iwn76\1f27cebd-3545-4113-a917-a27fe7ff1bc1.trace C:\Users\task_168443351155830\AppData\Local\Temp\tmpko64bc8z.mozrunner\minidumps\1f27cebd-3545-4113-a917-a27fe7ff1bc1.dmp C:\Users\task_168443351155830\AppData\Local\Temp\tmpgwx80ps1
[task 2023-05-18T18:44:05.893Z] 18:44:05     INFO - mozcrash Saved minidump as C:\Users\task_168443351155830\build\blobber_upload_dir\1f27cebd-3545-4113-a917-a27fe7ff1bc1.dmp
[task 2023-05-18T18:44:05.893Z] 18:44:05     INFO - mozcrash Saved app info as C:\Users\task_168443351155830\build\blobber_upload_dir\1f27cebd-3545-4113-a917-a27fe7ff1bc1.extra
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - PROCESS-CRASH | toolkit/components/pictureinpicture/tests/browser_backgroundTab.js | application crashed [@ mozilla::wr::RenderTextureHostSWGL::LockSWGLCompositeSurface]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - Mozilla crash reason: MOZ_RELEASE_ASSERT(mPlanes.size() > 0)
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - Crash dump filename: C:\Users\task_168443351155830\AppData\Local\Temp\tmpko64bc8z.mozrunner\minidumps\1f27cebd-3545-4113-a917-a27fe7ff1bc1.dmp
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - Operating system: Windows NT
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -                   6.1.7601 Service Pack 1
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - CPU: x86
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      GenuineIntel family 6 model 85 stepping 7
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      4 CPUs
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - Crash reason:  EXCEPTION_BREAKPOINT
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - Crash address: 0x56c99b7a
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - Process uptime: 15 seconds
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - Thread 33  (crashed)
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  0  xul.dll!mozilla::wr::RenderTextureHostSWGL::LockSWGLCompositeSurface(void*, mozilla::wr::SWGLCompositeSurfaceInfo*) [RenderTextureHostSWGL.cpp:c535910772183974873a1b13ce36901d12348b26 : 206 + 0x0]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56c99b7a    esp = 0x104ee3a8    ebp = 0x104ee480    ebx = 0x104ee500
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x2c34f920    edi = 0x56c8f560    eax = 0x69fee9ac    ecx = 0x00000000
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      edx = 0x00000001 eflags = 0x00000246
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: given as instruction pointer in context
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  1  xul.dll!wr_swgl_lock_composite_surface(void*, mozilla::wr::ExternalImageId, mozilla::wr::SWGLCompositeSurfaceInfo*) [RenderTextureHostSWGL.cpp:c535910772183974873a1b13ce36901d12348b26 : 222 + 0xc]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56c99c3c    esp = 0x104ee488    ebp = 0x104ee4b0    ebx = 0x210d2198
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x21398580    edi = 0x56c9a410
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  2  xul.dll!webrender_bindings::bindings::impl$22::lock_composite_surface(webrender_bindings::bindings::WrCompositor*, webrender::device::gl::Device*, core::ffi::c_void*, webrender_api::image::ExternalImageId, webrender::composite::SWGLCompositeSurfaceInfo*) [bindings.rs:c535910772183974873a1b13ce36901d12348b26 : 1488 + 0x21]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x5a9d7ec4    esp = 0x104ee4b8    ebp = 0x104ee4d4    ebx = 0x210d2198
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x0f3c80e0    edi = 0x21211e00
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  3  xul.dll!webrender::compositor::sw_compositor::SwCompositor::try_lock_composite_surface(webrender::device::gl::Device*, webrender::composite::NativeSurfaceId*) [sw_compositor.rs:c535910772183974873a1b13ce36901d12348b26 : 1037]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  4  xul.dll!webrender::compositor::sw_compositor::impl$13::add_surface(webrender::compositor::sw_compositor::SwCompositor*, webrender::device::gl::Device*, webrender::composite::NativeSurfaceId, webrender::util::ScaleOffset, euclid::box2d::Box2D<i32,webrender_api::units::DevicePixel>, webrender_api::display_item::ImageRendering) [sw_compositor.rs:c535910772183974873a1b13ce36901d12348b26 : 1394 + 0x16d]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x5a77c0bf    esp = 0x104ee4dc    ebp = 0x104ee560    ebx = 0x210d2198
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x0f3c80e0    edi = 0x21211e00
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  5  xul.dll!webrender::composite::CompositeState::composite_native(webrender_api::color::ColorF, ref$<slice2$<euclid::box2d::Box2D<i32,webrender_api::units::DevicePixel> > >, webrender::device::gl::Device*, ref_mut$<dyn$<webrender::composite::Compositor> >) [mod.rs:c535910772183974873a1b13ce36901d12348b26 : 5880]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  6  xul.dll!webrender::renderer::Renderer::draw_frame(webrender::frame_builder::Frame*, enum2$<core::option::Option<euclid::size::Size2D<i32,webrender_api::units::DevicePixel> > >, unsigned int, webrender::renderer::RenderResults*) [mod.rs:c535910772183974873a1b13ce36901d12348b26 : 4476 + 0x11b]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x5a998a61    esp = 0x104ee568    ebp = 0x104eec2c    ebx = 0x23524c38
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0xe5e5e500    edi = 0x000000d0
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  7  xul.dll!webrender::renderer::Renderer::render_impl(webrender_api::DocumentId, webrender::internal_types::RenderedDocument*, enum2$<core::option::Option<euclid::size::Size2D<i32,webrender_api::units::DevicePixel> > >, unsigned int) [mod.rs:c535910772183974873a1b13ce36901d12348b26 : 1522 + 0x34]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x5a983ec6    esp = 0x104eec34    ebp = 0x104ef0e8    ebx = 0x104eecf0
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x33a17000    edi = 0x33a17000
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  8  xul.dll!webrender::renderer::Renderer::render(euclid::size::Size2D<i32,webrender_api::units::DevicePixel>, unsigned int) [mod.rs:c535910772183974873a1b13ce36901d12348b26 : 1239]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -  9  xul.dll!webrender_bindings::bindings::wr_renderer_render(webrender::renderer::Renderer*, int, int, unsigned int, webrender::renderer::RendererStats*, thin_vec::ThinVec<euclid::box2d::Box2D<i32,webrender_api::units::DevicePixel> >*) [bindings.rs:c535910772183974873a1b13ce36901d12348b26 : 619 + 0x140]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x5a9cdec9    esp = 0x104ef0f0    ebp = 0x104ef680    ebx = 0x00000031
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x33a17090    edi = 0x00000000
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 10  xul.dll!mozilla::wr::RendererOGL::UpdateAndRender(mozilla::Maybe<mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> > const&, mozilla::Maybe<mozilla::wr::ImageFormat> const&, mozilla::Maybe<mozilla::Range<unsigned char> > const&, bool*, mozilla::wr::RendererStats*) [RendererOGL.cpp:c535910772183974873a1b13ce36901d12348b26 : 190 + 0x14]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56ca00da    esp = 0x104ef688    ebp = 0x104ef6d0    ebx = 0x00000000
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x104ef910    edi = 0x22343b20
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 11  xul.dll!mozilla::wr::RenderThread::UpdateAndRender(mozilla::wr::WrWindowId, mozilla::layers::BaseTransactionId<mozilla::VsyncIdType> const&, mozilla::TimeStamp const&, bool, mozilla::Maybe<mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> > const&, mozilla::Maybe<mozilla::wr::ImageFormat> const&, mozilla::Maybe<mozilla::Range<unsigned char> > const&, bool*) [RenderThread.cpp:c535910772183974873a1b13ce36901d12348b26 : 786 + 0x18]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56c9f7a5    esp = 0x104ef6d8    ebp = 0x104ef8c4    ebx = 0x20230d20
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x104ef6f0    edi = 0x15c60640
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 12  xul.dll!mozilla::wr::RenderThread::HandleFrameOneDocInner(mozilla::wr::WrWindowId, bool, bool, mozilla::Maybe<mozilla::wr::FramePublishId>) [RenderThread.cpp:c535910772183974873a1b13ce36901d12348b26 : 629 + 0x28]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56c9f057    esp = 0x104ef8cc    ebp = 0x104ef994    ebx = 0x104ef99c
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x104ef920    edi = 0x104ef950
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 13  xul.dll!mozilla::wr::RenderThread::HandleFrameOneDoc(mozilla::wr::WrWindowId, bool, bool, mozilla::Maybe<mozilla::wr::FramePublishId>) [RenderThread.cpp:c535910772183974873a1b13ce36901d12348b26 : 576 + 0x33]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56c9ea40    esp = 0x104ef99c    ebp = 0x104ef9d0    ebx = 0x00000101
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x0156e800    edi = 0x104ef9d8
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 14  xul.dll!mozilla::wr::RenderThread::WrNotifierEvent_HandleNewFrameReady(mozilla::wr::WrWindowId, bool, mozilla::wr::FramePublishId) [RenderThread.cpp:c535910772183974873a1b13ce36901d12348b26 : 537 + 0x14]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56c9e9d3    esp = 0x104ef9d8    ebp = 0x104efa08    ebx = 0x00000000
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x00000000    edi = 0x00000006
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 15  xul.dll!mozilla::wr::RenderThread::HandleWrNotifierEvents(mozilla::wr::WrWindowId) [RenderThread.cpp:c535910772183974873a1b13ce36901d12348b26 : 499 + 0xf]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56c9e84c    esp = 0x104efa10    ebp = 0x104efa44    ebx = 0x0000000b
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x20230e80    edi = 0x20abcc10
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 16  xul.dll!mozilla::detail::RunnableMethodArguments<unsigned long long>::apply<mozilla::layers::InputQueue,void (mozilla::layers::InputQueue::*)(unsigned long long) __attribute__((thiscall))>::<lambda_1>::operator()(StoreCopyPassByConstLRef<unsigned long long>&) const [nsThreadUtils.h:c535910772183974873a1b13ce36901d12348b26 : 1213]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 17  xul.dll!std::invoke(mozilla::detail::RunnableMethodArguments<unsigned long long>::apply<mozilla::layers::InputQueue,void (mozilla::layers::InputQueue::*)(unsigned long long) __attribute__((thiscall))>::<lambda_1>&&, StoreCopyPassByConstLRef<unsigned long long>&) [type_traits : 1534]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 18  xul.dll!std::_Apply_impl(mozilla::detail::RunnableMethodArguments<unsigned long long>::apply<mozilla::layers::InputQueue,void (mozilla::layers::InputQueue::*)(unsigned long long) __attribute__((thiscall))>::<lambda_1>&&, std::tuple<StoreCopyPassByConstLRef<unsigned long long> >&, std::integer_sequence<unsigned int,0>) [tuple : 974]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 19  xul.dll!std::apply(mozilla::detail::RunnableMethodArguments<unsigned long long>::apply<mozilla::layers::InputQueue,void (mozilla::layers::InputQueue::*)(unsigned long long) __attribute__((thiscall))>::<lambda_1>&&, std::tuple<StoreCopyPassByConstLRef<unsigned long long> >&) [tuple : 979]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 20  xul.dll!mozilla::detail::RunnableMethodArguments<unsigned long long>::apply(mozilla::layers::InputQueue*, void (mozilla::layers::InputQueue::*)(unsigned long long)) [nsThreadUtils.h:c535910772183974873a1b13ce36901d12348b26 : 1162]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 21  xul.dll!mozilla::detail::RunnableMethodImpl<mozilla::layers::InputQueue *,void (mozilla::layers::InputQueue::*)(unsigned long long) __attribute__((thiscall)),1,0,unsigned long long>::Run() [nsThreadUtils.h:c535910772183974873a1b13ce36901d12348b26 : 1213 + 0x12]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56afc7ed    esp = 0x104efa4c    ebp = 0x104efa64    ebx = 0x0000000b
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x0156e800    edi = 0x56c9e5c0
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 22  xul.dll!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:c535910772183974873a1b13ce36901d12348b26 : 1233 + 0xd]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56190c19    esp = 0x104efa6c    ebp = 0x104efbb4    ebx = 0x0f35a430
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x20595900    edi = 0x104efbcb
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 23  xul.dll!NS_ProcessNextEvent(nsIThread*, bool) [nsThreadUtils.cpp:c535910772183974873a1b13ce36901d12348b26 : 479 + 0x19]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56194840    esp = 0x104efbbc    ebp = 0x104efbd8    ebx = 0x00000000
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x0f35a430    edi = 0x104efc84
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 24  xul.dll!mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [MessagePump.cpp:c535910772183974873a1b13ce36901d12348b26 : 300 + 0x9]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56770e11    esp = 0x104efbe0    ebp = 0x104efc08    ebx = 0x00000001
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x0f0d1940    edi = 0x104efc84
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 25  xul.dll!MessageLoop::RunInternal() [message_loop.cc:c535910772183974873a1b13ce36901d12348b26 : 369]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 26  xul.dll!MessageLoop::RunHandler() [message_loop.cc:c535910772183974873a1b13ce36901d12348b26 : 362 + 0x13]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56736e99    esp = 0x104efc10    ebp = 0x104efc40    ebx = 0x56770d30
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x104efc84    edi = 0x0f0d1940
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 27  xul.dll!MessageLoop::Run() [message_loop.cc:c535910772183974873a1b13ce36901d12348b26 : 344 + 0x4]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x56736df6    esp = 0x104efc48    ebp = 0x104efc60    ebx = 0x0f0cea74
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x104efc84    edi = 0x0f35a430
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 28  xul.dll!nsThread::ThreadFunc(void*) [nsThread.cpp:c535910772183974873a1b13ce36901d12348b26 : 391 + 0x6]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x5618dffd    esp = 0x104efc68    ebp = 0x104efd54    ebx = 0x0f0cea74
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x104efc84    edi = 0x0f35a430
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 29  nss3.dll!_PR_NativeRunThread(void*) [pruthr.c:c535910772183974873a1b13ce36901d12348b26 : 399 + 0xe]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x6a114cc4    esp = 0x104efd5c    ebp = 0x104efd7c    ebx = 0x0150c4c0
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x0f35a580    edi = 0x0f0cea70
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 30  nss3.dll!pr_root(void*) [w95thred.c:c535910772183974873a1b13ce36901d12348b26 : 139 + 0xe]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x6a1083b6    esp = 0x104efd84    ebp = 0x104efd8c    ebx = 0x003f6768
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x0f35a580    edi = 0x003f6768
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 31  ucrtbase.dll!thread_start<unsigned int (__stdcall*)(void *),1> + 0x3e
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x69e54f8f    esp = 0x104efd94    ebp = 0x104efdc4    ebx = 0x003f6768
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x6a1083a0    edi = 0x003f6768
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 32  kernel32.dll + 0x4ef3b
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x75eaef3c    esp = 0x104efdcc    ebp = 0x104efdd0    ebx = 0x003f6768
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x6a1083a0    edi = 0x003f6768
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 33  mozglue.dll!mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared>,void (*)(int, void *, void *) __attribute__((fastcall))>::operator()(int&, void*&, void*&) const [nsWindowsDllInterceptor.h:c535910772183974873a1b13ce36901d12348b26 : 150]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: inlining
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 34  mozglue.dll!patched_BaseThreadInitThunk(int, void*, void*) [WindowsDllBlocklist.cpp:c535910772183974873a1b13ce36901d12348b26 : 616 + 0xa]
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x69fa8413    esp = 0x104efdd8    ebp = 0x104efe04
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: previous frame's frame pointer
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 35  ntdll.dll!__RtlUserThreadStart + 0x26
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x77a63618    esp = 0x104efe0c    ebp = 0x104efe44    ebx = 0x003f6768
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x00000000    edi = 0x00000000
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO - 36  ntdll.dll!_RtlUserThreadStart + 0x1a
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      eip = 0x77a635eb    esp = 0x104efe4c    ebp = 0x104efe5c    ebx = 0x003f6768
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -      esi = 0x00000000    edi = 0x00000000
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -     Found by: call frame info
[task 2023-05-18T18:44:06.752Z] 18:44:06     INFO -
Flags: needinfo?(stransky)
Flags: needinfo?(stransky)

Cool, looks like our testsuite hits the core issues too.

See Also: → 1830769
Blocks: sw-wr-stability
Keywords: crash
See Also: → 1810165

If RenderTextureHostSWGL is locked and context is changed, RenderTextureHostSWGL::SetContext() cleares planes.
In such case we need to create them again.

Attachment #9325656 - Attachment is obsolete: true
Attachment #9326605 - Attachment is obsolete: true
Flags: needinfo?(stransky)
Flags: needinfo?(lsalzman)

Glenn, do you have an idea what is going on here? It seems like more than one SwCompositor (and thus separate SWGL contexts) are trying to lock the same external image id at the same time...

SwCompositor #1 locks ext image
SwCompositor #2 locks ext image
... something something ...
SwCompositor #1 unlocks ext image
SwCompositor #2 unlocks ext image

Should that even be possible? Can we really have multiple SwCompositors simultaneously trying to render, thus locking that ext image simultaneously?

Flags: needinfo?(gwatson)

I would not have expected multiple SwCompositors to be referencing the same external image, but perhaps that is possible in PiP mode?

Flags: needinfo?(gwatson)

(In reply to Glenn Watson [:gw] from comment #64)

I would not have expected multiple SwCompositors to be referencing the same external image, but perhaps that is possible in PiP mode?

It's happening... I just don't know why.

TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_backgroundTab.js

bug 1782134 is about the same file.

Felixoid, keystroke33 and the CI have hardware rendering blocked because they are using the not-recommended legacy intel DDX X11 driver instead of the modesetting driver.
In bug 1710400 comment 42 I had found out that the problem HW WR was suffering from on Intel DDX could also be fixed by disabling GLX_SGI_video_sync by setting layout.frame_rate:60.

Does the CI still crash if you set these prefs?

  • gfx.webrender.multithreading:false layout.frame_rate:60 gfx.x11-egl.force-enabled:true webgl.threadsafe-gl.force-disabled:true webgl.use-canvas-render-thread:false gfx.webrender.allow-partial-present-buffer-age:false gfx.webrender.max-partial-present-rects:0
    gfx.webrender.pbo-uploads:false
    (bug 1710400, bug 1725009, bug 1777849, bug 1723323, bug 1738816, bug 1741956)

  • Maybe additionally set browser.tabs.inTitlebar:0?

  • Maybe additionally run sudo apt-get remove xserver-xorg-video-intel -y in CI? bug 1742708

Running build from comment 59 that crashed in CI and clicking to open PiP from context menu doesn't crash for me on KDE Wayland, Debian Testing:
$ MOZ_ENABLE_WAYLAND=0 mozregression --repo autoland --launch c53591077218 --pref gfx.webrender.software:true -a 'https://htmlpreview.github.io/?https://raw.githubusercontent.com/mozilla/gecko-dev/master/toolkit/components/pictureinpicture/tests/test-page.html'
$ LIBGL_ALWAYS_SOFTWARE=1 MOZ_ENABLE_WAYLAND=0 mozregression --repo autoland --launch c53591077218 --pref gfx.webrender.all:true -a 'https://htmlpreview.github.io/?https://raw.githubusercontent.com/mozilla/gecko-dev/master/toolkit/components/pictureinpicture/tests/test-page.html'

Does the CI still crash if you set these prefs?

Also this one: nglayout.enable_drag_images:false (to avoid bug 1796960 which could be connected to bug 1723323).

Assignee: stransky → nobody
Status: ASSIGNED → NEW
Attachment #9336090 - Attachment is obsolete: true
Blocks: 1830769

We were locking composite surfaces, which were tracked within surfaces in frame_surfaces.
frame_surfaces was subsequently clipped and pruned. We then crawled frame_surfaces for
composite surfaces to unlock, which were unintentionally pruned by that point.

The solution to this mess is to just track composite surfaces that are locked independently
of frame_surfaces, so no more issues with clipping.

Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ea703c4d3f0 Track composite surfaces independently of frame_surfaces. r=aosmond
Flags: needinfo?(lsalzman)
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/14bda3033419 Track composite surfaces independently of frame_surfaces. r=aosmond

https://hg.mozilla.org/mozilla-central/rev/14bda3033419

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

Hello, thanks for fixing it!

Will it be backported to affected versions, btw?

The patch landed in nightly and beta is affected.
:lsalzman, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(lsalzman)

Comment on attachment 9338513 [details]
Bug 1812982 - Track composite surfaces independently of frame_surfaces. r?aosmond

Beta/Release Uplift Approval Request

  • User impact if declined: Crashes and corruption when using picture-in-picture with Software WebRender.
  • Is this code covered by automated tests?: Unknown
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just fixes where surface locking/unlocking is done during some compositing steps to be cleaner.
  • String changes made/needed:
  • Is Android affected?: Unknown
Flags: needinfo?(lsalzman)
Attachment #9338513 - Flags: approval-mozilla-beta?

Comment on attachment 9338513 [details]
Bug 1812982 - Track composite surfaces independently of frame_surfaces. r?aosmond

Approved for 115.0b5.

Attachment #9338513 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Hi Felixoid! Could you please help us verify if the bug is fixed on the latest builds available:

Unfortunately, I was not able to reproduce the crash on my Ubuntu 20.04 x64 and Ubuntu 22.04 (VM) x64.

Flags: needinfo?(mr.felixoid)

I've built it locally from https://gitlab.archlinux.org/archlinux/packaging/packages/firefox/-/blob/main/PKGBUILD with the following diff:

diff --git a/PKGBUILD b/PKGBUILD
index a29ad52..834570a 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -67,6 +67,7 @@ source=(
   https://archive.mozilla.org/pub/firefox/releases/$pkgver/source/firefox-$pkgver.source.tar.xz{,.asc}
   $pkgname.desktop
   identity-icons-brand.svg
+  0001-Bug-1812982-Make-RenderTextureHostSWGL.patch::https://hg.mozilla.org/mozilla-central/raw-diff/14bda30334192468d94bd543a8ef3ba4bdafa578/gfx/wr/webrender/src/compositor/sw_compositor.rs
 )
 validpgpkeys=(
   '14F26682D0916CDD81E37B6D61B7B526D98F0353'  # Mozilla Software Releases <release@mozilla.com>
@@ -74,11 +75,13 @@ validpgpkeys=(
 sha256sums=('7e4ebc13e8c94af06f703af2119cf1641d4186174a3d59b7812f9d28f61b7d18'
             'SKIP'
             '1f241fdc619f92a914c75aece7c7c717401d7467c9a306458e106b05f34e5044'
-            'a9b8b4a0a1f4a7b4af77d5fc70c2686d624038909263c795ecc81e0aec7711e9')
+            'a9b8b4a0a1f4a7b4af77d5fc70c2686d624038909263c795ecc81e0aec7711e9'
+            'b2f8f661f4219f630e273cfd1afca27c00f3a4ec4be057b2b82e73a585aac65b')
 b2sums=('a34733d3216b98e9de8e1f94a036bfdd0f8924a04e6971fa306ac1230a7cdb6a6a807b5d6fc2848038c4148f2b4658aa216c9c0141cc8a231511294bf59b0ef5'
         'SKIP'
         'd07557840097dd48a60c51cc5111950781e1c6ce255557693bd11306c7a9258b2a82548329762148f117b2295145f9e66e0483a18e2fe09c5afcffed2e4b8628'
-        '63a8dd9d8910f9efb353bed452d8b4b2a2da435857ccee083fc0c557f8c4c1339ca593b463db320f70387a1b63f1a79e709e9d12c69520993e26d85a3d742e34')
+        '63a8dd9d8910f9efb353bed452d8b4b2a2da435857ccee083fc0c557f8c4c1339ca593b463db320f70387a1b63f1a79e709e9d12c69520993e26d85a3d742e34'
+        '572340f99be8e2024346647398025fc254db5684b92e6edb7d64d3029ecbf3e79078ad572a2628e344773d1ec83ebf6395a8155cd6754e5ec09aa022be5fb2a9')

 # Google API keys (see http://www.chromium.org/developers/how-tos/api-keys)
 # Note: These are for Arch Linux use ONLY. For your own distribution, please
@@ -96,6 +99,10 @@ prepare() {
   mkdir mozbuild
   cd firefox-$pkgver

+  # https://bugs.archlinux.org/task/78017
+  # https://bugzilla.mozilla.org/show_bug.cgi?id=1812982
+  patch -Np1 -i ../0001-Bug-1812982-Make-RenderTextureHostSWGL.patch
+
   echo -n "$_google_api_key" >google-api-key
   echo -n "$_mozilla_api_key" >mozilla-api-key

The youtube pages don't crash anymore!

Flags: needinfo?(mr.felixoid)

That's great! Thank you.

I'm going to close this as verified fixed per comment 79.

Status: RESOLVED → VERIFIED
status-firefox115: fixed → verified
status-firefox116: fixed → verified
Flags: qe-verify+
Duplicate of this bug: 1830769
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: