1502519 - CSD regression: (Un)maximizing/snapping a window can break window content on KDE and Gnome

Status: REOPENED

(Core :: Widget: Gtk, defect, P3)

Description

[Darkspirit]

In bug 1502516 WebRender recently regressed to the behavior of non-WebRender OpenGL.
This bug is for the regression range of non-WR OpenGL + GPU process.

(Jan Andre Ikenmeyer [:darkspirit] from bug 1502516 comment 0)
> Created attachment 9020459 [details]
> 2018-10-26_22-26-47.mp4
> 
> Debian Testing, KDE, Xorg, GTX1060.
> Win10 (with/without ANGLE) is fine.
> 
> STR: Open the library, e.g. Downloads by Ctrl+Shift+Y. Maximize the window.
> 
> Actual: The window is maximized but transparent/empty. Unmaximizing makes
> the window black inside. Both can be fixed by hovering elements.
> 
> Expected: The content should adjust to the new window size.

mozregression --good 2018-01-13 --bad 2018-01-16 --pref layers.acceleration.force-enabled:true layers.gpu-process.force-enabled:true
> 9:39.60 INFO: Last good revision: 5a46db143897c53211818c722f15c510dd708c6c
> 9:39.60 INFO: First bad revision: 7d2121c8e0dd75cc48d8021ba55565889da8aac7
> 9:39.60 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5a46db143897c53211818c722f15c510dd708c6c&tochange=7d2121c8e0dd75cc48d8021ba55565889da8aac7

> 7d2121c8e0dd	Martin Stransky — Bug 1417933 - enable CSD titlebar rendering mode on Unity desktop, r=jhorak
> 4fbda7310828	Martin Stransky — Bug 1417933 - enable CSD titlebar rendering mode as Bug 1424974 regression is fixed, r=jhorak

Comment 1

[Darkspirit]

Not reproducible with Gnome on Debian Testing.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Okay, adding to the titlebar tracker.

Comment 3

[Darkspirit]

Attachment: 2019-05-04_14-53-33.mp4

Debian Testing, X11, Macbook Pro

STR for KDE:

1. run mozregression --launch 2019-05-01 --pref layers.acceleration.force-enabled:true -a about:blank
2. Open Help > About Nightly, maximize it, unmaximize it, etc.

(Regression range is the same as in comment 0.)

Fine:
MOZ_GTK_TITLEBAR_DECORATION=none mozregression --launch 2019-05-01 --pref layers.acceleration.force-enabled:true -a about:blank
MOZ_GTK_TITLEBAR_DECORATION=system mozregression --launch 2019-05-01 --pref layers.acceleration.force-enabled:true -a about:blank

Broken (as without env var):
MOZ_GTK_TITLEBAR_DECORATION=client mozregression --launch 2019-05-01 --pref layers.acceleration.force-enabled:true -a about:blank

Comment 5

[Darkspirit]

WebRender's picture caching makes this bug more likely/visible.

Comment 6

[Tim Spurway [:tspurway]]

Martin, could you prioritize/triage this one?

Comment 8

[B.J. Herbison]

There are several images of examples when changing workspaces on XFCE attached to bug 1547964.
(I see this dozens of times a day.)

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Jan, is this bug for accelerated (web render / GL compositor) or non-accelerated Firefox? Because it may be a different bug in all those cases.

Comment 10

[Darkspirit]

OpenGL + WebRender.
Changing workspaces is WebRender-only bug 1514148 though.

Comment 11

[Darkspirit]

bug 1569745 is an OpenGL+WebRender bug like this one, too. Both were caused by enabling CSD / ARGB visual.

An observation: In comment 3 (attachment 9062697 [details]) you see that "About Firefox Nightly" is not correctly sized right after opening it. I would not be surprised if it was related to bug 1489463.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch for 70 or beyond.
Since we are getting close to the end of the 69 beta cycle and this is set to P3, I'm marking it fix-optional for 69 and 70 to remove it from weekly triage.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Jan, is that X11 only or it's broken on both X11 and Wayland? Thanks.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Should be fixed by bug 1489463.

Comment 15

[Darkspirit]

Attachment: 2020-01-14_15-25-56.mp4

Sorry: Attached screencast is WebRender/KDE/X11/Debian Testing/Macbook Pro.

Comment 16

[Darkspirit]

(And if you noticed that menu entries are highlighted with a delay - the paint happens only when the next entry is hovered -, that's bug 1567791: WebRender uses Basic Compositor for small widgets. The problem only happens with Basic widgets inside GPU process when using a non-compositing window manager. It would also occur when directly using Basic compositing + gpu process + layers.gpu-process.allow-software;true)

Comment 17

[Pascal Chevrel:pascalc]

It's not clear to me if that bug is still valid, is that a duplicate of bug 1489463 ?

Comment 18

[Darkspirit]

bug 1489463 was about a broken main window on startup (screencast: bug 1489463 comment 62) and was fixed.
This bug is about broken painting when maximizing a window other than the main window, e.g. Library, Downloads, About.

Comment 20

[Martin Stránský [:stransky] (ni? me)]

Please test it under Plasma 5.18 - it should support some Gtk+ specific hacks.

Comment 21

[Darkspirit]

Attachment: Ubuntu 20.04 KDE.mp4

The bug is still present with Plasma 5.18.3/Ubuntu 20.04 (Radeon RX480) and Plasma 5.17.5/Debian Testing (Macbook Pro: Intel Iris 6100 Broadwell GT3).

• Debian Testing doesn't have 5.18 yet: https://tracker.debian.org/pkg/plasma-desktop
• Screencast: Ubuntu 20.04 with Plasma 5.18.3: https://packages.ubuntu.com/focal/plasma-desktop
  I upgraded from Ubuntu 19.10 to Ubuntu 20.04:

  sudo apt install plasma-desktop
  sudo do-release-upgrade -d # development version
  

Comment 22

[Darkspirit]

I can't reproduce this bug with GDK_BACKEND=wayland because Firefox is freezing: bug 1609115 (bug 1593478 == bug 1584845)

Comment 23

[Darkspirit]

KDE/X11: Software WebRender (bug 1601053) is affected by this as well.

Comment 26

[Darkspirit]

Attachment: Bildschirmvideo von 31.07.2020 01:51:14.webm

Also reproducible with Gnome XWayland, Debian Testing, 2560x1440@60Hz, Intel HD Graphics 630 (KBL GT2).
mozregression --launch 2020-07-30 --pref gfx.webrender.all:true layers.gpu-process.enabled:false -a https://keithclark.co.uk/labs/css-fps/nojs/
» About Firefox with Minecraft glass effect «

Comment 27

[Darkspirit]

With my own small EGL/X11 demo app I encountered a bug that looked exactly the same as the one in comment 3, comment 15 and comment 21.
I could fix it with:

// If not set, some GL frames are just empty on Gnome Xwayland+X11/Mesa.
// https://docs.gtk.org/gtk3/method.Widget.set_double_buffered.html
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
gtk_widget_set_double_buffered(GTK_WIDGET(window_widget_ptr), FALSE);
G_GNUC_END_IGNORE_DEPRECATIONS

Firefox has gotten a similar code line:
https://searchfox.org/mozilla-central/rev/cdfdd9704d53b1dd03b991ab508fe5cffa461609/widget/gtk/nsWindow.cpp#5739

I need to retest this bug on KDE/X11.

Comment 28

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.