181397 - automatically create Junk Mail folder at appropriate times

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

bienvenu has convinced me that we really do wanna do this both from teh Junk
Mail dialog as well as dynamically frmo the move coalescer.

Comment 2

[Andrew Perry]

Here are my comments from bug #180153
http://bugzilla.mozilla.org/show_bug.cgi?id=180153#c15 .... The "coalescer"? Is
that the message filters section ... b/c the code was just reversed to perform
Junk Mail analysis AFTER message filters are applied .. How would you perform a
Junk Mail move dynamically from a Message Filter (NOT Junk Mail controls) if
they status isnt changed until AFTER the filters are applied ??? 

Or am I understanding the "coalescer" incorrect here?

Otherwise, cant you just check for the existance of "Junk Mail" folder on commit
(OK) IF the "Junk Mail" folder in <directory> is selected from the junk mail
controls ??? If not exist, then create ... if exist, move along :) ??? 

And, then we just accept the fact that you can only MOVE junk mail dynamically
(immediately as it is labelled) directly from the Junk Mail controls, and the
message filters move can only be performed from a *Run Now* ... 

Comment 3

[lchiang]

Would there be a way to designate the Junk Mail folder?   In my filters, I have
a lot of filters set up to move mail matching various criteria that I have set
to a folder I created called "Junk".  

If I use this Junk Mail Control feature, I'd like to be able to tell the
application that "Junk Mail" folder = "Junk" folder and not create a "Junk Mail"
folder.  This way, I don't have to change my filters.

Comment 4

[Andrew Perry]

I changed the junkmail.js code around and am having no problems with the AUTO
Creation of Junk Mail folder when it detects junk mail for the first time.
I tested this out on a POP account.  Only issue was that it created a "JUNK"
folder, Not the expected "JUNK MAIL" folder.

(Used build 2002112504) ... 
I would expect the folder to use the special Junk Mail icon (but I cld open
another bug on that if needed)
 

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: work in progress, v5

Not ready for use yet, but it's a start.  More soon.

Comment 6

[(not reading, please use [e-mail] instead)]

taking from dmose.  I talked with dmose and bienvenu about where they were going
with this.

I'll be working on this, so that we can enable the "move junk to folder" part of
the junk mail feature.

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: patch, work in progress

I haven't tested this.	just trying some things out (as suggested by dmose and
bienvenu).  if some of this code looks familiar, it's the nsMsgCopy code
cleaned up, and moved around.

Comment 8

[(not reading, please use [e-mail] instead)]

talked to bienvenu, the junk folder flag is staying and he has some other
suggestions.

he also set me straight on some other things.

new patch coming later today, we should be able to turn on the move UI soon.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: still a work in progress.

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: still working on this, testing it, etc.

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: more changes, plus some missing license foo

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: updated patch, the other code cleanup has been checked in already

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

Comment 14

[(not reading, please use [e-mail] instead)]

Attachment: update

Comment 15

[(not reading, please use [e-mail] instead)]

I've checked in my fix.  

it has r/sr=bienvenu

it has I'm going to mark this bug fixed, but there are scenarios (and loose
ends) I still need to take care of.

I'll elaborate with what works, and what needs to be fixed, and log some spin
off bugs.

Comment 16

[Zac Spitzer]

it wuld be cool to have a empty junk menu items ala empty trash

Comment 17

[Patrick]

Is this new "junk" folder treated like a special folder in the same way as
DRAFTS or SENT?

The reason for asking : i have several installs (multiple multi-boot computers)
and i keep my junk mail so i can easily (re)train my spam recognizer for each
installation. The way it is now, each time i have to manually mark all messages
in the IMAP "junk" folder as being junk. Perhaps it's safe to assume that
everything in the "junk" folder is junk and therefore automagically marked as
such. That way all filters trained with the same IMAP "junk" folder exhibit the
same recognition?

Couldn't find this one yet.

Comment 18

[esther]

Testing automatically creating the Junk mail folder when turning on Junk mail
controls on Windows only at this time.  
New Profile one mail account:
IMAP-Creates the folder immediately but doesn't mark it as special folder until
you ping the server by collapse/expand the server or Get Msg.  OK
POP- Creates the folder immediately and marks it special.  OK
WebIMAP - Same as IMAP.  OK
AOLIMAP - Gives error that it can't create the folder - expected  Maybe we
should default to Local folder for this case, I'll write up a bug.  
New Profile 3 accounts IMAP, POP & POP:
All accounts created the Junk folder as mentioned in single cases above.  OK,
for all accounts and special folders are listed in the same order for each
account after server has been pinged.  
  
I have some spin off bugs regarding setting up the same IMAP account in a new
profile.  

This bug is verified/fixed. 

Comment 19

[esther]

Note, my verification was done on the 20030121 win trunk build.

Comment 20

[esther]

spinnoff bugs 190349 & 190354