181454 - Multiple windows opened following load request from another application

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Wagner One]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.3a) Gecko/20021120
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.3a) Gecko/20021120

in 10.2.2, when this build of moz is instructed to activate and open and URL by
another application (typically, M$ Entourage), it activates and loads the page.
the problem is it loads the page over and over again, presumably consuming
resources until crash. moz is barely responsive when it is in this "loop loading
page" state. i can close windows but another will replace it as soon as i do. i
can Quit moz with repeated CMD-Q attempts and i can force quit it. will verify
and comment as to whether this is just Entourage or other applications as well

Reproducible: Always

Steps to Reproduce:
1. click on an URL embedded in Entourage/other application that is to launch
browser and open said URL
2.
3.

Actual Results:  
moz repeatidly opened externally requested URL over and over in new windows

Expected Results:  
open the externally requested URL in a single, new window

i am using tabbed browsing on a vanilla install of moz (i download the latest
trunk each morning). this just cropped up recently in the past several days. i
am using classic theme with no icons. build ID listed in moz windows is
2002112008 (it is, assuming intentionally, truncated above)

Comment 1

[Wagner One]

1. verified that it happens with external URL requests from other applications.
opened Terminal, typed in an URL and CMD-clicked it

2. after CMD-Q out of Terminal requested loop, activated >THIS< URL from within
Entourage to add these comments. this caused moz to launch and open this url
without the loop issue. re-tested this by quitting moz and re-clicking on this
URL from within Entourage

3. closed all windows in moz and attempted to activate same URL in Entourage.
page loading loop ensued. only seems to NOT happen when moz is not running and
is lanuched on external request

Comment 2

[Greg K.]

Confirmed using FizzillaCFM/2002112208. I command+clicked a URL in
MT-NewsWatcher and Mozilla kept opening new windows to display it. I had to
force-quit Mozilla.

Comment 3

[Chris Johnson]

FWIW, this also occurs on MacOS 9.0.4 (build ID#2002112208), so you might want
to change the OS field to All.  Any url launched from another application or
from a URL file in the Finder opens in window after window.

I don't really understand any of this, but this is an Apple Event problem,
right?  I've noticed some bugs have their summaries flagged with [Apple Events]
(for example: bug 181868 ).  Should this bug?

Comment 4

[Greg K.]

Changing OS to Mac System 9.x per comment 3 (it isn't downgraded to port status
yet, so this is the correct setting).

Possibly Event Handling? Let's try that first.

Comment 5

[klanda]

OK, I was experiencing this bug too, and then I tried opened the Internet Pref
Pane, and changed the linkage from 1.2b to 1.3a (the nightly) and the bug
_seems_ to have been squashed. Can anyone else try this?

Ken

Comment 6

[Greg K.]

The problem is still evident to me using FizzillaMach/2002112507 after ensuring
it's selected in Internet Prefernces.

Comment 7

[saari (gone)]

if it is happening in FizzillaMach then we should make the platform OSX so it
gets more love

Comment 8

[klanda]

Hmmm. Why is this listed as a 9.x bug in the OS field? (Don't understand Greg's
explanation re "downgraded to port status".)

The orig report talks about OSX (althought there is a reference in Comment 3 to
9.0x). I for one experienced this in 10.0.2, although (see comment 3) it seems
to have been self-squashed by changing my Internet browser prefs in the pref
pane. (Oh, also installed Orbit Retro skin, fwiw).

K

Comment 9

[Greg K.]

[e-mail], the OS field is supposed to indicate the oldest OS version under
which the problem is evident. Since the problem has been seen in OS X and OS 9,
the OS field is set to OS 9.

(Of course OS X and OS 9 are a lot more different than just a major version
number. The current configuration of Mac system versions in Bugzilla leaves much
to be desired, but in its' present state this bug is set correctly.)

Comment 10

[Chris Johnson]

Well, I tried pinning down when this bug first popped up.  As far as I can tell,
the last nightly trunk build in which this does not occur is 2002111515. 
Unfortunately, there's a big gap of time in which there aren't any non-OS X Mac
nightlies; the next one I found (I won't guarantee that I didn't miss any),
2002111908, exhibits this problem.  Hope that's at least a little bit helpful.

One other observation: this problem only occurs when Mozilla is already running.
 If Mozilla isn't open, and you, say, double-click on a URL in the Finder,
Mozilla will launch and open the URL in only one window, like it's supposed to.
 Don't know how relevant that is.

Comment 11

[Wagner One]

re: [e-mail]  [internet pref pane selection]

i verified that my selected browser is moz 1.3a in my internet prefs pane/web
and it still happens with the latest build (2002112908)

interesting thing is when i attempt to manually choose the newly installed moz
instead of using the pop-up menu in the internet prefs pane, nothing seems to
happen after navigating to and selecting the application. i end up with a blank
in the selected web browser

fwiw, i only have moz 1.3a in my internet pref pane web browser selection. IE
isn't on my machine

Comment 12

[Chris Johnson]

Has anyone who knows what they're doing checked Bonsai between 11-15 and 11-19
to   figure out what checkin screwed this up?  To my non-programmer eyes, the
checkins for bug 111797 and bug 179932 look somewhat suspicious, but then I
don't understand these things.

I realize I'm not being very helpful, and I don't want to nag.  I'm just afraid
that this will become harder to fix the more time that passes.  Moreover, since
there may be a OS X workaround*, I'm a little worried that fixing this for OS 9
will be seen as a low priority and put off indefinitely.

*For the record, I got access to an OS X system, hoping to pinpoint more
precisely when this bug first appeared.  I wasn't able to reproduce the bug at
all.  I suspect that this could be due to the fact the system had IE as it's
default browser so I had to change it.  Following comment 5, that may have
prevented the problem.  I don't know.  I can say that no analogous workaround
works with recent OS 9 builds.

Comment 13

[Wagner One]

long ago i had trouble getting my browser pref to stick in the internet control
panel pane in osx. i took the advice of a osxhints tip and created a disk image
and moved the explorer application bundle into it and then left the disk image,
unmounted, in the Applications folder. i could then mount it on the off chance
that i would need to use exploder for something. until then IE didn't enter into
the picture at all as far as my os was concerned and moz would remain my
preferred browser.

see above in my comment #11 where i said i could not, in the internet control
panel pane, navigate to the moz application icon and end up with anything
showing as selected. today i mounted my IE disk image and went back to the
internet cp pane where i found IE and Moz 1.3a listed in the pop-down menu of
browers to choose from. instead of choosing either of those, i navigated to my
current moz build and selected it. it stuck. i quit moz and unmounted the IE
image, essentially removing it from the system. 

now moz 1.3a is showing up as selected in the internet cp pane. there are no
other choices but that at this point (with the ie disk image unmounted). things
seem to be working ok now in regards to external links not infinite looping on
open. it's not a real fix i guess, but it's great as far as i'm concerned. this
bug was driving me (and my workstation) nuts! :) 

Comment 14

[Greg K.]

Wagner One, that comment is irrelevant to this bug. Please refrain from adding
irrelevant comments to bug. If you can't find an appopriate bug to comment on,
you might try end-user forums such as those on MozillaZine.org.

Comment 15

[Torben]

*** Bug 186245 has been marked as a duplicate of this bug. ***

Comment 16

[Torben]

*** Bug 188522 has been marked as a duplicate of this bug. ***

Comment 17

[Torben]

*** Bug 187854 has been marked as a duplicate of this bug. ***

Comment 18

[Torben]

*** Bug 184668 has been marked as a duplicate of this bug. ***

Comment 19

[Torben]

*** Bug 187978 has been marked as a duplicate of this bug. ***

Comment 20

[Torben]

*** Bug 187681 has been marked as a duplicate of this bug. ***

Comment 21

[Torben]

*** Bug 187400 has been marked as a duplicate of this bug. ***

Comment 22

[Torben]

*** Bug 184110 has been marked as a duplicate of this bug. ***

Comment 23

[Frankie]

Thanks for marking my dupe, Torben. Another probable dupe is bug 185950.

Comment 24

[Frankie]

*** Bug 185950 has been marked as a duplicate of this bug. ***

Comment 25

[Torben]

This bug needs more attention, Mozilla cannot in practice be used as default
browser on macs because of this. Changing OS to MacOSX since nobody cares about
Mac classic anymore and requsting blocking for 1.3b.

Comment 26

[Asa Dotzler [:asa]]

We should definitely figure out if this can be fixed for beta. Saari, is this
something you can look into? If not then who?

Comment 27

[saari (gone)]

in dagley's absence, ->sfraser

Comment 28

[Simon Fraser [no longer active]]

Attachment: Patch to nsMacCommandLine to fix the problem

nsMacCommandLine::DispatchURLToNewBrowser was returning errAEEventNotHandled,
even if we did handle the event. The patch sets err to noErr if the
OpenWindow() call succeeds.

Comment 29

[Simon Fraser [no longer active]]

Comment on attachment 113047 [details] [diff] [review]
Patch to nsMacCommandLine to fix the problem

The file has tabs; I'll fix the spacing before checkin.

Comment 30

[Conrad Carlen (not reading bugmail)]

Comment on attachment 113047 [details] [diff] [review]
Patch to nsMacCommandLine to fix the problem

r=ccarlen

Comment 31

[jag (Peter Annema)]

Comment on attachment 113047 [details] [diff] [review]
Patch to nsMacCommandLine to fix the problem

sr=jag

Comment 32

[Asa Dotzler [:asa]]

Comment on attachment 113047 [details] [diff] [review]
Patch to nsMacCommandLine to fix the problem

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 33

[Frankie]

Yeeee hah! A big thank you to the Mozilla team for fixing this. As soon as the
patch goes live I'll start using nightlies again (I've been sticking with 1.2.1). 

Bug 184363 (Destroy All Tooltips, remake of an excellent B movie) is still a
pain, but I'll live with it.

Comment 34

[Asa Dotzler [:asa]]

Frankie, thanks for your offer for testing help. It is likely that this patch
will land today which means that tomorrow's builds should have the fix. If you
can get that build as soon as possible tomorrow, test this problem and report
back to this bug that would be a great help. (and that tooltip crasher is going
to be fixed shortly as well). 

Comment 35

[Simon Fraser [no longer active]]

Checked in.

Comment 36

[Frankie]

Sadly, the nightly latest Mac is still 20020122. No successful builds in over a
week?

Also, latest Macho 20020130 doesn't run for me, but that's probably because I
didn't RTFM.

Comment 37

[Simon Fraser [no longer active]]

This is your latest nightly:
ftp://ftp.mozilla.org/pub/mozilla/nightly/2003-01-31-03-trunk/mozilla-mac-MachO.dmg.gz

Comment 38

[Conrad Carlen (not reading bugmail)]

How come the "nightly" links on mozilla.org still point to CFM builds that
aren't even being built?

Comment 39

[J.J. Enser]

cfm bits have been renamed on moz.org. Asa and I are working on fixing the links
on the home page

Comment 40

[Frankie]

*** Bug 176124 has been marked as a duplicate of this bug. ***

Comment 41

[Tom Schneider]

Although I understand that this bug is resolved, I haven't tested it yet.
However I think it maybe useful to record an observation I just made about it.

After I have the repeating windows and kill Mozilla, the start up time
was terribly long.  I just discovered that Mozilla leaves huge files in
the cache, named _CACHE_001_*

Apparently handling these causes the startup to be slow, since when I deleted
them it started up very quickly.  (As an aside startup on a Sun is
terribly slow and so is window closing; if folks think this is a separate
bug I could report it as so.)

Comment 42

[Torben]

*** Bug 192883 has been marked as a duplicate of this bug. ***

Comment 43

[Greg K.]

*** Bug 192650 has been marked as a duplicate of this bug. ***

Comment 44

[Chris Casciano]

*** Bug 195474 has been marked as a duplicate of this bug. ***

Comment 45

[Frankie]

v