1814773 - Implement a basic SERP engagement event

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Comment 1

[James Teow [:jteow]]

Attachment: WIP: - Bug 1814773 - Implement a basic SERP engagement event - r?standard8

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1814773 - Implement a basic SERP engagement event - r?standard8,scunnane

Comment 3

[James Teow [:jteow]]

Attachment: data-request-bug-1814773.md

Comment 4

[Charlie Humphreys [:charlie] [:jeddai]]

Comment on attachment 9317751 [details]
data-request-bug-1814773.md

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, in the Glean dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, the standard opt-out settings found within Firefox.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Yes, [e-mail] as an individual, and [e-mail] and [e-mail] as teams.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Category 2, Interaction data

5. Is the data collection request for default-on or default-off?
   Default-on

6. Does the instrumentation include the addition of any new identifiers?
   No

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes

8. Does the data collection use a third-party collection tool?
   No

data-review+, assuming :jteow is comfortable with being the responsible individual, or a different individual is provided.

Comment 5

[James Teow [:jteow]]

Thanks for the review, :charlie.

I didn't realize that an individual also has to be responsible, but yes I'm comfortable with it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca4add39166f
Implement a basic SERP engagement event - r=Standard8

Comment 7

[James Teow [:jteow]]

Hey Cristian or Adrian, could you QA legacy SERP telemetry to ensure there are no regressions for ad impressions?

I had to make a minute tweak on how we store whether or not an ad was viewed for the purpose of the Glean telemetry epic. There shouldn't be any noticeable impact to our existing telemetry, especially to browser.search.withads. but we just want to make sure.

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ca4add39166f

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

Hey James, we'll add more tests to the nightly search regression to cover this in a more extensive manner. Will close this out once our testing session is over.

Comment 10

[Cristian Baica [:cbaica], Release Desktop QA]

Closing this as verified fixed as the latest nightly regression didn't uncover any irregularities with the 'withads' telemetry pings across 3 OSs and multiple search engines.
You can view the results here.

Comment 11

[James Teow [:jteow]]

Thank you very much Cristian.