1813162 - Implement the SERP impression event

Status: VERIFIED FIXED

(Firefox :: Search, enhancement, P1)

Comment 1

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1813162 - Implement the SERP impression event. r?Standard8

Comment 2

[Alessio Placitelli [:Dexter]]

Hey Stephanie!

Is this related to bug 1813162 et similar at all?

I ask because we're currently rolling out the other events to do a round of validation of the data. Regardless, given the expected volume for this, let's make sure to land this off / disabled by default so that we can roll it out according to these operational guidelines.

Do we need to validate this one as well?

Comment 3

[Mark Banner (:standard8)]

(In reply to Alessio Placitelli [:Dexter] from comment #2)

Is this related to bug 1813162 et similar at all?

I think that's the wrong bug number. However, I suspect you mean the address bar events and yes they're similar, probably a bit less frequent.

I ask because we're currently rolling out the other events to do a round of validation of the data. Regardless, given the expected volume for this, let's make sure to land this off / disabled by default so that we can roll it out according to these operational guidelines.

The patch has a preference in place to disable the event: https://phabricator.services.mozilla.com/D168172#change-5D4xp5p5yudd

There will be a series of bugs to build these events up before we get to enabling them, probably will take a couple of months. We're aware of the volume issues and we'll work out a roll-out plan based on the experiences with the address bar.

Do we need to validate this one as well?

We'll need to validate this once we get it built up and the other events ready as well.

Comment 4

[Alessio Placitelli [:Dexter]]

Thank you Mark! I also cleared this up with Chris Bellini and looks like this will follow these operational guidelines, so I'm not concerned. Thank you so much!

Comment 5

[Stephanie Cunnane [:scunnane]]

Attachment: data_review_request_bug_1813162.md

Comment 6

[Megan McCorquodale]

Comment on attachment 9315674 [details]
data_review_request_bug_1813162.md

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, this will be documented in the Glean dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, users can opt out of telemetry collection.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Yes, this will be monitored by the search team.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Category 2, interaction data.

5. Is the data collection request for default-on or default-off?
   Default on.

6. Does the instrumentation include the addition of any new identifiers?
   No new identifiers.

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes.

8. Does the data collection use a third-party collection tool?
   No.

---

data-review +

Comment 7

[Stephanie Cunnane [:scunnane]]

Great, thanks Megan - much appreciated.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d610bc570cd
Implement the SERP impression event. r=Standard8

Comment 9

[Marian-Vasile Laza]

Backed out changeset 7d610bc570cd (Bug 1813162) as requested by the dev, issue with the patch.
Backout Link

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d08db95f2d3
Implement the SERP impression event. r=Standard8

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4d08db95f2d3

Comment 12

[Cristian Baica [:cbaica], Release Desktop QA]

Closing this as verified fixed as part of the SERP telemetry phase 1 sign off.