Closed
Bug 1814991
Opened 3 years ago
Closed 3 years ago
[Tabs tray to Compose] Add page indicators and three dot button to Tabs Tray banner
Categories
(Firefox for Android :: Tabs, task, P2)
Tracking
()
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: 007, Assigned: 007)
References
Details
(Whiteboard: [fxdroid])
Attachments
(2 files)
Re-implement paging indicators so it's clear what page the user is on. In the present XML version, the UI lives across TabsTrayFragment, component_tabstray2.xml, TabCounterBinding, TabLayoutMediator, and SelectionBannerBinding.
As part of this ticket:
- The functionality of Normal/Private/Synced page indicators should be maintained
- Icon + active/inactive state coloring
- The normal tabs indicator should have the current tab count.
- Also add the three-dot menu icon with a placeholder action. (This will be completed in Bug 1816517, so simply add a placeholder click lambda for now).
- The click listener lambdas for the page indicators with the business logic plumbed-in.
- The drag indicator bar
component_tabstray2.handlein XML - The previews should be fully functioning, with the tab indicator correctly changing when its selected/unselected.
Dev notes
- Utilize
TabRow+Tabto implement the page indicators - Use an
IconButtonfor the three dot menu
| Assignee | ||
Updated•3 years ago
|
Priority: -- → P2
Whiteboard: [fxdroid]
Updated•3 years ago
|
| Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Severity: -- → N/A
| Assignee | ||
Updated•3 years ago
|
Assignee: nobody → nbond
| Assignee | ||
Updated•3 years ago
|
Summary: [Tabs tray to Compose] Add page indicators to Tabs Tray → [Tabs tray to Compose] Add page indicators and three dot button to Tabs Tray banner
| Assignee | ||
Comment 2•3 years ago
|
||
Note that the corners of the banner will only be rounded while in the half-expanded state. This matches the existing behavior in the XML version of the UI, but is also a restriction of the current BottomSheet code from Google.
Comment 3•3 years ago
|
||
Comment 4•3 years ago
|
||
Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/9c1a0dbba28d66e710ccd3f137fb873c179ab8c4
[main] Bug 1814991 - Implement Tabs Tray single select banner UI
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox113:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
| Assignee | ||
Updated•3 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•