Closed Bug 1814991 Opened 3 years ago Closed 3 years ago

[Tabs tray to Compose] Add page indicators and three dot button to Tabs Tray banner

Categories

(Firefox for Android :: Tabs, task, P2)

All
Android
task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: 007, Assigned: 007)

References

Details

(Whiteboard: [fxdroid])

Attachments

(2 files)

Re-implement paging indicators so it's clear what page the user is on. In the present XML version, the UI lives across TabsTrayFragment, component_tabstray2.xml, TabCounterBinding, TabLayoutMediator, and SelectionBannerBinding.

As part of this ticket:

  • The functionality of Normal/Private/Synced page indicators should be maintained
    • Icon + active/inactive state coloring
    • The normal tabs indicator should have the current tab count.
  • Also add the three-dot menu icon with a placeholder action. (This will be completed in Bug 1816517, so simply add a placeholder click lambda for now).
  • The click listener lambdas for the page indicators with the business logic plumbed-in.
  • The drag indicator bar component_tabstray2.handle in XML
  • The previews should be fully functioning, with the tab indicator correctly changing when its selected/unselected.

Dev notes

  • Utilize TabRow + Tab to implement the page indicators
  • Use an IconButton for the three dot menu

Up-to-date specs

Priority: -- → P2
Whiteboard: [fxdroid]
Depends on: 1814988
Blocks: 1816517
Blocks: 1816522
Depends on: 1816743
Severity: -- → N/A
Assignee: nobody → nbond
Summary: [Tabs tray to Compose] Add page indicators to Tabs Tray → [Tabs tray to Compose] Add page indicators and three dot button to Tabs Tray banner

Note that the corners of the banner will only be rounded while in the half-expanded state. This matches the existing behavior in the XML version of the UI, but is also a restriction of the current BottomSheet code from Google.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Flags: qe-verify+
See Also: → 1917146
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: