1815316 - Add additional metrics to Glean crash ping to reach parity with Telemetry

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Alex Franchuk [:afranchuk]]

This may necessitate new metrics types, e.g. for stack traces.

Comment 1

[Alex Franchuk [:afranchuk]]

There are many ways to organize the metrics. For instance, the platform-specific ones could all be under crash.<platform>. However, I don't see much practical advantage to that, since they are all optional anyway. Another option is to group all the boolean flags together in a labeled_boolean metric (just for the sake of reducing verbosity), however that has a disadvantage of not having separate descriptions for each flag. So for now I'm mostly keeping everything as separate metrics, one for each Telemetry metadata entry (though maybe a few of those are no longer needed?).

Comment 2

[Gabriele Svelto [:gsvelto]]

As a first step I'd say we could add the annotations that were in the legacy crash ping minus the stack traces - which are the biggest hurdle.

Comment 3

[Alex Franchuk [:afranchuk]]

Yeah I've essentially done that in my working copy. I'm currently missing stack traces, asyncShutdownTimeout, and the environment (which is a lot of info).

Comment 4

[Gabriele Svelto [:gsvelto]]

AFAIK the environment is important and it's one of the other sticky bits aside from the stack trace. Let's put that and the stack traces in separate bugs.

Comment 5

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1815316 - Fill out Glean crash pings with telemetry environment values r=gsvelto

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f9704b70a8a
Fill out Glean crash pings with telemetry environment values r=gsvelto

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out with Bug 1830098 for causing bustage on metrics.rs related to brokenAddBlockers.

• backout: https://hg.mozilla.org/integration/autoland/rev/5a1dc23c99121876b02c131fd208dd3fc5c1ab4b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f90352df3555
Fill out Glean crash pings with telemetry environment values r=gsvelto

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing BR bustages

Backout link

Push with failures

Failure log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3dd9989d9e6
Fill out Glean crash pings with telemetry environment values r=gsvelto

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f3dd9989d9e6