1815419 - Remove unnecessary use of Services.locale.appLocalesAsBCP47 from address book files

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[PS]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36

Steps to reproduce:

The use is not necessary or even undesired, see bug 1758739.

Comment 1

[PS]

Attachment: 1815419.patch

Most other code uses undefined as the first argument:
https://searchfox.org/comm-central/search?q=Services.intl.DateTimeFormat&path=&case=false&regexp=false

Looks like
https://searchfox.org/comm-central/rev/05c024a0e3e23602b52eac638565a2545a9d2ee8/mail/components/compose/content/MsgComposeCommands.js#7112
should also be changed and perhaps also
https://searchfox.org/comm-central/rev/05c024a0e3e23602b52eac638565a2545a9d2ee8/mail/components/customizableui/content/panelUI.js#883

Comment 2

[PS]

Attachment: 1815419-compose.patch

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9316301 [details] [diff] [review]
1815419.patch

Yeah, I think you're right.

Comment 4

[PS]

Maybe a limited try run just to be sure?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0fbc2a2ae92d
Remove unnecessary use of Services.locale.appLocalesAsBCP47 from address book files. r=darktrojan
https://hg.mozilla.org/comm-central/rev/e501bc90a85e
Remove unnecessary use of Services.locale.appLocaleAsBCP47 from compose. r=darktrojan