1815645 - Reimplement drag and drop of messages and folders

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Geoff Lankow (:darktrojan)]

Title says it all. This has not been implemented yet.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1815645 - Reimplement dragging messages from the thread pane. r=#thunderbird-reviewers

This is largely the same as the code removed here:
https://hg.mozilla.org/comm-central/diff/7ad0631d10830f02972932ff3957c88a3a8f3e5f/mail/base/content/msgMail3PaneWindow.js#l1.139

It should be enough to enable copying messages to the filesystem. The contents of the dataTransfer
object aren't exactly the same as before, I've removed some complexity, and for some reason
text/x-moz-message can't be used by the flavor data provider, so I've added text/plain.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1815645 - Reimplement dropping messages on folders. r=#thunderbird-front-end-reviewers

Comment 4

[Wayne Mery (:wsmwk)]

QA will want to look at this for functional and dataloss potential.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4203972669d2
Reimplement dragging messages from the thread pane. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/86981acac04c
Reimplement dropping messages on folders. r=freaktechnik

Comment 6

[Magnus Melin [:mkmelin]]

comm/mail/test/browser/tabmail/browser_dragndrop.js is now failing on mac

Comment 7

[Magnus Melin [:mkmelin]]

Ah, it was failing even before these two landed.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1815645 - Reimplement dragging and dropping folders. r=#thunderbird-front-end-reviewers

This is largely the same as the code removed here:
https://hg.mozilla.org/comm-central/diff/04a3e0133c3d6a8c4e670c6a8e9526b3600c33e7/mail/base/content/folderPane.js#l1.822

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8fec4cdfd92c
Reimplement dragging and dropping folders. r=aleca

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9317533 [details]
Bug 1815645 - Reimplement dragging and dropping folders. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): Supernova

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9317533 [details]
Bug 1815645 - Reimplement dragging and dropping folders. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 12

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #4)

QA will want to look at this for functional and dataloss potential.

Seems to work for basic cases.

Tested:

• drag single message into another folder (IMAP > IMAP, IMAP > local) -> OK
• drag multiple messages into another folder (IMAP > IMAP, IMAP > local) -> OK
• drag folder with multiple messages (IMAP > IMAP, IMAP > local) -> OK
• drag closed thread (IMAP > IMAP, IMAP > local) -> OK

Some buggy observations

• Some of these actions sometimes appeared to have significant delays of up to several seconds with only 2 small messages, then not
• All my Gmail Inbox subfolders (Friends & Family, Social Media, Work and custom folders) have weird order of columns: (starred, read) From (spam) Subject, Date. Thread missing, From shouldn't be there, Correspondents should afasik. Weirdly, we don't seem to have an action for restoring the default set?? Eventually I ended up with all small columns in front - Restore column order doesn't change that, which looks like a bug - filed Bug 1817867.
• Eventually appeared to have lost 1 message, but not exactly sure how. Maybe dragging (thread?) back from local Trash to Imap. Can't reproduce.
• After restarting Daily, the weird columns thing had also crawled into my IMAP inbox. Then checked and saw 99% CPU in Task manager for a sec before it went down, apparently from something unrelated like "Microsoft Text Input...". Now I have weird set of columns with weird order and I cannot change that, as columns also cannot be reordered yet.
• Also met Bug 1817871 on the way.

Comment 13

[Geoff Lankow (:darktrojan)]

Please land the last patch on beta.

Comment 14

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/e75b489e1595