1816081 - [macOS] Bookmark toolbar locks up if closing Firefox window while creating a new folder process is initiated

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Found in

• Firefox 110.0

Affected versions

• Firefox 110.0
• Firefox 111.0a1

Tested platforms

• Affected platforms: macOS 11.7.3
• Unaffected platforms: Windows, Ubuntu

Steps to reproduce

1. Launch Firefox
2. Right click on the bookmarks toolbar and select Add Folder
3. Click on X on the browser window
4. Open Firefox again from the dock
5. Try deleting any item in the bookmarks toolbar

Expected result

• Bookmarks toolbar doesn't lock up

Actual result

• The folder is created, the bookmarks toolbar is locked up, and the only thing that works is to create new folders (delete, copy, cut, paste doesn't work at all)

Regression range

• Mozregression pinpointed between 2021-04-14 and 2021-04-15 with this following pushlog as it wouldn't bisect any further unfortunately.

Additional notes

• The issue can be seen in the following attachment
• On the unaffected builds, the X button on the Firefox window is disabled when creating a new folder.
• The only workaround is to fully close Firefox and launch it again.

Comment 1

[:Gijs (he/him)]

I expect bug 1704616 regressed this, but that was a pref flip so really this probably regressed with bug 1693139 (with browser.proton.modals.enabled set to true, anyway).

Closing the parent window should close the dialog box and run that code. But because it's run from PlacesUIUtils and relies on promises generated inside the window, I bet bug 1674505 makes fixing this hard. :-(

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:mtigley, since you are the author of the regressor, bug 1693139, could you take a look?

For more information, please visit auto_nag documentation.

Comment 3

[Mark Banner (:standard8)]

This works for me on the latest nightly. I suspect the recent bookmarking dialog improvements helped this. Catalin, can you confirm this works for you now as well?

Comment 4

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Yep, this works for me as well on Firefox 115.0b9 on macOS 13.4.1. Will close it as WFM. Thank you!