Closed Bug 1816319 Opened 1 year ago Closed 1 year ago

[DNR] Add DYNAMIC_RULESET_ID and SESSION_RULESET_ID constants

Categories

(WebExtensions :: Request Handling, task)

task

Tracking

(firefox111 fixed)

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

While finalizing the review of the DNR API documentation for MDN (e.g. BCD), I noticed that while we do recognize the "_session" and "_dynamic" values as rulesetIds, we don't expose them as constants to the DNR namespace.

As there are no APIs that take these ruleset IDs, I don't see any issue with never defining them (e.g. Safari does not either), but since it's trivial to add them and they're part of the namespace defined in Chromium, let's do so.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/924b336b0cc6
Add DYNAMIC_RULESET_ID and SESSION_RULESET_ID constants r=rpl
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

I assume we need an update to the BCD?

Flags: needinfo?(rob)
Keywords: dev-doc-needed

We've already ensured that this entry is part of the BCD, at https://github.com/mdn/browser-compat-data/pull/18403

It currently lists Firefox as "unsupported", because we haven't added Firefox to any BCD entry yet. That is because the feature is disabled by default, behind a preference. When we ship (bug 1782685), we'll update the BCD entries.

Flags: needinfo?(rob)
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: