1816435 - Add various missing tests for unified toolbar

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, task)

Description

[Martin Giger [:freaktechnik]]

During the implementation of the unified toolbar the emphasis was on creating the new infrastructure, with tests often falling behind. This task will rectify this situation and ensure the unified toolbar is covered in tests wherever possible. A few spotlight areas that need tests:

• Most of the customization is untested. This includes the various customization verbs.
  • Needs tests around visibility of window features, so only customization and titlebar are visible
• All the widgets we show inside the toolbar are untested. We should have tests for every widget
• There were some bug fixes to tab hiding, we should test the fixed behavior
• We should have some large integration tests that test the behavior from customizing to add items to the toolbar changing based on the space to executing an action in the toolbar
• Tests that ensure window decorations are always visible

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1816435 - Add tests for unified toolbar modules. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e8e98650ec2c
Add tests for unified toolbar modules. r=mkmelin

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1816435 - Cover newer search-bar features with tests. r=#thunderbird-reviewers

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: Bug 1816435 - Complete unified-toolbar-tab test coverage. r=#thunderbird-reviewers

Depends on D170219

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/718849ed24fa
Cover newer search-bar features with tests. r=aleca
https://hg.mozilla.org/comm-central/rev/db14a1bb86d2
Complete unified-toolbar-tab test coverage. r=aleca

Comment 6

[Thomas D. (:thomas8)]

We have a bit of fuzzy overlap between the original, more technical bug 1737361 (sn-utb-rebuild) and the later, more UI/UX-focused bug 1811380 (sn-unifiedtoolbar). Our queries are unaware of bug 1737361, so this keeps showing up as orphaned. So for now, to make the queries happy, I'll just make this block bug 1811380, too.

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: WIP: Bug 1816435 - Add tests for unified-toolbar-button. r=#thunderbird-reviewers

Comment 8

[Martin Giger [:freaktechnik]]

Continuing this in bug 1841489

Comment 9

[Phabricator Automation]

Comment on attachment 9324816 [details]
WIP: Bug 1816435 - Add tests for unified-toolbar-button. r=#thunderbird-reviewers

Revision D173500 was moved to bug 1863749. Setting attachment 9324816 [details] to obsolete.