1816728 - Implement the ad impression event for the carousel

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Comment 1

[James Teow [:jteow]]

Attachment: WIP: - Bug 1816728 - Implement ad impression event for the carousel - r?standard8,scunnane

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1816728 - Add impression event for carousels - r?standard8,scunnane

Comment 3

[James Teow [:jteow]]

Attachment: Bug 1816728 - Add additional conditions on whether an ad is visible - r?standard8,scunnane

Depends on D171820

Comment 4

[James Teow [:jteow]]

Attachment: data-review-bug-1816728.md

Comment 5

[Travis Long [:travis_]]

Comment on attachment 9322995 [details]
data-review-bug-1816728.md

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the telemetry and data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent collection to be monitored over time by jteow

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

Yes, but impression-id is meant to identify the impression and not the user

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6de795a1c969
Add impression event for carousels - r=Standard8
https://hg.mozilla.org/integration/autoland/rev/61b5bdae971a
Add additional conditions on whether an ad is visible - r=Standard8

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6de795a1c969
https://hg.mozilla.org/mozilla-central/rev/61b5bdae971a