1817053 - Remove some dead icons from the translation project.

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Lots of the translation code is dead, but I want to get rid of -moz-image-region usage.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1817053 - Remove some dead CSS and icons from the old translations project. r=mconley

The Firefox Translation extension doesn't use these.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1817053 - Remove translation-notification.js and co completely. r=mconley

We don't even bundle the translationNotification.ftl in the jarfile, so
there's no way this has worked since the migration to fluent.

Just in case, I double-checked that the extension works with this patch.

Depends on D169991

Comment 3

[Greg Tatum [:gregtatum] (REO Fx132)]

We're actively working on this area, and have plans on removing this code. However, it's useful in the short term (in terms of a month or so). It'd be more useful to remove all the code on our own terms, but if it's blocking your project you could move forward with this.

This code area can run with browser.translation.ui.show, and it's useful as a reference implementation as we're building out new code.

I filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1817084

Comment 4

[Emilio Cobos Álvarez (:emilio)]

(In reply to Greg Tatum [:gregtatum] from comment #3)

We're actively working on this area, and have plans on removing this code. However, it's useful in the short term (in terms of a month or so). It'd be more useful to remove all the code on our own terms, but if it's blocking your project you could move forward with this.

At least something like https://phabricator.services.mozilla.com/D169992 I do need. The other one was mostly since I noticed we don't even bundle the ftl for that UI. I don't plan to touch anything else tho.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ce7e1331548
Remove some dead CSS and icons from the old translations project. r=mconley,gregtatum

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8ce7e1331548

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20fc5c1fcb87
Remove translation-notification.js and co completely. r=mconley,fluent-reviewers,gregtatum,flod

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/20fc5c1fcb87