1817084 - Remove old translations code

Status: RESOLVED FIXED

(Firefox :: Translations, task, P3)

Description

[Greg Tatum [:gregtatum] (REO Fx132)]

With the new implementation, that old code can go away. This bug is for tracking that. I'd like to keep it in for a bit until we get some of the prototypes more settled.

Comment 1

[Andre Natal]

Heads-up that the extension relies on some of that code, and if that gets removed, it would break it and leave users without any option if the integrated version is not being shipped yet.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I sent a patch removing some bits of UI in bug 1817053. I didn't touch anything else, but at least the first patch or something like that is needed to remove -moz-image-region (bug 1817071). I confirmed that the extension works just fine with those changes, is that all I need?

Comment 3

[Greg Tatum [:gregtatum] (REO Fx132)]

I discussed this with the team, and we're going to remove the code now, since there are two bugs touching the code now. We'll leave in the code the addon is relying on, and ensure that it works.

Comment 4

[Greg Tatum [:gregtatum] (REO Fx132)]

In order to remove CLD2, we'll need to migrate to the new fastText language detector, which the translations infrastructure will rely upon. This will involve a download for the first time it is run, since we don't ship with the wasm blob or language models. This could cause a behavior change, or for the language detection to fail if the download fails. I'm going to block on Bug 1818603 now since this touches the language identification code.

Here is a searchfox search of consumers.

• The extension API uses browser.i18n.detectLanguage.
• Reader mode uses it to detect the article language.

:zombie, :mixedpuppy As module owners of the web extensions, do you have any issues with me moving to use our new language detection library? It's using fastText, and should provide more accurate results. The trade off is that it requires a download upon the first use.

I'm not seeing code owners around a decision for Reader Mode, so I'll rely on my reviewer.

The downloads for fastText are a 875k wasm, and 938k language model.

Comment 5

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: WIP: Bug 1817084 - Remove CLD2; r?nordzilla

Comment 6

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: WIP: Bug 1817084 - Remove browser/components/translation; r?nordzilla

Depends on D171619

Comment 7

[Shane Caraveo (:mixedpuppy)]

This directly effects a public extension API. If an extension calls the api, that can be the trigger to download a couple MB. What happens if there is no network connection? Why isn't this being bundled by default and only downloading to update?

Comment 8

[Greg Tatum [:gregtatum] (REO Fx132)]

That's a good point, we'll need to compare the binary size of swapping out the two systems. We can package using this method: https://firefox-source-docs.mozilla.org/services/settings/index.html#packaging-attachments

I'll bring this up in our next engineering sync on this project.

Comment 9

[Greg Tatum [:gregtatum] (REO Fx132)]

I'm not actively working on this, and we need to figure out the CLD2 -> fast text transition in order for this to happen.

Comment 10

[Greg Tatum [:gregtatum] (REO Fx132)]

We should still do this, but I don't think it should be tied to the Desktop MVP launch.

Comment 11

[Mark Banner (:standard8)]

Could this be scheduled for early H2, as it blocks completing the esm-ification work?

Comment 12

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1817084 - Remove old translations code; r?nordzilla!

Comment 13

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1817084 - Remove now unused Http.sys.mjs; r?nordzilla!

The old translations code was the last consumer of this code.

Depends on D181700

Comment 14

[Greg Tatum [:gregtatum] (REO Fx132)]

We're keeping CLD2 for now, but removing the old translations code.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aa536206a69
Remove old translations code; r=settings-reviewers,fluent-reviewers,nordzilla,mconley,flod
https://hg.mozilla.org/integration/autoland/rev/c7677f0d1451
Remove now unused Http.sys.mjs; r=nordzilla

Comment 16

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8aa536206a69
https://hg.mozilla.org/mozilla-central/rev/c7677f0d1451