Sometimes provider = UrlbarProviderContextualSearch returns an unknown result type
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox112 | --- | verified |
People
(Reporter: mak, Assigned: daisuke)
References
Details
Attachments
(1 file)
it looks like some of the results from UrlbarProviderContextualSearch may get an unknown result type
Assignee | ||
Updated•1 year ago
|
Comment hidden (spam) |
Assignee | ||
Comment 2•1 year ago
•
|
||
Thank you very much, Marco.
I investigated a bit. The type of result is dynamic, but we had not corresponded to this provider.
https://searchfox.org/mozilla-central/rev/3067ba33c2202459aae52b7a0f7218a71fe5f7c3/browser/components/urlbar/UrlbarUtils.sys.mjs#1315-1325
To resolve it, I will introduce contextual_search
.
And also, we don't cover the following providers as well.
- UrlbarProviderWeather: https://searchfox.org/mozilla-central/rev/3067ba33c2202459aae52b7a0f7218a71fe5f7c3/browser/components/urlbar/UrlbarProviderWeather.sys.mjs#235
- UrlbarProviderExtension https://searchfox.org/mozilla-central/rev/3067ba33c2202459aae52b7a0f7218a71fe5f7c3/browser/components/urlbar/UrlbarProviderExtension.sys.mjs#374,397
I will fix them in a follow-up.
Assignee | ||
Comment 3•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d16bbecf6a0 Introduce site_specific_contextual_search in the result type r=mak
Comment 5•1 year ago
|
||
bugherder |
Comment 6•1 year ago
|
||
Hey Marco,
Could you please help us out with some steps in order to verify this?
Reporter | ||
Comment 7•1 year ago
|
||
(In reply to Cristian Baica [:cbaica], Release Desktop QA from comment #6)
Hey Marco,
Could you please help us out with some steps in order to verify this?
Sure, you need the browser.urlbar.contextualSearch.enabled pref set to true, that feature is experimental and not enabled by default. It is a site specific search feature that has been backported from FlowState.
I think (though didn't participate to development) the idea is that if you are on a site providing an opensearch engine, and you type a string in the urlbar, you should get a special result in the urlbar that allows you to search that string on the page.
It was implemented in Bug 1794823
The result type in telemetry should be "site_specific_contextual_search"
Comment 8•1 year ago
|
||
The issue is verified fixed in the latest Fx 112.0a1 on Window 10 and Ubuntu 22.04. Setting the pref Marco mentioned correctly triggers the "site_specific_contextual_search" for impression, engagement and abandonment pings, results section. Also for the engagement ping, the provider listed is "UrlbarProviderContextualSearch".
Description
•