1818685 - Disable video overlay if mVideoSwapChain->Present() is very slow on Windows

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Video swap chain always use double buffering in DCSurfaceVideo::CreateVideoSwapChain() . It seems better to enable triple buffering.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1818685 - Use triple buffering for video swap chain of video overlay on Window

Comment 2

[Kelsey Gilbert [:jgilbert]]

Can you go into more detail why?

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Kelsey Gilbert [:jgilbert] from comment #2)

Can you go into more detail why?

There is a case that wait happens at mVideoSwapChain->Present(0, 0);

See https://bugzilla.mozilla.org/show_bug.cgi?id=1792015#c27

I wonder if the wait might be related to a lot of tiles usage in DCLayerTree.

Comment 4

[Sotaro Ikeda [:sotaro]]

I reconsidered about it, it might be better to disable video overlay when the wait at present() is detected.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1818685 - Disable video overlay if mVideoSwapChain->Present() is very slow on Windows

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5b7cc9e8fca
Disable video overlay if mVideoSwapChain->Present() is very slow on Windows r=gfx-reviewers,lsalzman

Comment 7

[Sotaro Ikeda [:sotaro]]

By Bug 1793388, the wait was moved from RenderCompositorANGLE::WaitForGPU() to mVideoSwapChain->Present().

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/c5b7cc9e8fca