Closed Bug 1818994 Opened 3 years ago Closed 1 month ago

Fix and re-enable browser_test_focus_urlbar.js on Windows

Categories

(Firefox :: Address Bar, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: RyanVM, Unassigned)

References

Details

(Whiteboard: [sng-dragon])

Over in bug 1784752, I mistakenly thought that browser_test_panel.js was hitting vsync-related failures. However, after disabling that test in Try runs, the failures simply moved to the next test in the manifest.

It turns out that the real problem is with browser_test_focus_urlbar.js and whatever test that runs after it hitting the vsync-related failures. I was seeing these on Try as part of a patch I was putting together to re-enable some tests which are passing and clean up the manifests. When I disabled browser_test_focus_urlbar.js, all of the failures in the later tests went away.

Severity: -- → S3
Duplicate of this bug: 1492259
No longer blocks: 1782783
Depends on: 1551598
See Also: → 1782783, 1708336
Depends on: 1331755

browser_test_focus_urlbar.js is still skipped on Windows here, but a new sibling test that runs before it in the same manifest (browser_test_focus_searchbar.js, bug 2023143) is green on Windows: https://treeherder.mozilla.org/jobs?repo=try&revision=9646fdf49f6728b01749350d6c01a65d78aee455 — full mochitest-browser-a11y suite, windows11-64-25h2 and windows11-32-25h2, opt and debug. Might be worth retrying the urlbar test's skip-if.

Component: Disability Access APIs → Address Bar
Product: Core → Firefox
Whiteboard: [sng]
Depends on: 2023143
Priority: -- → P3
Whiteboard: [sng] → [sng-dragon]

The last skip-if annotation referencing this bug was removed in bug 2078158, as the test now passes on try in the configurations it covered.

Closing as WORKSFORME; feel free to reopen if the bug is still relevant without any specific test pointing to it.

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.