1819137 - Don't load messages when the ArrowDown key is pressed and held

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Alessandro Castellani [:aleca]]

When pressing and holding down the ArrowDown key, the selection moves across messages.
For every selected messages the Message Pane is updated to show the currently selected message.

That's not really useful and it affects the speed of switching between messages. We should avoid that, mimicking what happens in 102, and only load the message on key release.

Bonus issue: The focus sometimes it's lost when quickly switching messages with the arrow keys, sometimes it's captured by the message pane or sometimes the focus moves to the entire body.

Comment 1

[Wayne Mery (:wsmwk)]

Good catch.
If this is really 102 parity, then it's a regression => defect ;) (and true for other regressions as well)

FWIW, for N/B navigation there is a preference which sets the delay for message display. I wonder if that is similarly impacted.

Comment 2

[Wayne Mery (:wsmwk)]

Found what I was looking for. Navigation should be subject to the preference

mailnews . threadpane_select_delay Integer 250 (default): To improve scrolling performance, prevents immediate display of message when scrolling through threadpane.

Comment 3

[Alessandro Castellani [:aleca]]

Nice, good catch!
I'm gonna try to tackle this

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: Bug 1819137 - Re implement the `mailnews.threadpane_select_delay` preference to delay the message selection on keypress. r=darktrojan

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/07c6dab1afa6
Re implement the mailnews.threadpane_select_delay preference to delay the message selection on keypress. r=darktrojan

Comment 6

[Magnus Melin [:mkmelin]]

This is breaking comm/mail/components/addrbook/test/browser/browser_display_card.js

Comment 7

[Magnus Melin [:mkmelin]]

Backout: https://hg.mozilla.org/comm-central/rev/ff6861650d90d07b769c2e48a968a0cf06c220f5

Comment 8

[Alessandro Castellani [:aleca]]

New try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=ffd510a0eab6013574c6017095d024d1f99afaeb

Comment 9

[Alessandro Castellani [:aleca]]

All failures reported are also on comm-central.
Let's try to land this and see if I break something else.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/48ffe8abfef4
Re implement the mailnews.threadpane_select_delay preference to delay the message selection on keypress. r=darktrojan

Comment 11

[Alessandro Castellani [:aleca]]

Attachment: Bug 1819137 - Fix broken tests after select delay. r=#thunderbird-reviewers

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/190fcdf57464
Fix broken tests after select delay. r=elizabeth

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9325314 [details]
Bug 1819137 - Fix broken tests after select delay. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9324585 [details]
Bug 1819137 - Re implement the mailnews.threadpane_select_delay preference to delay the message selection on keypress. r=darktrojan

[Triage Comment]
Approved for beta

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 112.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/2b7bf72e0b49
https://hg.mozilla.org/releases/comm-beta/rev/4803d4ec06ea

Comment 16

[Wayne Mery (:wsmwk)]

Working well in in 112.0b5 and daily.
Thanks.