1819291 - `Escape` key does not dismiss Quick Filter Bar after ctrl+shift+K or [≡ >] View > Toolbars > Quick Filter Bar

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Wayne Mery (:wsmwk)]

1. Do ctrl+shift+K or [≡ >] View > Toolbars > Quick Filter Bar
2. hit escape key

Actual result: Quick Filter Bar is still there
Expected result: QFB is gone

Escape does dismiss QFB if you first click in the filter field

Comment 1

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #0)

1. Do ctrl+shift+K or [≡ >] View > Toolbars > Quick Filter Bar
2. hit escape key

Actual result: Quick Filter Bar is still there

Confirming on 112.0a1 (2023-03-01) (64-bit), Win10, but only when one of the menus is used, wfm when using shortcut Ctrl+Shift+K.
Note that you might need to press Esc key more than once if there's any search text or other quick filters set.
I would almost accept this as a feature (Bug 928365). When you explicitly show the QFB via menus, it will stay even when pressing Esc (so you need to use the menu to hide it again). When you use the shortcut to show it up, it will go away. Nice, kind of :-))

Comment 2

[Calum Mackay]

Yup, I find first Esc clears the text in the QFB, second Esc closes the bar. If there is no text in the QFB, first Esc closes it.

That seems reasonable behaviour to me.

Daily 0307, MacOS 13.2.1

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1819291 - Stop using a command to hide the Quick Filter bar. r=#thunderbird-front-end-reviewers

Instead, use an event listener directly in about:3pane and hide the bar if and only if it or the thread tree is focused.

Comment 4

[Thomas D. (:thomas8)]

(In reply to Geoff Lankow (:darktrojan) from comment #3)

Created attachment 9329209 [details]
Bug 1819291 - Stop using a command to hide the Quick Filter bar. r=#thunderbird-front-end-reviewers

Instead, use an event listener directly in about:3pane and hide the bar if and only if it or the thread tree is focused.

In TB 102, pressing Esc with focus anywhere in the main 3-pane window will iterate to remove any quick filters and ultimately hide the bar. This looks useful especially for focus in QFB, folder pane (e.g. with sticky quick filter), message list, and message reader. Can we try to retain that ux-efficiency/flexibility?

Comment 5

[Geoff Lankow (:darktrojan)]

I'm not really a big fan of that, but I suppose it is how Ctrl+A works, so we might as well be consistent.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d76f102e842
Stop using a command to hide the Quick Filter bar. r=aleca

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9329209 [details]
Bug 1819291 - Stop using a command to hide the Quick Filter bar. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 113.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/7184ffa56acb