1819572 - Ctrl+Shift+Click select/deselect in message list doesn't work on 111.0b1

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Peter Gordon]

Steps to reproduce:

On versions prior to Beta 111, you could Ctrl+Click some emails in a list view, then with ctrl still held down you could click the top of a range of emails, then additionally hold down shift (with ctrl still held), and click the bottom of the range of emails to add them to the selection.

Actual results:

With Beta 111, when you try and add a range of emails to some already selected emails by Ctrl+Shift+Clicking the top and bottom of the range, instead of adding the range of emails to the selected set of emails, it just defocuses the list view.

Expected results:

The previously ctrl clicked emails would stay selected, and additionally the ctrl+shift clicked range of emails would be added to the selection.

Comment 1

[PS]

Yes, that's also not working in the folder pane, see bug 1817605.

Comment 3

[Peter Gordon]

Not sure this is a duplicate of 1817605; that bug refers to not being able to multiselect folders at all.

This is a more subtle corner case in the message list (you can multiselect messages, you can even shift+click a range then add more with ctrl+click, but the specific case detailed above doesn't work).

Comment 4

[Magnus Melin [:mkmelin]]

Agreed it's a bit different.

Comment 5

[Alessandro Castellani [:aleca]]

This is both a bug and also a potential strange UX behaviour inherited from years prior.

Usually, per standard UX paradigm:

• holding CTRL adds to/removes from the current selection
• holding SHIFT selects a range from the previously clicked and focused item

Using CTRL+SHIFT together sounds a bit foreign. Do you have any other application examples, or file finder from an operating system, that supports this extra paradigm?

Nonetheless, the current version completely loses the focus when that modifier combination is used, which is bad and it should be fixed

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: Bug 1819572 - Allow range selection even if CTRL is held, and prevent message list focus loss. r=darktrojan

Comment 7

[Alessandro Castellani [:aleca]]

try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=d04b31b4f7fe5cf70f2f1db299f36c7d1bf0cdde

Comment 8

[PS]

Do you have any other application examples, or file finder from an operating system, that supports this extra paradigm?

In the Windows file manager (Windows Explorer or any "replacement product" like Total/Double/One Commander) and in TB 102 you can combine CTRL and SHIFT to select multiple ranges. Imagine you have 10 files or messages. Click the last one, then shift-click the 6th file/message: Result: last five selected. Then control-click the first one, then control+shift-click the third one. Result: 1-3 and 6-10 selected. If you just shift-click the 3rd one, you only get 1-3 selected.

Note that instead of clicking, you can also use the arrow keys why holding down SHIFT or SHIFT+CTRL (see bug 1817605 comment #0).

Comment 9

[Peter Gordon]

Attachment: Video showing Ctrl+Shift selection of second range in Windows Explorer

Please see the attached clip where I use the paradigm in Windows Explorer.

I click the top of the first range, then shift click to select the first range.

I then ctrl click the first email of a second range to add it to the current selection.

If, at this point, I now shift clicked the bottom of the second range, we would lose the current selection (Ctrl means keep current selection).

So, I Ctrl+Shift click the bottom of the second range to add it to the selection.

Comment 10

[Peter Gordon]

(Obviously where I say email in the previous comment, I mean file in this context)

Comment 11

[Alessandro Castellani [:aleca]]

This patch will bring feature parity with 102 in terms of keyboard selection behaviour, as well as improving a couple of things on macOS

Comment 12

[[e-mail]]

I'm removing checkin needed because the patch has caused some test failures that will need to be addressed

https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=265e20717398d7f110d2291a98992844c9151385&selectedTaskRun=dlVm3HttRzilMoTqG75xjA.0

Comment 13

[Alessandro Castellani [:aleca]]

Argh, we got the "mail.advance_on_spacebar" preference interfering

Comment 14

[Alessandro Castellani [:aleca]]

Let's see if this is good: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=0638bf4a54c7b8201f08ccb7e6413b26c3f48873

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d133c0d09561
Allow range selection even if CTRL is held, and prevent message list focus loss. r=darktrojan

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9322530 [details]
Bug 1819572 - Allow range selection even if CTRL is held, and prevent message list focus loss. r=darktrojan

[Triage Comment]
Approved for beta

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 112.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/04294dc6efb6

Comment 18

[Peter Gordon]

Fix confirmed. Thank you!