1819713 - Remove PublicKeyCredential::IsExternalCTAP2SecurityKeySupported

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, task, P3)

Description

[John Schanck [:jschanck]]

Once CTAP2 support is available on all platforms, we can remove the non-standard PublicKeyCredential::IsExternalCTAP2SecurityKeySupported method from Bug 1526023.

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1819713 - remove PublicKeyCredential::IsExternalCTAP2SecurityKeySupported. r=keeler

Telemetry shows no use of this method since it was deprecated in 121.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a4086f45142
remove PublicKeyCredential::IsExternalCTAP2SecurityKeySupported. r=keeler,webidl,smaug

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on test_webauthn_isexternalctap2securitykeysupported.html

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7253f658c6d
remove PublicKeyCredential::IsExternalCTAP2SecurityKeySupported. r=keeler,webidl,smaug

Comment 5

[Tom Schuster (MoCo)]

Hi! There are other files that reference https://searchfox.org/mozilla-central/search?q=IsExternalCTAP2SecurityKeySupported shouldn't those be cleaned up, too?

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a7253f658c6d

Comment 7

[John Schanck [:jschanck]]

Ah, yes, I missed those. Thanks.

Comment 8

[John Schanck [:jschanck]]

Attachment: Bug 1819713 - remove stray references to IsExternalCTAP2SecurityKeySupported. r=tschuster

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1273b0849db2
remove stray references to IsExternalCTAP2SecurityKeySupported. r=tschuster

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1273b0849db2