Webpage "save as, complete" retry should retry as complete, not HTML only
Categories
(Firefox :: Downloads Panel, defect, P3)
Tracking
()
People
(Reporter: CoWindler02, Unassigned)
References
(Depends on 1 open bug)
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0
Steps to reproduce:
Firefox (currently 110.0.1) has many problems with saving modern webpages, causing missing pictures.
The most annoying flaw is that saving a page with much embedded content (ads etc.) falsely displays at the download icon a small orange arrow, despite the downloaded page usually works ok.
Much worse is because this arrow normally indicates a failed download, it encourages the user to click in the download menu the circular arrow next to that page name to redownload it, which (despite this makes the arrow go away!) makes it worse! I.e. it will replace the correct HTML file of the page with a faulty version (identical with "Web page, HTML only") that can not display the downloaded pictures from its "-files" directory anymore, because it is the original HTML page source without modified links pointing to it.
The fact that naturally clicking redownload because of arrow makes it worse is counter-intuitive and very confusing to novices. Please prevent the orange arrow when saving as "Web page, complete" (unless it really failed to write the HTML file), or at least do not turn the redownload into the original HTML version of the page.
If the arrow was meant to inform about an "inaccurate" download (e.g. missing an embedded part), give it a different colour and display a message when the user clicks redownload in the download manager or its dropdown menu.
example: https://www.monopol-magazin.de/11-kunstfilme-die-sich-im-maerz-lohnen
Actual results:
After saving complete page, false orange arrow lead user to click on redownload, which overwrites the correct with a faulty HTML page.
Expected results:
Show no orange arrow, or clicking redownload should display an info message instead.
|
||
Comment 1•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 2•2 years ago
|
||
The cause of the failure (that causes us to show an error state) is variously tracked in:
The issue with save page overwriting was also identified in bug 1806998 but I don't see that we've filed a dedicated bug to address it, so this bug can be it, I guess.
Whether the page before the retry is usable depends on how far we got into the page before hitting a failing download (due to the first 4 bugs I just cited).
|
Reporter | |
Comment 3•2 years ago
|
||
I am aware that the orange arrow is related to adblockers, causing parts of the webpage remaining unsaved. But this is IMO desired behaviour of an adblocker and not a bug, since normally the user does not want to keep the ads anyway, else he could temporary disable the adblocker.
So it would be appropriate to make the arrow in a different colour than orange, and add an info message (e.g. bubble help) like "Some webpage parts were not saved. (Disable adblockers if you need them.)"
Never the less, clicking the circular arrow should never overwrite the already saved part with a "HTML only" version, which is definitely unwanted behaviour and very confusing.
|
||
Comment 4•1 year ago
|
||
I came here to report the same bug. Disappointing that it appears to have been ignored for 7 months. Actually the bug was reported 13 years ago but resolved as incomplete: https://bugzilla.mozilla.org/show_bug.cgi?id=591860
That the save is reported as "failed" with no indication of which part(s) of the save failed (in my case, files not saved due to the DuckDuckGo Privacy Essentials extension) is annoying. That isn't a failed save, it's doing exactly what I want! But I can live with it.
The main point is that "retry" does not in fact retry.
ACTUAL BEHAVIOR:
"Retry" after failed "Save Page, Complete" causes Firefox to do a "Save Page, HTML Only"
EXPECTED BEHAVIOR:
"Retry" should cause Firefox to attempt to retry "Save Page, Complete", or at least retry the files thought to have failed.
Description
•