1820192 - Add a hint to dev console about a resource is blocked by ORB

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P2)

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1820192 - Add a hint of ORB blocking to developer console r=farre,smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfd94e0db902
Add a hint of ORB blocking to developer console r=smaug

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dfd94e0db902

Comment 4

[Sean Feng [:sefeng]]

Comment on attachment 9322395 [details]
Bug 1820192 - Add a hint of ORB blocking to developer console r=farre,smaug

Beta/Release Uplift Approval Request

• User impact if declined: No user impact. This patch just adds a new message to the developer console.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch doesn't change any behaviours for users.
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9322395 [details]
Bug 1820192 - Add a hint of ORB blocking to developer console r=farre,smaug

Approved for 112.0b2

Comment 6

[Dianna Smith [:diannaS]]

:flod, this includes changes to netwerk/locales/en-US/necko.properties which requires your approval.
do you mind taking a look for today's beta?

Comment 7

[Francesco Lodolo [:flod]]

From a localization perspective, we shouldn't be uplifting patches with strings unless there is a very good reason.
I don't see an explanation in the uplift request, on top of missing a mention of the string added.

With that said, it's a RelMan decision. My advice would be to let this patch ride the trains, given it's an S3 bug.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

It's part of a story of https://bugzilla.mozilla.org/show_bug.cgi?id=1821682
We've had ORB completed and enabled on nightly for weeks, however we haven't received any webcompat reports, which is a bit inconsistent with the telemetry data. Telemetry shows 4.5% usage is blocked by ORB, which hints high webcompat risks. Therefore, having the feature and more logs in early beta is very helpful.

As of the importance and urgency, ORB is the remaining blocker of spectre-mitigation removal, which will have significant performance win for the platform OKR.

Comment 9

[Sean Feng [:sefeng]]

Yeah, because we figured this bug is a prerequisite of uplifting bug 1821682 because we'd like users have better knowledge about requests blocked by ORB.

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/77489c735684

Comment 11

[Dianna Smith [:diannaS]]

This is now approved and will make it to today's beta 112.0b2 (early beta by bug 1821682).

However, I do want to call out for next time, that when String/l10n changes are involved we do have a String Freeze for each release ( in this case March 10th) to avoid these changes being made after Code Freeze. It is also very important to call out specifics in the uplift request (the string added, reasoning, urgency, etc) to make the uplift/decision process smoother.

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thank you Dianna and flod. It's good to learn the comment and the process on String part. Will do for the next time. :)