1820203 - Cannot close Calendar Event Notification dialog (the dialog no longer have the normal window controls)

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Kai Engert [:KaiE:]]

Thunderbird Daily:

I was reminded about a calendar event. The dialog had buttons to dismiss the events. But the dialog had just a plain border, there were none of the usual default window controls to close the dialog.

When I pressed Alt-F4 for fun the whole Thunderbird application quit.

Expected: Allow me to close that popup window.

Comment 1

[Magnus Melin [:mkmelin]]

I can confirm. No window controls or normal window top at all on that dialog on daily.
STR: create an event with reminder and wait for the reminder to pop up. The reminder "window" doesn't look like a window at all.
Alice, could you check what regressed this?

Comment 2

[Alice0775 White]

Attachment: screenshot: latest daily112.0a1 windows10

WFM on Thunderbird Daily 112.0a1 (BuildID=20230305102634).

Comment 3

[msangjunboon2018]

???

Comment 4

[Magnus Melin [:mkmelin]]

Strange, I still see it on linux. Maybe something to do the desktop environment then.

Comment 5

[Magnus Melin [:mkmelin]]

For clarity, the green window bar in the screenshot is missing for me.

Comment 6

[Alice0775 White]

Attachment: screenshot: 112.0a1 Windows11(VMWare guest)

Hum, I cannot reproduce the issue on Windows11 too....

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: no window controls screenshot

Here's what I'm seeing

Comment 8

[Alice0775 White]

Finally, I was able to reproduce this issue on Ubuntu20.04(VMWare guest).
So, this seems to be linux only problem.

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=2c41c52ca7ccbfe13d1af58a482271ace0f7e45f&tochange=83d14f11a010932a168f25488e794ad5c6f17d12
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bc3bdd8c19f8474d702689e870db815199d70e9e&tochange=0e5bee0c373f5fe88ef77226c212242f683b1db8

Suspect: Bug 1794577. Tentatively, mark this as regressor.

Comment 10

[Kai Engert [:KaiE:]]

At least for me, I found a workaround.
That notification is an independent window with its own entry in my task bar.
That means I can click that task bar entry to minimize/hide the window.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

How is this window open?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

We're probably hitting this case but seems like you're opening a popup and expect it to be decorated which is really weird. Would be better to open it as a toplevel window or so?

Comment 13

[Magnus Melin [:mkmelin]]

It's calendar-alarm-dialog.xhtml.
You can reproduce the error by running

Services.ww.openWindow(
        null,
        "chrome://calendar/content/calendar-alarm-dialog.xhtml",
        "_blank",
        "chrome,dialog=yes,all,resizable",
        this
      );

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Bug 1823350 will likely fix this.

Comment 16

[Magnus Melin [:mkmelin]]

Bug still present after bug Bug 1823350. (I think not wayland?)

Comment 17

[Magnus Melin [:mkmelin]]

Passing null instead of "this" for the last argument (comment 13) makes the controls show up. Though I'd think there is still a bug here.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1820203 - Don't consider dialogs with BorderStyle::{Default,All} as undecorated. r=stransky

Bug 1794577 made this visible but the bug was really introduced in
bug 1816436.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c4935fbf3a5
Don't consider dialogs with BorderStyle::{Default,All} as undecorated. r=stransky

Comment 20

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5c4935fbf3a5