1823636 - XUL Toolbar Customize dialog has no titlebar on Linux

Status: RESOLVED DUPLICATE of bug 1820203

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: screenshot.png

The customize dialog for old XUL toolbars has lost its titlebar on Linux.

Regression range: Regression range on Linux: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=2c41c52ca7ccbfe13d1af58a482271ace0f7e45f&tochange=83d14f11a010932a168f25488e794ad5c6f17d12

Comment 1

[Martin Giger [:freaktechnik]]

This also affects the calendar reminders dialog.

Comment 2

[Alessandro Castellani [:aleca]]

Gentle ping to Emilio to see if he has any insight on this.
Maybe related to some window changes in m-c?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

How is this window opened? bug 1823350 might have affected this?

Comment 4

[Martin Giger [:freaktechnik]]

This one is opened here: https://searchfox.org/comm-central/rev/ffca7da7ce1f80465e21cafb0b950e5d96626305/mail/base/content/mailCore.js#234-240

The calendar one I mentioned is this I think: https://searchfox.org/comm-central/rev/ffca7da7ce1f80465e21cafb0b950e5d96626305/calendar/base/src/CalAlarmMonitor.jsm#141-147 (pointed to the wrong one before)

Comment 5

[Martin Giger [:freaktechnik]]

I also ran mozregression for the calendar alarms dialog with by running essentially the call I highlighted on phab in the previous comment and it comes to the same regression range.

Comment 6

[Magnus Melin [:mkmelin]]

(In reply to Martin Giger [:freaktechnik] from comment #1)

This also affects the calendar reminders dialog.

Bug 1820203.

Comment 7

[Thomas D. (:thomas8)]

(In reply to Magnus Melin [:mkmelin] from comment #6)

Bug 1820203.

Looks like a duplicate of Bug 1820203. Anyone who agrees?

Caller here of comment 4 has all parameter, that's exactly what the m-c patch in
https://hg.mozilla.org/mozilla-central/rev/5c4935fbf3a5 seems to fix:
+ mBorderStyle != BorderStyle::All &&

Comment 8

[Thomas D. (:thomas8)]

(In reply to Thomas D. (:thomas8) from comment #7)

(In reply to Magnus Melin [:mkmelin] from comment #6)

Bug 1820203.

Looks like a duplicate of Bug 1820203. Anyone who agrees?

Yes, confirmed/tested by Richard (:Paenglab), thanks!