1820596 - Troubleshooting Information "Copy text to clipboard" doesn't work

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[raal]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Open Help > Troubleshooting Information
Click button Copy text to clipboard

User Agent Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/112.0 Thunderbird/112.0a1
OS Linux 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023

Actual results:

nothing copied to clipboard (clipboard is cleared, so TB is trying to do something)

Expected results:

Informations in clipboard

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=be101f0a689485a7b8b5e4d688c6489035959568&tochange=ec66e789a69e5aab9f9d2a5266f93f1dcff76dba
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3387e4f266f095d429421e49529dd54c68262f62&tochange=20512741e7b60f3f6791002d8311d681f9242e68

Suspect: Bug 1776879. Tentatively, mark it as regressed by.

Comment 2

[Wayne Mery (:wsmwk)]

This WFM on Mac using Thunderbird 111.0b3 and nightly 2023-03-13

Raal, please retest with current nightly. If it fails, then maybe this is linux only

Comment 3

[Rob Lemley [:rjl]]

I'll confirm that "Copy to Clipboard" does not work with Daily (2023-03-14) on Linux w/ GNOME and Wayland. I did not see any errors in the jsconsole.

Comment 4

[Alice0775 White]

I can also reproduce the issue on Daily113.0a1 build id20230314105933 Windows10.

Comment 5

[raal]

(In reply to Wayne Mery (:wsmwk) from comment #2)

This WFM on Mac using Thunderbird 111.0b3 and nightly 2023-03-13

Raal, please retest with current nightly. If it fails, then maybe this is linux only

Still doesn't works
Name Thunderbird
Version 113.0a1
Build ID 20230314105933

Comment 6

[Rob Lemley [:rjl]]

It looks like we need to port bug 1776879. Change "text/unicode" to "text/plain" in the TransferData calls.

Comment 7

[Rob Lemley [:rjl]]

Attachment: Bug 1820596 - Port bug 1776879: Replace text/unicode for clipboard and drag and drop and use text/plain directly. r=#thunderbird-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e836da65e651
Port bug 1776879: Replace text/unicode for clipboard and drag and drop and use text/plain directly. r=leftmostcat

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9323041 [details]
Bug 1820596 - Port bug 1776879: Replace text/unicode for clipboard and drag and drop and use text/plain directly. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1776879
User impact if declined: Copy to clipboard button in about:support fails
Testing completed (on c-c, etc.): confirmed fixed on Daily
Risk to taking this patch (and alternatives if risky):
medium to high -- the fix involved touching every instance of clipboard and dragdrop transferstreams (or something like that) -- it did follow what upstream did, but random drag/drop stuff could be affected if i goofed

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9323041 [details]
Bug 1820596 - Port bug 1776879: Replace text/unicode for clipboard and drag and drop and use text/plain directly. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 112.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/5d0ae915df80