1821667 - Search box in global search results has broken icon

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB Search filed is duplicated and misplaced in search result.jpeg

STR:

1. make and validate a search

Actual results:

1. Search filed is duplicated in search results page
2. Unified toolbar search field is empty (with Searchgrayed)
3. The duplicated search field in results page is filled wirth the search keywords
4. A big loop is shown behind that search field

Expected results:

• The only search field exposed in the UI should be the new unified toolbar one

This is a regression with build 20230309233507 and it seems to me it was working with yesterday build.

Again a flexbox issue ?

Comment 1

[Martin Giger [:freaktechnik]]

The search icon being behind the input is probably a regression from the flexbox changes, since the regression range is https://hg.mozilla.org/comm-central/pushloghtml?fromchange=2f4d4c01703d348bf6cc3ab3412c5d23bc7c577a&tochange=68b4f9618db5609ea64da1b37bc08175a77fc1a6

In regards to having two search bars, that was an decision we made while implementing the new global search bar, to have both of them visible for now. So the global search bar always starts a new search, while the search bar within the tab lets you change your current search.

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1821667 - Fix search icon in global search results bar. r=#thunderbird-front-end-reviewers

Comment 3

[Martin Giger [:freaktechnik]]

I'm re-titling this bug to only be about the search bar icon regression.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8db62c719a34
Fix search icon in global search results bar. r=aleca