1831035 - [CTW] Unify PDocAccessible, DocAccessibleChild and RemoteAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

Once we no longer support sync IPDL or COM for RemoteAccessible queries, we can unify ipc/other and ipc/win into just ipc. This means we will have a single PDocAccessible, DocAccessibleChild and RemoteAccessible across all platforms. These will subsume DocAccessibleChildBase and RemoteAccessibleBase, so those Base classes will no longer exist separately.

For a time, there may still be a small amount of platform specific stuff in PDocAccessible. IPDL now supports ifdefs, so this isn't a problem like it was previously.

Comment 1

[James Teh [:Jamie]]

We'll need to decide what to do about the remaining methods in Android's PDocAccessiblePlatformExt: either ifdef them or unify them.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1831035 part 1: Remove PDocAccessible::SyncTextChangeEvent.

I neglected to remove this in bug 1821956

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1831035 part 3: Unify PDocAccessible.

There are now only small differences across platforms and even those will probably go away eventually.
Rather than having separate ipdls with a lot of duplicate content, we now have a single ipdl with ifdefs.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1831035 part 4: Move platform specific methods into DocAccessibleChildBase.

Comment 5

[James Teh [:Jamie]]

Attachment: Bug 1831035 part 5: Remove the (now empty) platform specific DocAccessibleChild classes and rename DocAccessibleChildBase to DocAccessibleChild.

Comment 6

[James Teh [:Jamie]]

Attachment: Bug 1831035 part 6: Move platform specific methods into RemoteAccessibleBase.

Comment 7

[James Teh [:Jamie]]

Attachment: Bug 1831035 part 7: Remove (now empty) platform specific RemoteAccessible classes and rename RemoteAccessibleBase to RemoteAccessible.

This involved moving ApplyCache from the .h into the .cpp because now that the class is no longer a template, forward declaration of DocAccessibleParent is not sufficient.

Comment 8

[James Teh [:Jamie]]

Attachment: Bug 1831035 part 2: Remove DocAccessibleChild::RecvAddToSelection.

The sync IPDL RemoteAccessible::AddToSelection was removed in bug 1811092, but the DocAccessibleChildBase method remained.
This is no longer used, so remove it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b9567f148f5
part 1: Remove PDocAccessible::SyncTextChangeEvent. r=nlapre,ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/357079405d41
part 2: Remove DocAccessibleChild::RecvAddToSelection. r=eeejay,ipc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/580af9bf2a56
part 3: Unify PDocAccessible. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/00bab65c5c2d
part 4: Move platform specific methods into DocAccessibleChildBase. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/9069ac980e68
part 5: Remove the (now empty) platform specific DocAccessibleChild classes and rename DocAccessibleChildBase to DocAccessibleChild. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/3e4e49583afb
part 6: Move platform specific methods into RemoteAccessibleBase. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/5c3d85e00cdb
part 7: Remove (now empty) platform specific RemoteAccessible classes and rename RemoteAccessibleBase to RemoteAccessible. r=eeejay

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1b9567f148f5
https://hg.mozilla.org/mozilla-central/rev/357079405d41
https://hg.mozilla.org/mozilla-central/rev/580af9bf2a56
https://hg.mozilla.org/mozilla-central/rev/00bab65c5c2d
https://hg.mozilla.org/mozilla-central/rev/9069ac980e68
https://hg.mozilla.org/mozilla-central/rev/3e4e49583afb
https://hg.mozilla.org/mozilla-central/rev/5c3d85e00cdb