1822239 - Fix and enable folder tree modes tests

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, task, P1)

Description

[Geoff Lankow (:darktrojan)]

I'm going to fix the tests for the unread and smart folder modes. These tests aren't great but they're better than no tests.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1822239 - Fix and enable browser_smartFolders.js. r=#thunderbird-reviewers

There's several things going on here:

• Changing the smart folder initialisation code to be more like that of earlier versions, as it's less problematic.
• Getting the account manager code to handle virtual folders with no source folders (so it can add source folders when they appear).
• Enabling the display of folders inside the inbox.
• Fixing and enabling the test.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1822239 - Fix browser_unreadFolders.js. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/430ba0c24b3f
Fix and enable browser_smartFolders.js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/39f299b1829a
Fix browser_unreadFolders.js. r=mkmelin

Comment 4

[Elizabeth Mitchell]

Attachment: Bug 1822239 - Follow-up: Fix eslint error. r=rjl,#thunderbird-front-end-reviewers DONTBUILD

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ef36f3cf307e
Follow-up: Fix eslint error. r=freaktechnik DONTBUILD

Comment 7

[Intermittent Failures Robot]

3 failures in 3761 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform and build breakdown:

• lint: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1822239&startday=2023-03-13&endday=2023-03-19&tree=all

Comment 8

[Wayne Mery (:wsmwk)]

Likely to take for tomorrow's beta

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9323227 [details]
Bug 1822239 - Follow-up: Fix eslint error. r=rjl,#thunderbird-front-end-reviewers DONTBUILD

[Triage Comment]
Approved for beta, based on convo with Geoff

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9322900 [details]
Bug 1822239 - Fix and enable browser_smartFolders.js. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9322901 [details]
Bug 1822239 - Fix browser_unreadFolders.js. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 12

[Geoff Lankow (:darktrojan)]

FWIW, it's probably better to take these patches as written, not how they landed, which was a mess.

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 112.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/3ac881928f86
https://hg.mozilla.org/releases/comm-beta/rev/ffad92e695f8
https://hg.mozilla.org/releases/comm-beta/rev/5dc40eacba29