1822377 - Port bug 1784348 - improve checks while parsing MIME parameters

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Comment 1

[Alessandro Castellani [:aleca]]

Marking this as regressed bug 1784348 since it busted us completely

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0cb7c43177e
Fix for bustage caused by bug 1784348. rs=bugstage-fix

Comment 3

[Rob Lemley [:rjl]]

Attachment: WIP: Bug 1822377 - Fix for bustage caused by bug 1784348. rs=bugstage-fix

Comment 4

[Wayne Mery (:wsmwk)]

FYI Bug 1784348 - Content-Disposition filename truncation leads to Reflected File Download - is about to be fixed

Comment 5

[Rob Lemley [:rjl]]

Attachment: bug_1822377.patch

Attaching what landed on comm-central for this bug.

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9325669 [details] [diff] [review]
bug_1822377.patch

[Triage Comment]
Upstream bug 1784348 was uplifted to Firefox 112.0b8, so this needs uplifting as well.

Comment 7

[Kai Engert (:KaiE:)]

Comment on attachment 9325669 [details] [diff] [review]
bug_1822377.patch

[Approval Request Comment]
Regression caused by (bug #): 1784348
User impact if declined: build fails
Testing completed (on c-c, etc.): builds
Risk to taking this patch (and alternatives if risky): none

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 112.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/9073bde468b7

Comment 9

[Rob Lemley [:rjl]]

(In reply to Kai Engert (:KaiE:) from comment #7)

Comment on attachment 9325669 [details] [diff] [review]
bug_1822377.patch

[Approval Request Comment]
Regression caused by (bug #): 1784348
User impact if declined: build fails
Testing completed (on c-c, etc.): builds
Risk to taking this patch (and alternatives if risky): none

The upstream bug is on m-e102 as c80e35e82cf9d1bda948ed459bc775c2410903de.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9325669 [details] [diff] [review]
bug_1822377.patch

[Triage Comment]
Approved for esr102

Comment 11

[Ikey Doherty]

Just to confirm the patch applies and ESR102 builds and functions here!

Comment 12

[Rob Lemley [:rjl]]

Reminder to make sure bug 1822421 is uplifted to c-esr102 after this bug.

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 102.10.0:
https://hg.mozilla.org/releases/comm-esr102/rev/6b1344ccf04b