1822421 - Fix code landed as bustage fix in bug 1822377

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[PS]

+++ This bug was initially created as a clone of Bug #1822377 +++

Please use nsDependentCString(header_value) instead of allocating a new string:
https://hg.mozilla.org/comm-central/rev/d0cb7c43177e#l2.13

Comment 1

[Alessandro Castellani [:aleca]]

Kindly redirecting this to Magnus to validate this suggestion.
If it makes sense could you take care of it?

Comment 2

[Kai Engert (:KaiE:)]

Attachment: Bug 1822421 - Use nsDependentCString to avoid unnecessary allocation. r=#thunderbird-reviewers

Comment 3

[Kai Engert (:KaiE:)]

yes it makes sense

Comment 4

[PS]

Usually no new variable is used:
https://searchfox.org/comm-central/search?q=nsDependentCString&path=&case=false&regexp=false
(but that's a matter of taste)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9a6cf93bb303
Use nsDependentCString to avoid unnecessary allocation. r=mkmelin

Comment 6

[Kai Engert (:KaiE:)]

Comment on attachment 9323121 [details]
Bug 1822421 - Use nsDependentCString to avoid unnecessary allocation. r=#thunderbird-reviewers

Please include this correctness fix when uplifting bug 1822377

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9323121 [details]
Bug 1822421 - Use nsDependentCString to avoid unnecessary allocation. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 112.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/6d9517ba44b0

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9323121 [details]
Bug 1822421 - Use nsDependentCString to avoid unnecessary allocation. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 102.10.0:
https://hg.mozilla.org/releases/comm-esr102/rev/28eb241013ee