Closed Bug 1822422 Opened 3 years ago Closed 3 years ago

Add checked style to the text buttons in the Quick Filter toolbar

Categories

(Thunderbird :: Theme, defect, P2)

Thunderbird 113

Tracking

(thunderbird_esr102 unaffected, thunderbird111 wontfix, thunderbird112+ fixed)

RESOLVED FIXED
113 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird111 --- wontfix
thunderbird112 + fixed

People

(Reporter: aleca, Assigned: micah)

References

(Blocks 1 open bug)

Details

(Keywords: regression, ux-mode-error, Whiteboard: [Supernova3p])

Attachments

(2 files)

  • Show the quick filter toolbar
  • Write anything in the quick search input

The buttons to fine tune the filtering of body, subject, etc, should appear underneath.

To Do

  • Style these buttons with the new checked style.
  • Tweak the size via variables to make them smaller and not as tall as the primary checked buttons of the QFB
  • Fix the vertically misaligned text in the QFB (wrap the text and search filed in a flex div to not affect the buttons)
Whiteboard: [Supernova]
Duplicate of this bug: 1822657
Type: enhancement → defect
Keywords: regression
Status: NEW → ASSIGNED
Target Milestone: --- → 113 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/dfc4ea3ccc6b
Add checked style to the text buttons in the Quick Filter toolbar. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

The checked indicator "light" on the Recipients button looks much bigger and different in shape than the others. Some indicators appear with rounded corners, others don't. Also observed on other QFB buttons. Can this be finetuned?

Flags: needinfo?(micah)
Duplicate of this bug: 1823652
Severity: -- → S3
Keywords: ux-mode-error

Note, this issue is driving me batty and among the most reported issues on topicbox, so I want to do an uplift patch for tomorrow's beta, with whatever we have in hand as of tomorrow morning. If there is an updated patch, cool, but I'm also fine if what I have for tomorrow is imperfect.

Severity: S3 → S2
Priority: -- → P2
Blocks: 1823737
Duplicate of this bug: 1823792
Duplicate of this bug: 1823885

Comment on attachment 9323492 [details]
Bug 1822422 - Add checked style to the text buttons in the Quick Filter toolbar. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Attachment #9323492 - Flags: approval-comm-beta+
See Also: → 1823978
Whiteboard: [Supernova] → [Supernova3p]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: