Add checked style to the text buttons in the Quick Filter toolbar
Categories
(Thunderbird :: Theme, defect, P2)
Tracking
(thunderbird_esr102 unaffected, thunderbird111 wontfix, thunderbird112+ fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr102 | --- | unaffected |
thunderbird111 | --- | wontfix |
thunderbird112 | + | fixed |
People
(Reporter: aleca, Assigned: micah)
References
(Blocks 1 open bug)
Details
(Keywords: regression, ux-mode-error, Whiteboard: [Supernova3p])
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
|
Details | Review |
6.48 KB,
image/png
|
Details |
- Show the quick filter toolbar
- Write anything in the quick search input
The buttons to fine tune the filtering of body, subject, etc, should appear underneath.
To Do
- Style these buttons with the new checked style.
- Tweak the size via variables to make them smaller and not as tall as the primary checked buttons of the QFB
- Fix the vertically misaligned text in the QFB (wrap the text and search filed in a flex div to not affect the buttons)
Updated•3 years ago
|
Updated•3 years ago
|
![]() |
Assignee | |
Comment 2•3 years ago
|
||
![]() |
Assignee | |
Updated•3 years ago
|
![]() |
Assignee | |
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/dfc4ea3ccc6b
Add checked style to the text buttons in the Quick Filter toolbar. r=aleca
Comment 4•3 years ago
•
|
||
The checked indicator "light" on the Recipients button looks much bigger and different in shape than the others. Some indicators appear with rounded corners, others don't. Also observed on other QFB buttons. Can this be finetuned?
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Note, this issue is driving me batty and among the most reported issues on topicbox, so I want to do an uplift patch for tomorrow's beta, with whatever we have in hand as of tomorrow morning. If there is an updated patch, cool, but I'm also fine if what I have for tomorrow is imperfect.
Updated•3 years ago
|
![]() |
Assignee | |
Comment 7•3 years ago
|
||
Comment 10•3 years ago
|
||
Comment on attachment 9323492 [details]
Bug 1822422 - Add checked style to the text buttons in the Quick Filter toolbar. r=#thunderbird-front-end-reviewers
[Triage Comment]
Approved for beta
![]() |
||
Comment 11•3 years ago
|
||
bugherder uplift |
Thunderbird 112.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/3ec142d67683
Updated•2 years ago
|
Description
•