1822620 - Crash in [@ java.lang.NullPointerException: at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment.getCheckboxes(DeleteBrowsingDataFragment.kt:6)]

Status: RESOLVED FIXED

(Fenix :: Privacy, defect, P2)

Description

[Chris Peterson [:cpeterson]]

This crash looks like a regression in Fenix 110.

Crash report: https://crash-stats.mozilla.org/report/index/a42f6990-a965-4578-b56d-ed4870230315

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment.getCheckboxes(DeleteBrowsingDataFragment.kt:6)
	at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment.updateDeleteButton(DeleteBrowsingDataFragment.kt:1)
	at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment$$ExternalSyntheticLambda2.onClick(R8$$SyntheticClass:19)
	at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:38)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:268)
	at android.app.ActivityThread.main(ActivityThread.java:8046)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:627)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:997)

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1822620 -A possible fix for NullPointerException. (#1363)

Comment 2

[BMO Github Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/c5cc2296a1640be5fb944e726532bd9153a4b3da
[main] Bug 1822620 - Possible fix for NullPointerException

Comment 3

[Iorga Gabriel]

I removed qe-verify+ flag because I don't know how to reproduce this bug.

Comment 4

[Dianna Smith [:diannaS]]

did we want to uplift this to 112? we only have 1 beta left

Comment 5

[Iorga Gabriel]

I don't know; management should decide. It's a null check .

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1822620 -A possible fix for NullPointerException. (backport #1363) (#1475)

Comment 7

[Amedyne Moya [:amoya]]

:diannaS let' go ahead and uplift this to Beta. Thanks!

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9325970 [details] [review]
[mozilla-mobile/firefox-android] Bug 1822620 -A possible fix for NullPointerException. (backport #1363) (#1475)

Beta/Release Uplift Approval Request

• User impact if declined: Crash
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Approval from Manager although currently no manual qa str
• String changes made/needed: None
• Is Android affected?: Yes

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9325970 [details] [review]
[mozilla-mobile/firefox-android] Bug 1822620 -A possible fix for NullPointerException. (backport #1363) (#1475)

Approved for Mobile 112.0b9

Comment 10

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/f8bb85b97e8e7d4d2cbf9ccb357bc1ecc1883011
[releases_v112] Bug 1822620 - Possible fix for NullPointerException (#1475)