1851259 - Crash in [@ java.lang.NullPointerException: at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment$$ExternalSyntheticLambda2.onClick(R8$$SyntheticClass:27)]

Status: VERIFIED FIXED

(Fenix :: History, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Vlad, this crash looks like a regression starting in Fenix 115. I suspect it's either a new regression or a changed crash signature from your fix in Fenix 115 for bug 1827650. The crash volume is low for now, so this bug might be a lower priority than other bugs you're working.

We've fixed similar NullPointerException crashes in DeleteBrowsingDataFragment in Fenix 111 (bug 1802619), 113 (bug 1822620), and 115 (bug 1827650).

Crash report: https://crash-stats.mozilla.org/report/index/44052a5b-e9c4-436e-9ddb-78b500230901

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment$$ExternalSyntheticLambda2.onClick(R8$$SyntheticClass:27)
	at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:38)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:240)
	at android.os.Looper.loop(Looper.java:351)
	at android.app.ActivityThread.main(ActivityThread.java:8381)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:584)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)

Comment 1

[Vlad Dreghici [:vdreghici]]

I will take a look into this as soon as I can, seems to me like there still might be a method to click on the confirmation dialog after the fragment has been detached.

Comment 2

[Vlad Dreghici [:vdreghici]]

I have been trying to reproduce this crash now for a couple of hours, but couldn't find out what provokes it. I did manage to find it on sentry as well here, but this doesn't give us much to work with.

Considering how close the stack trace is to 1827650, I am pretty sure that there is a similar scenario happening here that we just could not reproduce.

I would wait for some more details on this or some STR, not sure what else could be done.

Comment 3

[Pascal Chevrel:pascalc]

Vlad, is there something actionable for an uplift? Thanks

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1851259 - Delete browsing data only if fragment attached (#3973)

Comment 5

[Vlad Dreghici [:vdreghici]]

(In reply to Pascal Chevrel:pascalc from comment #3)

Vlad, is there something actionable for an uplift? Thanks

I have tried reproducing this and looked at some sentry entries as well, but I could not figure this out. I have created a speculative PR for it, where I think the issue might be.

Comment 6

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/1879088ea2b83c6e3107b3548a68382b211e9474
[main] Bug 1851259 - Delete browsing data only if fragment attached

Comment 7

[Vlad Dreghici [:vdreghici]]

Note for QA team, I could not reproduce this crash on a Pixel 3 with A12 or Pixel 7 with A13. My hunch was that the dialog that asks the user to delete selections might still be visible after somehow leaving the deletion screen. This patch aims to disallow the deletion in case the screen does not exist anymore. I'll do an uplift after this has been verified.

Comment 8

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Nightly ( 120.0a1 from 10.10.2023) with Google Pixel 7 PRO ( Android 14) and Motorola G9 Plus ( Android 11). The app doesn't crash after leaving the deletion screen, when the dialog that asks the user to delete selections was previously visible.

Comment 9

[Adina Petridean QA [:apetridean]]

Attachment: deletebrowsing.mp4

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1851259 - Delete browsing data only if fragment attached (backport #3973) (#4015)

Comment 11

[Vlad Dreghici [:vdreghici]]

Comment on attachment 9357635 [details] [review]
[mozilla-mobile/firefox-android] Bug 1851259 - Delete browsing data only if fragment attached (backport #3973) (#4015)

Beta/Release Uplift Approval Request

• User impact if declined: This fix aims to eliminate the crash which might occur when leaving the deletion fragment, while the deletion confirmation dialog might still be visible. If declined, the crash might continue occurring.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same steps as previously stated.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is not risky because it just disallows taking actions of the dialog when fragment is not attached
• String changes made/needed: no
• Is Android affected?: Yes

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9357635 [details] [review]
[mozilla-mobile/firefox-android] Bug 1851259 - Delete browsing data only if fragment attached (backport #3973) (#4015)

Approved for Fenix 119.0b8

Comment 13

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/6355c0102b22620ce2fbf111574e04ff307eeb44
[releases_v119] Bug 1851259 - Delete browsing data only if fragment attached

Comment 14

[Delia Pop (Android QA)]

Verified on latest Beta 119.0b8. The issue was not encountered.
Tested with:

• Google Pixel 7 Pro ( Android 14)
• Lenovo Tab P11 Pro (Android 12)
• Xiaomi Mi 8 Lite (Android 10)
• Huawei MediaPad M2 (Android 5.1.1)