1827650 - Crash in [@ java.lang.NullPointerException: at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment$$ExternalSyntheticLambda2.onClick(R8$$SyntheticClass:24)]

Status: RESOLVED FIXED

(Firefox for Android :: General, defect, P2)

Description

[Chris Peterson [:cpeterson]]

A crash with a similar signature (bug 1802619) was fixed in 111, but we're seeing new crashes in 112 and 113. These crashes have the same stack trace but a different line number in ExternalSyntheticLambda2.onClick:

Crash report: https://crash-stats.mozilla.org/report/index/f85739e2-9fe9-4bd0-b47b-474490230408

Java stack trace:

java.lang.NullPointerException
	at org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataFragment$$ExternalSyntheticLambda2.onClick(R8$$SyntheticClass:24)
	at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:38)
	at android.os.Handler.dispatchMessage(Handler.java:111)
	at android.os.Looper.loopOnce(Looper.java:238)
	at android.os.Looper.loop(Looper.java:357)
	at android.app.ActivityThread.main(ActivityThread.java:8090)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1026)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jonalmeida, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Jonathan Almeida [:jonalmeida]]

This looks like a regression from bug 1822620. What do you think Gabriel?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:giorga, since you are the author of the regressor, bug 1822620, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Iorga Gabriel]

I don't know Jonathan. I only added runIfFragmentIsAttached when getCheckboxes() is called.

Comment 5

[Chris Peterson [:cpeterson]]

Vlad, you fixed bug 1802619 with a similar crash signature in Fenix 110. Is this crash regression in Fenix 112 the same issue as bug 1802619?

Comment 6

[Vlad Dreghici [:vdreghici]]

Attachment: ezgif.com-resize.mp4

(In reply to Chris Peterson [:cpeterson] from comment #5)

Vlad, you fixed bug 1802619 with a similar crash signature in Fenix 110. Is this crash regression in Fenix 112 the same issue as bug 1802619?

Indeed, it seems like the crash is similar to 1802619. I managed to reproduce it with the following steps:

1. Go to settings.
2. Go to delete browsing data.
3. Select any options, BUT include the "Open tabs" option, since it is the only one taking the user to the settings page after deletion is done.
4. Tap Delete browsing data.
5. Tap Delete.
6. While delete in progress, proceed to check/uncheck any number of boxes EXCEPT the "Open tabs" one.
7. While delete in progress, tap "Delete browsing data". Do not tap anything on the dialog.
8. When deletion is finished and the user is taken back, if the confirmation dialog is still displayed and the delete button is pressed, the app will crash.

I have also attached a video.

Expected behavior:

• When the deletion is in progress, the user should not be able to check/uncheck any of the boxes until the deletion has been completed.

Actual behavior:

• While deletion is in progress, the user is still able to check/uncheck checkboxes, leading to unlocking the possibility of tapping the "Delete browsing data button".

I'll be working on fixing this by disabling interaction with checkboxes while deletion in progress.

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1827650 - Disable checkboxes when deletion in progress. (#1958)

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1822620

Comment 9

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/3a15baf3e01f16ac6038d073c137b1b966f71dd3
[main] Bug 1827650 - Disable checkboxes when deletion in progress.

Comment 10

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Fenix build 115.0a1 from 5/15 with the following devices:

• Samsung Galaxy Note 8 (Android 9), and
• Google Pixel 6 (Android 13).

The user is no longer able to interact with the checkboxes while deletion in progress.