1823182 - Nothing in the `View` toolbar button works - e.g. Not Deleted / Unread / Tags / Customize

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P3)

Description

[km]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36

Steps to reproduce:

I use the mark deleted method instead of move to trash. I invoke
View->Messages>Not Delete

Actual results:

Nothing. It has no effect, my Inbox still displays the deleted (crossed out) mail.

Expected results:

My Inbox should only show the messages that are not crossed out..

Additional Information: View->Message->Unread doesn't do anything either. However, there is an icon for this in the new toolbar that does work. There is no icon for view not deleted. There used to be a view item in toolbar customize that had a working menu including "not deleted", but its no longer there.

Hoping for a workaround. This is pretty unusable as is.

Comment 1

[Wayne Mery (:wsmwk)]

Please post your results when 112.0b3 becomes available in the next couple days.

Comment 2

[km]

I just updated from 112.0b1 to 112.0b2 with no change. Waiting for 112.0b3

Comment 3

[km]

I just updated from 112.0b1 to 112.0b2 with no change. Waiting for 112.0b3
I just updated to 112.0b3. View Menu items still have no effect

Comment 4

[Wayne Mery (:wsmwk)]

This also didn't work in 111.0b1.

Uncaught ReferenceError: gFolderDisplay is not defined
get currentViewValue chrome://messenger/content/msgViewPickerOverlay.js:101
RefreshViewPopup chrome://messenger/content/msgViewPickerOverlay.js:174
onpopupshowing chrome://messenger/content/messenger.xhtml:1

Not sure if this is message list or sn-unifiedtoolbar

Comment 5

[Richard Marti (:Paenglab)]

Important: to see the menuitem View->Message you have to place the View widget on the unified toolbar. This widget still uses the gFolderDisplay.

The Not Delete wasn't a standard function. It was added manually through Customize in this widget. I think when the gFolderDisplay is working again then it will be back.

Comment 6

[km]

I did figure out how to add the view menu to the main toolbar a while ago. But note, its not just the "not deleted" that doesn't work. None of the entries work (Unread, Tags, etc).

Comment 7

[Alessandro Castellani [:aleca]]

This is unified toolbar territory, and we're aware that that button doesn't work because it's a mess.
That button is basically a quick filter bar with virtual folder filters and customizable options. Someone in the past thought it was a smart idea to put everything into a popup instead of exposing better contextual filter options and now we need to deal with that.
We need more time to tackle this.

Comment 8

[Thomas D. (:thomas8)]

I was cracking my Monday noon head why this bug wouldn't show up in our queries, until I found that it was erroneously marked as Depends on: sn-msglist instead of Blocks: sn-msglist... Issue bugs always need to block their parent meta bug.

Comment 9

[Thomas D. (:thomas8)]

(In reply to Alessandro Castellani [:aleca] from comment #7)

This is unified toolbar territory

Comment 10

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: `View` toolbar button with dropdown menu (from unified toolbar customization)

Here's what we're talking about: View toolbar button with dropdown menu (available from unified toolbar customization)

Comment 11

[km]

Just updated to 112.0b4 no change.

Comment 12

[km]

Just update to 112.0b6. No change. Any idea on when the may be resolved?

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to km from comment #12)

Just update to 112.0b6. No change. Any idea on when the may be resolved?

Please refrain from frequent status updates - it doesn't add useful data.
Also, it's not possible to predict when this will be resolved.

Comment 14

[km]

What info do you need?

Comment 15

[Alessandro Castellani [:aleca]]

No info, Magnus will take a look at this and investigate how to fix it. We use the needinfo flag so he can keep track of it.

Comment 16

[Geoff Lankow (:darktrojan)]

I've got this, or at least I'm so far down the rabbit hole I might as well take it.

Comment 17

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1823182 - Fix the View toolbar button. r=#thunderbird-front-end-reviewers

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d58c4eb87ff1
Fix the View toolbar button. r=freaktechnik

Comment 19

[km]

I'm on 114.0b6, when will I see the fix. It's been really tough without view not deleted.

Comment 20

[km]

I'm now on 115.0b1, will the fix show up in the next 115 beta?

Comment 21

[Geoff Lankow (:darktrojan)]

Comment on attachment 9337996 [details]
Bug 1823182 - Fix the View toolbar button. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): new toolbar
User impact if declined: View button does nothing
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): surely can't be worse than it was

Comment 22

[Wayne Mery (:wsmwk)]

Comment on attachment 9337996 [details]
Bug 1823182 - Fix the View toolbar button. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 23

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/bf53e78267b6