1838589 - Items in the view button are not persistent - when switching between folders the last view for the specific folder should be applied

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Pascal Chevrel:pascalc]

Attachment: View drop down list

Thunderbird 1150b2, Linux.

The items you select via the view drop down button should persist. This is a regression from 110 beta (I went from 110beta to 115beta2).

STR:
1 Select Unread messages from the view
2 See that now unread messages only are displayed
3 click on another folder and click back to the folder you were in

ER:
Only unread messages are displayed

AR:
All messages are displayed

Comment 1

[Wayne Mery (:wsmwk)]

km, does this reproduce for you with 115.0b2?

related? Bug 1823182 - Nothing in the View toolbar button works - e.g. Not Deleted / Unread / Tags / Customize

Comment 2

[km]

I just updated to 115.0b2 from b1 which did in fact fix Bug 1823182 and the view menu now works. As far as Bug 1838589 I cannot reproduce the problem. I tried switching between different folders and the view choice for that folder sticks.

Comment 3

[Alessandro Castellani [:aleca]]

Tentatively marking this as WFM as per comment 2, we can reopen it if needed.

Comment 4

[Pascal Chevrel:pascalc]

This is still broken for me in 115b4.

Comment 5

[Alessandro Castellani [:aleca]]

Is the original STR still valid?
I can't reproduce it either.

Comment 6

[Pascal Chevrel:pascalc]

Yes, the steps are still valid.

Comment 7

[Wayne Mery (:wsmwk)]

Steve, can you reproduce?

Comment 8

[Steve Edmonds]

Attachment: Filter bar

Sorry if I sound a bit vague, where is the view drop down list shown in the initial post?
If I select "unread" and "sticky" buttons only unread messages are shown, including changing folders, until I deselect "sticky" or "unread"

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Steve Edmonds from comment #8)

Sorry if I sound a bit vague, where is the view drop down list shown in the initial post?

Not quick filter bar.
The View widget is a toolbar button, which must be added to the unified toolbar. The icon is an eye.

Comment 11

[Wayne Mery (:wsmwk)]

Reproduces easily

Comment 12

[Alessandro Castellani [:aleca]]

Martin, I know the "View" button is our favourite toolbar widget.
Would you be able to tackle this?

Comment 18

[Wayne Mery (:wsmwk)]

Martin writes in matrix "I have no idea at least for me it wouldn't be easy." So this is stalled.

Comment 19

[David Goadby]

This is a very irritating bug but, having upgraded, I guess I have to live with it until it is fixed.

I took the 115.3.1 update in the faint hope it was sorted but no.

Is this a hard one to fix or are only a few people affected? I notice it is Priority 2 so I guess I will have to be patient.

Comment 20

[tlveik]

This bug affects me also.
Version 115.3.1
Windows 11
I typically use Custom View - Recent or Important. This selection is not saved when Thunderbird is closed.
If I can provide any info to help fix this bug, let me know.

Comment 21

[betterbird.project+11]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1838589-fix-mail-view.patch

Comment 24

[Joe Wells]

Until the patch from the betterbird project above in comment #20 (or whatever patch that turns into) gets delivered through all the right channels, here's a workaround:

For each folder that you vitally depend on keeping its custom view setting, open that folder in its own tab, and then in each such new tab turn off the folder pane so that you won't accidentally switch the tab to looking at a separate folder. You can still switch folders in your main tab.

This seems like it will be a "good enough for a few weeks" solution for me, because I mainly depend on setting persistent custom views for just a few folders.

Any better suggestions?

Comment 25

[Magnus Melin [:mkmelin]]

Gah, the whole View widget is really quite confusing now in 115 since it doesn't show what view is applied :/
In 102 it showed View: [<name in dropdown>].

Comment 26

[Magnus Melin [:mkmelin]]

Attachment: Bug 1838589 - Restore the View button settings for the folder when revisiting it. r=freaktechnik

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1838589-fix-mail-view.patch

Comment 27

[Martin Giger [:freaktechnik]]

(In reply to Magnus Melin [:mkmelin] from comment #25)

Gah, the whole View widget is really quite confusing now in 115 since it doesn't show what view is applied :/
In 102 it showed View: [<name in dropdown>].

ah, I wasn't aware of that and I guess we never fixed it when we hooked the widget back up again. Would probably require a new string though, unless the old one is still around.

(The folder location button updates its label based on the selection, for example)

EDIT: shouldn't actually need any string changes if it follows the location button functionality.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d5e44997df5
Restore the View button settings for the folder when revisiting it. r=freaktechnik

Comment 29

[Kai Engert (:KaiE:)]

I'll back this out. It causes at least one regression and test failure. Our tree has several failures, I haven't yet checked if it's reponsible for other failures, too.

You can reproduce by building on Linux, running test comm/mail/test/browser/folder-display/browser_openingMessages.js
which gives:
FAIL uncaught exception - TypeError: can't access property "isVisible", top.ViewPickerBinding is undefined at get shouldUseMailViews@chrome://messenger/content/mailCommon.js:915:5

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/171df021eb70
Backed out changeset 7d5e44997df5 for test failures.

Comment 31

[Kai Engert (:KaiE:)]

This probably should get a try run before relanding.

Comment 32

[betterbird.project+11]

Sorry about that, we suggest to use:

  get shouldUseMailViews() {
    return top.ViewPickerBinding?.isVisible || false;
  },

Comment 33

[Magnus Melin [:mkmelin]]

Fixed version now uploaded. Successful try https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=461e4c760338d15bae7456df64bcb179f5447095&selectedTaskRun=VxZ8CBr3RQ6a0KFeqgCmDg.0

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e8de928f24a9
Restore the View button settings for the folder when revisiting it. r=freaktechnik

Comment 35

[Magnus Melin [:mkmelin]]

Comment on attachment 9357993 [details]
Bug 1838589 - Restore the View button settings for the folder when revisiting it. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: view is not restored when moving between folders
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 36

[Wayne Mery (:wsmwk)]

Comment on attachment 9357993 [details]
Bug 1838589 - Restore the View button settings for the folder when revisiting it. r=freaktechnik

[Triage Comment]
no betas left in this cycle

Comment 37

[Wayne Mery (:wsmwk)]

(In reply to Magnus Melin [:mkmelin] from comment #35)

Risk to taking this patch (and alternatives if risky): safe

Agree this should be safe, and it's totally broken now anyway, so taking this for 115.4.0.

Comment 38

[Wayne Mery (:wsmwk)]

Comment on attachment 9357993 [details]
Bug 1838589 - Restore the View button settings for the folder when revisiting it. r=freaktechnik

[Triage Comment]
Approved for esr115

Comment 39

[Daniel Darnell [:dandarnell]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/b580917f0560